From: Sam Ravnborg <sam@ravnborg.org>
To: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Michal Hocko <mhocko@kernel.org>,
sparclinux@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] sparc32: tidy up ramdisk memory reservation
Date: Fri, 03 Aug 2018 20:18:16 +0000 [thread overview]
Message-ID: <20180803201816.GB7789@ravnborg.org> (raw)
In-Reply-To: <1533210833-14748-3-git-send-email-rppt@linux.vnet.ibm.com>
Hi Mike.
On Thu, Aug 02, 2018 at 02:53:53PM +0300, Mike Rapoport wrote:
> The detection and reservation of ramdisk memory were separated to allow
> bootmem bitmap initialization after the ramdisk boundaries are detected.
> Since the bootmem initialization is removed, the reservation of ramdisk
> memory can be done immediately after its boundaries are found.
When touching this area could you look
at introducing a find_ramdisk() function like
we do for sparc64?
It is always nice when the codebases look alike.
Then you could combine your simplification
with some refactoring that further increases
readability.
See:
https://patchwork.ozlabs.org/patch/151194/
for my attempt from long time ago.
Sam
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Michal Hocko <mhocko@kernel.org>,
sparclinux@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] sparc32: tidy up ramdisk memory reservation
Date: Fri, 3 Aug 2018 22:18:16 +0200 [thread overview]
Message-ID: <20180803201816.GB7789@ravnborg.org> (raw)
In-Reply-To: <1533210833-14748-3-git-send-email-rppt@linux.vnet.ibm.com>
Hi Mike.
On Thu, Aug 02, 2018 at 02:53:53PM +0300, Mike Rapoport wrote:
> The detection and reservation of ramdisk memory were separated to allow
> bootmem bitmap initialization after the ramdisk boundaries are detected.
> Since the bootmem initialization is removed, the reservation of ramdisk
> memory can be done immediately after its boundaries are found.
When touching this area could you look
at introducing a find_ramdisk() function like
we do for sparc64?
It is always nice when the codebases look alike.
Then you could combine your simplification
with some refactoring that further increases
readability.
See:
https://patchwork.ozlabs.org/patch/151194/
for my attempt from long time ago.
Sam
next prev parent reply other threads:[~2018-08-03 20:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 11:53 [PATCH 0/2] sparc32: switch to NO_BOOTMEM Mike Rapoport
2018-08-02 11:53 ` Mike Rapoport
2018-08-02 11:53 ` [PATCH 1/2] " Mike Rapoport
2018-08-02 11:53 ` Mike Rapoport
2018-08-03 20:07 ` Sam Ravnborg
2018-08-03 20:07 ` Sam Ravnborg
2018-08-02 11:53 ` [PATCH 2/2] sparc32: tidy up ramdisk memory reservation Mike Rapoport
2018-08-02 11:53 ` Mike Rapoport
2018-08-03 20:18 ` Sam Ravnborg [this message]
2018-08-03 20:18 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180803201816.GB7789@ravnborg.org \
--to=sam@ravnborg.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=rppt@linux.vnet.ibm.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.