All of lore.kernel.org
 help / color / mirror / Atom feed
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: framebuffer corruption due to overlapping stp instructions on arm64
Date: Sun, 5 Aug 2018 23:51:50 +0200	[thread overview]
Message-ID: <20180805215150.GB1862@amd> (raw)
In-Reply-To: <alpine.LRH.2.02.1808040611070.23762@file01.intranet.prod.int.rdu2.redhat.com>

Hi!

> > Can you run the test program on x86 using the similar framebuffer
> > setup?  Does doing two writes (one aligned and one unaligned but
> > overlapping with previous one) cause the same issue?  I suspect it
> > does, then using memcpy for frame buffers is wrong.

I'm pretty sure it will work ok on x86.

> Overlapping unaligned writes work on x86 - they have to, because of 
> backward compatibility.

It is not that easy. 8086s (and similar) did not have MTRRs and PATs
either. Overlapping unaligned writes _on main memory_, _with normal
MTRR settings_ certainly work ok on x86.

Chances is memory type can be configured to work similar way on your
ARM/PCIe case?

> 8086, 80286 and 80386 didn't have any cache at all.

386s had cache (but not on die).
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180805/bbf8727f/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Andrew Pinski <pinskia@gmail.com>,
	Richard Earnshaw <Richard.Earnshaw@arm.com>,
	ard.biesheuvel@linaro.org,
	Ramana Radhakrishnan <ramana.gcc@googlemail.com>,
	Florian Weimer <fweimer@redhat.com>,
	thomas.petazzoni@free-electrons.com,
	GNU C Library <libc-alpha@sourceware.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	linux@armlinux.org.uk, LKML <linux-kernel@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: framebuffer corruption due to overlapping stp instructions on arm64
Date: Sun, 5 Aug 2018 23:51:50 +0200	[thread overview]
Message-ID: <20180805215150.GB1862@amd> (raw)
In-Reply-To: <alpine.LRH.2.02.1808040611070.23762@file01.intranet.prod.int.rdu2.redhat.com>

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

Hi!

> > Can you run the test program on x86 using the similar framebuffer
> > setup?  Does doing two writes (one aligned and one unaligned but
> > overlapping with previous one) cause the same issue?  I suspect it
> > does, then using memcpy for frame buffers is wrong.

I'm pretty sure it will work ok on x86.

> Overlapping unaligned writes work on x86 - they have to, because of 
> backward compatibility.

It is not that easy. 8086s (and similar) did not have MTRRs and PATs
either. Overlapping unaligned writes _on main memory_, _with normal
MTRR settings_ certainly work ok on x86.

Chances is memory type can be configured to work similar way on your
ARM/PCIe case?

> 8086, 80286 and 80386 didn't have any cache at all.

386s had cache (but not on die).
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

  parent reply	other threads:[~2018-08-05 21:51 UTC|newest]

Thread overview: 238+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-02 19:31 framebuffer corruption due to overlapping stp instructions on arm64 Mikulas Patocka
2018-08-02 19:31 ` Mikulas Patocka
     [not found] ` <CAHCPf3tFGqkYEcWNN4LaWThw_rVqT316pzLv6T7RfxwO-eZ0EA@mail.gmail.com>
2018-08-03  6:35   ` Mikulas Patocka
2018-08-03  6:35     ` Mikulas Patocka
2018-08-03  7:16     ` Ard Biesheuvel
2018-08-03  7:16       ` Ard Biesheuvel
2018-08-03  9:41       ` Will Deacon
2018-08-03  9:41         ` Will Deacon
2018-08-03 17:09         ` Mikulas Patocka
2018-08-03 17:09           ` Mikulas Patocka
2018-08-03 17:09           ` Mikulas Patocka
2018-08-03 17:32           ` Sinan Kaya
2018-08-03 17:32             ` Sinan Kaya
2018-08-03 17:32             ` Sinan Kaya
2018-08-03 17:33           ` Ard Biesheuvel
2018-08-03 17:33             ` Ard Biesheuvel
2018-08-03 17:33             ` Ard Biesheuvel
2018-08-03 18:25             ` Mikulas Patocka
2018-08-03 18:25               ` Mikulas Patocka
2018-08-03 18:25               ` Mikulas Patocka
2018-08-03 20:44               ` Matt Sealey
2018-08-03 20:44                 ` Matt Sealey
2018-08-03 20:44                 ` Matt Sealey
2018-08-03 21:20                 ` Ard Biesheuvel
2018-08-03 21:20                   ` Ard Biesheuvel
2018-08-03 21:20                   ` Ard Biesheuvel
2018-08-06 10:25                   ` Mikulas Patocka
2018-08-06 10:25                     ` Mikulas Patocka
2018-08-06 10:25                     ` Mikulas Patocka
2018-08-06 12:42                     ` Robin Murphy
2018-08-06 12:42                       ` Robin Murphy
2018-08-06 12:42                       ` Robin Murphy
2018-08-06 12:53                       ` Ard Biesheuvel
2018-08-06 12:53                         ` Ard Biesheuvel
2018-08-06 12:53                         ` Ard Biesheuvel
2018-08-06 13:41                       ` Marcin Wojtas
2018-08-06 13:41                         ` Marcin Wojtas
2018-08-06 13:41                         ` Marcin Wojtas
2018-08-06 13:48                         ` Ard Biesheuvel
2018-08-06 13:48                           ` Ard Biesheuvel
2018-08-06 13:48                           ` Ard Biesheuvel
2018-08-06 14:07                           ` Marcin Wojtas
2018-08-06 14:07                             ` Marcin Wojtas
2018-08-06 14:07                             ` Marcin Wojtas
2018-08-06 14:13                             ` Mikulas Patocka
2018-08-06 14:13                               ` Mikulas Patocka
2018-08-06 14:13                               ` Mikulas Patocka
2018-08-06 15:47                       ` Ard Biesheuvel
2018-08-06 15:47                         ` Ard Biesheuvel
2018-08-06 15:47                         ` Ard Biesheuvel
2018-08-06 17:09                         ` Mikulas Patocka
2018-08-06 17:09                           ` Mikulas Patocka
2018-08-06 17:09                           ` Mikulas Patocka
2018-08-06 17:21                           ` Ard Biesheuvel
2018-08-06 17:21                             ` Ard Biesheuvel
2018-08-06 17:21                             ` Ard Biesheuvel
2018-08-06 19:54                             ` Mikulas Patocka
2018-08-06 19:54                               ` Mikulas Patocka
2018-08-06 19:54                               ` Mikulas Patocka
2018-08-06 20:11                               ` Ard Biesheuvel
2018-08-06 20:11                                 ` Ard Biesheuvel
2018-08-06 20:11                                 ` Ard Biesheuvel
2018-08-06 20:31                                 ` Mikulas Patocka
2018-08-06 20:31                                   ` Mikulas Patocka
2018-08-06 20:31                                   ` Mikulas Patocka
2018-08-07 16:40                                 ` Marcin Wojtas
2018-08-07 16:40                                   ` Marcin Wojtas
2018-08-07 16:40                                   ` Marcin Wojtas
2018-08-07 17:39                                   ` Mikulas Patocka
2018-08-07 17:39                                     ` Mikulas Patocka
2018-08-07 17:39                                     ` Mikulas Patocka
2018-08-07 18:07                                     ` Ard Biesheuvel
2018-08-07 18:07                                       ` Ard Biesheuvel
2018-08-07 18:07                                       ` Ard Biesheuvel
2018-08-07 18:17                                       ` Mikulas Patocka
2018-08-07 18:17                                         ` Mikulas Patocka
2018-08-07 18:17                                         ` Mikulas Patocka
     [not found]                                     ` <CAPv3WKcKoEe=Qysp6Oac2C=G9bUhUQf1twSRCY+_qJ6XEC-iag@mail.gmail.com>
2018-08-08 14:10                                       ` Mikulas Patocka
2018-08-08 14:10                                         ` Mikulas Patocka
2018-08-08 14:10                                         ` Mikulas Patocka
2018-08-06 17:13                         ` Catalin Marinas
2018-08-06 17:13                           ` Catalin Marinas
2018-08-06 17:13                           ` Catalin Marinas
2018-08-06 17:19                           ` Mikulas Patocka
2018-08-06 17:19                             ` Mikulas Patocka
2018-08-06 17:19                             ` Mikulas Patocka
2018-08-08 18:31                       ` Mikulas Patocka
2018-08-08 18:31                         ` Mikulas Patocka
2018-08-08 18:31                         ` Mikulas Patocka
2018-08-04 13:29                 ` Mikulas Patocka
2018-08-04 13:29                   ` Mikulas Patocka
2018-08-04 13:29                   ` Mikulas Patocka
2018-08-08 12:16                 ` Catalin Marinas
2018-08-08 12:16                   ` Catalin Marinas
2018-08-08 12:16                   ` Catalin Marinas
2018-08-08 13:02                   ` David Laight
2018-08-08 13:02                     ` David Laight
2018-08-08 13:02                     ` David Laight
2018-08-08 13:46                     ` Mikulas Patocka
2018-08-08 13:46                       ` Mikulas Patocka
2018-08-08 13:46                       ` Mikulas Patocka
2018-08-08 14:26                       ` David Laight
2018-08-08 14:26                         ` David Laight
2018-08-08 14:26                         ` David Laight
2018-08-08 14:50                         ` Catalin Marinas
2018-08-08 14:50                           ` Catalin Marinas
2018-08-08 14:50                           ` Catalin Marinas
2018-08-08 16:21                           ` Mikulas Patocka
2018-08-08 16:21                             ` Mikulas Patocka
2018-08-08 16:21                             ` Mikulas Patocka
2018-08-08 16:31                             ` Arnd Bergmann
2018-08-08 16:31                               ` Arnd Bergmann
2018-08-08 16:31                               ` Arnd Bergmann
2018-08-08 16:43                               ` David Laight
2018-08-08 16:43                                 ` David Laight
2018-08-08 16:43                                 ` David Laight
2018-08-08 18:56                                 ` Mikulas Patocka
2018-08-08 18:56                                   ` Mikulas Patocka
2018-08-08 18:56                                   ` Mikulas Patocka
2018-08-08 18:37                         ` Mikulas Patocka
2018-08-08 18:37                           ` Mikulas Patocka
2018-08-08 18:37                           ` Mikulas Patocka
2018-08-08 11:39           ` Catalin Marinas
2018-08-08 11:39             ` Catalin Marinas
2018-08-08 11:39             ` Catalin Marinas
2018-08-08 14:12             ` Mikulas Patocka
2018-08-08 14:12               ` Mikulas Patocka
2018-08-08 14:12               ` Mikulas Patocka
2018-08-08 14:28               ` Catalin Marinas
2018-08-08 14:28                 ` Catalin Marinas
2018-08-08 14:28                 ` Catalin Marinas
2018-08-08 18:40                 ` Mikulas Patocka
2018-08-08 18:40                   ` Mikulas Patocka
2018-08-08 18:40                   ` Mikulas Patocka
2018-08-08 15:01               ` Richard Earnshaw (lists)
2018-08-08 15:01                 ` Richard Earnshaw (lists)
2018-08-08 15:01                 ` Richard Earnshaw (lists)
2018-08-08 15:14                 ` Catalin Marinas
2018-08-08 15:14                   ` Catalin Marinas
2018-08-08 15:14                   ` Catalin Marinas
2018-08-08 16:01                   ` Arnd Bergmann
2018-08-08 16:01                     ` Arnd Bergmann
2018-08-08 16:01                     ` Arnd Bergmann
2018-08-08 18:25                     ` Mikulas Patocka
2018-08-08 18:25                       ` Mikulas Patocka
2018-08-08 18:25                       ` Mikulas Patocka
2018-08-08 21:51                       ` Arnd Bergmann
2018-08-08 21:51                         ` Arnd Bergmann
2018-08-08 21:51                         ` Arnd Bergmann
2018-08-09 15:29                         ` Arnd Bergmann
2018-08-09 15:29                           ` Arnd Bergmann
2018-08-09 15:29                           ` Arnd Bergmann
2018-08-03  7:11 ` Andrew Pinski
2018-08-03  7:11   ` Andrew Pinski
2018-08-03  7:53   ` Florian Weimer
2018-08-03  7:53     ` Florian Weimer
2018-08-03  9:12     ` Szabolcs Nagy
2018-08-03  9:12       ` Szabolcs Nagy
2018-08-03  9:15     ` Ramana Radhakrishnan
2018-08-03  9:15       ` Ramana Radhakrishnan
2018-08-03  9:29       ` Ard Biesheuvel
2018-08-03  9:29         ` Ard Biesheuvel
2018-08-03  9:37         ` Ramana Radhakrishnan
2018-08-03  9:37           ` Ramana Radhakrishnan
2018-08-03  9:42         ` Richard Earnshaw (lists)
2018-08-03  9:42           ` Richard Earnshaw (lists)
2018-08-04  0:58           ` Mikulas Patocka
2018-08-04  0:58             ` Mikulas Patocka
2018-08-04  1:13             ` Andrew Pinski
2018-08-04  1:13               ` Andrew Pinski
2018-08-04 11:04               ` Mikulas Patocka
2018-08-04 11:04                 ` Mikulas Patocka
2018-08-05 18:33                 ` Florian Weimer
2018-08-05 18:33                   ` Florian Weimer
2018-08-06  8:02                   ` Mikulas Patocka
2018-08-06  8:02                     ` Mikulas Patocka
2018-08-06  8:10                     ` Ard Biesheuvel
2018-08-06  8:10                       ` Ard Biesheuvel
2018-08-06 10:31                       ` Mikulas Patocka
2018-08-06 10:31                         ` Mikulas Patocka
2018-08-06 10:37                         ` Ard Biesheuvel
2018-08-06 10:37                           ` Ard Biesheuvel
2018-08-06 10:42                           ` Mikulas Patocka
2018-08-06 10:42                             ` Mikulas Patocka
2018-08-06 10:48                             ` Ard Biesheuvel
2018-08-06 10:48                               ` Ard Biesheuvel
2018-08-06 12:09                               ` Mikulas Patocka
2018-08-06 12:09                                 ` Mikulas Patocka
2018-08-06 12:19                                 ` Ard Biesheuvel
2018-08-06 12:19                                   ` Ard Biesheuvel
2018-08-06 12:22                                   ` Ard Biesheuvel
2018-08-06 12:22                                     ` Ard Biesheuvel
2018-08-07 14:14                                   ` Mikulas Patocka
2018-08-07 14:14                                     ` Mikulas Patocka
2018-08-07 14:40                                     ` Ard Biesheuvel
2018-08-07 14:40                                       ` Ard Biesheuvel
2018-08-08 19:15                                   ` Mikulas Patocka
2018-08-08 19:15                                     ` Mikulas Patocka
2018-08-06 11:19                         ` Siddhesh Poyarekar
2018-08-06 11:19                           ` Siddhesh Poyarekar
2018-08-06 11:29                           ` Ard Biesheuvel
2018-08-06 11:29                             ` Ard Biesheuvel
2018-08-06 14:26                   ` Tulio Magno Quites Machado Filho
2018-08-06 14:26                     ` Tulio Magno Quites Machado Filho
2018-08-05 21:51                 ` Pavel Machek [this message]
2018-08-05 21:51                   ` Pavel Machek
2018-08-06 14:30                   ` Mikulas Patocka
2018-08-06 14:30                     ` Mikulas Patocka
2018-08-03 11:24         ` David Laight
2018-08-03 11:24           ` David Laight
2018-08-03 12:04           ` Mikulas Patocka
2018-08-03 12:04             ` Mikulas Patocka
2018-08-03 13:04             ` David Laight
2018-08-03 13:04               ` David Laight
2018-08-05 14:36               ` Mikulas Patocka
2018-08-05 14:36                 ` Mikulas Patocka
2018-08-06 10:18                 ` David Laight
2018-08-06 10:18                   ` David Laight
2018-08-07 14:07                   ` Mikulas Patocka
2018-08-07 14:07                     ` Mikulas Patocka
2018-08-07 14:33                     ` David Laight
2018-08-07 14:33                       ` David Laight
2018-08-08 14:21                       ` Mikulas Patocka
2018-08-08 14:21                         ` Mikulas Patocka
2018-08-03 13:20     ` Mikulas Patocka
2018-08-03 13:20       ` Mikulas Patocka
2018-08-03 13:31   ` Mikulas Patocka
2018-08-03 13:31     ` Mikulas Patocka
2018-08-03 14:17     ` Richard Earnshaw (lists)
2018-08-03 14:17       ` Richard Earnshaw (lists)
2018-08-05 21:36   ` Pavel Machek
2018-08-05 21:36     ` Pavel Machek
2018-08-06  8:04     ` Ramana Radhakrishnan
2018-08-06  8:04       ` Ramana Radhakrishnan
2018-08-06  8:44       ` Pavel Machek
2018-08-06  8:44         ` Pavel Machek
2018-08-06  9:11         ` Ard Biesheuvel
2018-08-06  9:11           ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180805215150.GB1862@amd \
    --to=pavel@ucw.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.