[PATCH] platform/x86: acer-wmi: refactor function has_cap

[PATCH] platform/x86: acer-wmi: refactor function has_cap

[Gustavo A. R. Silva]

Refactor function has_cap in order to avoid returning integer
values, when instead it should return booleans.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/platform/x86/acer-wmi.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 8952173..ff1689d 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -672,10 +672,7 @@ static void __init find_quirks(void)
 
 static bool has_cap(u32 cap)
 {
-	if ((interface->capability & cap) != 0)
-		return 1;
-
-	return 0;
+	return (interface->capability & cap) != 0;
 }
 
 /*
-- 
2.7.4

Re: [PATCH] platform/x86: acer-wmi: refactor function has_cap

[Andy Shevchenko]

On Mon, Aug 6, 2018 at 11:00 PM, Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> Refactor function has_cap in order to avoid returning integer
> values, when instead it should return booleans.
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  drivers/platform/x86/acer-wmi.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 8952173..ff1689d 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -672,10 +672,7 @@ static void __init find_quirks(void)
>
>  static bool has_cap(u32 cap)
>  {
> -       if ((interface->capability & cap) != 0)
> -               return 1;
> -
> -       return 0;
> +       return (interface->capability & cap) != 0;
>  }

Thanks, as Joe mentioned even != 0 part is not needed (followed by
unneeded parens), though I would let it be (one line is good enough to
me) if there will be no strong preferences.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/x86: acer-wmi: refactor function has_cap

[Gustavo A. R. Silva]

On 8/6/18 3:16 PM, Andy Shevchenko wrote:
> On Mon, Aug 6, 2018 at 11:00 PM, Gustavo A. R. Silva
> <gustavo@embeddedor.com> wrote:
>> Refactor function has_cap in order to avoid returning integer
>> values, when instead it should return booleans.
>>
>> This code was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>>  drivers/platform/x86/acer-wmi.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>> index 8952173..ff1689d 100644
>> --- a/drivers/platform/x86/acer-wmi.c
>> +++ b/drivers/platform/x86/acer-wmi.c
>> @@ -672,10 +672,7 @@ static void __init find_quirks(void)
>>
>>  static bool has_cap(u32 cap)
>>  {
>> -       if ((interface->capability & cap) != 0)
>> -               return 1;
>> -
>> -       return 0;
>> +       return (interface->capability & cap) != 0;
>>  }
> 
> Thanks, as Joe mentioned even != 0 part is not needed (followed by
> unneeded parens), though I would let it be (one line is good enough to
> me) if there will be no strong preferences.
> 

Oh, yeah. I like it better what Joe suggested.

Let me send v2, shortly.

Thanks
--
Gustavo