* [PATCH] ASoC: rt5677: Remove bogus device id from rt5677_of_match
@ 2018-08-07 16:22 Matthias Kaehlcke
2018-08-07 16:39 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Matthias Kaehlcke @ 2018-08-07 16:22 UTC (permalink / raw)
To: Bard Liao, Oder Chiou, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai
Cc: alsa-devel, linux-kernel, Guenter Roeck, Nicolas Boichat,
Matthias Kaehlcke
The initializer of rt5677_of_match contains a bogus device id
(enum type) for the 'type' field (char []). Remove it.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
sound/soc/codecs/rt5677.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index 8a0181a2db08..7dab53b35cbf 100644
--- a/sound/soc/codecs/rt5677.c
+++ b/sound/soc/codecs/rt5677.c
@@ -5007,7 +5007,7 @@ static const struct regmap_config rt5677_regmap = {
};
static const struct of_device_id rt5677_of_match[] = {
- { .compatible = "realtek,rt5677", RT5677 },
+ { .compatible = "realtek,rt5677", },
{ }
};
MODULE_DEVICE_TABLE(of, rt5677_of_match);
--
2.18.0.597.ga71716f1ad-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: rt5677: Remove bogus device id from rt5677_of_match
2018-08-07 16:22 [PATCH] ASoC: rt5677: Remove bogus device id from rt5677_of_match Matthias Kaehlcke
@ 2018-08-07 16:39 ` Guenter Roeck
2018-08-07 16:55 ` Matthias Kaehlcke
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2018-08-07 16:39 UTC (permalink / raw)
To: Matthias Kaehlcke
Cc: bardliao, oder_chiou, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, alsa-devel, linux-kernel, Guenter Roeck,
Nicolas Boichat
On Tue, Aug 7, 2018 at 9:22 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> The initializer of rt5677_of_match contains a bogus device id
> (enum type) for the 'type' field (char []). Remove it.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> ---
> sound/soc/codecs/rt5677.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
> index 8a0181a2db08..7dab53b35cbf 100644
> --- a/sound/soc/codecs/rt5677.c
> +++ b/sound/soc/codecs/rt5677.c
> @@ -5007,7 +5007,7 @@ static const struct regmap_config rt5677_regmap = {
> };
>
> static const struct of_device_id rt5677_of_match[] = {
> - { .compatible = "realtek,rt5677", RT5677 },
> + { .compatible = "realtek,rt5677", },
Is that indeed not used, or should it be the following ?
... , .data = RT5677 },
Thanks,
Guenter
> { }
> };
> MODULE_DEVICE_TABLE(of, rt5677_of_match);
> --
> 2.18.0.597.ga71716f1ad-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: rt5677: Remove bogus device id from rt5677_of_match
2018-08-07 16:39 ` Guenter Roeck
@ 2018-08-07 16:55 ` Matthias Kaehlcke
0 siblings, 0 replies; 3+ messages in thread
From: Matthias Kaehlcke @ 2018-08-07 16:55 UTC (permalink / raw)
To: Guenter Roeck
Cc: bardliao, oder_chiou, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, alsa-devel, linux-kernel, Guenter Roeck,
Nicolas Boichat
On Tue, Aug 07, 2018 at 09:39:38AM -0700, Guenter Roeck wrote:
> On Tue, Aug 7, 2018 at 9:22 AM Matthias Kaehlcke <mka@chromium.org> wrote:
> >
> > The initializer of rt5677_of_match contains a bogus device id
> > (enum type) for the 'type' field (char []). Remove it.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> > sound/soc/codecs/rt5677.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
> > index 8a0181a2db08..7dab53b35cbf 100644
> > --- a/sound/soc/codecs/rt5677.c
> > +++ b/sound/soc/codecs/rt5677.c
> > @@ -5007,7 +5007,7 @@ static const struct regmap_config rt5677_regmap = {
> > };
> >
> > static const struct of_device_id rt5677_of_match[] = {
> > - { .compatible = "realtek,rt5677", RT5677 },
> > + { .compatible = "realtek,rt5677", },
>
> Is that indeed not used, or should it be the following ?
> ... , .data = RT5677 },
You are right, I missed that the driver uses of_device_id->data, will
update.
Thanks!
Matthias
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-07 16:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-07 16:22 [PATCH] ASoC: rt5677: Remove bogus device id from rt5677_of_match Matthias Kaehlcke
2018-08-07 16:39 ` Guenter Roeck
2018-08-07 16:55 ` Matthias Kaehlcke
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.