* [PATCH] dma/direct: Use true and false for boolean values
@ 2018-08-08 0:07 ` Gustavo A. R. Silva
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-08 0:07 UTC (permalink / raw)
To: linux-arm-kernel
Return statements in functions returning bool should use true or false
instead of an integer value.
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
arch/arm/include/asm/dma-direct.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/include/asm/dma-direct.h b/arch/arm/include/asm/dma-direct.h
index b67e5fc..906fdcf 100644
--- a/arch/arm/include/asm/dma-direct.h
+++ b/arch/arm/include/asm/dma-direct.h
@@ -19,18 +19,18 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size)
u64 limit, mask;
if (!dev->dma_mask)
- return 0;
+ return false;
mask = *dev->dma_mask;
limit = (mask + 1) & ~mask;
if (limit && size > limit)
- return 0;
+ return false;
if ((addr | (addr + size - 1)) & ~mask)
- return 0;
+ return false;
- return 1;
+ return true;
}
#endif /* ASM_ARM_DMA_DIRECT_H */
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] dma/direct: Use true and false for boolean values
@ 2018-08-08 0:07 ` Gustavo A. R. Silva
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-08 0:07 UTC (permalink / raw)
To: Russell King; +Cc: linux-arm-kernel, linux-kernel, Gustavo A. R. Silva
Return statements in functions returning bool should use true or false
instead of an integer value.
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
arch/arm/include/asm/dma-direct.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/include/asm/dma-direct.h b/arch/arm/include/asm/dma-direct.h
index b67e5fc..906fdcf 100644
--- a/arch/arm/include/asm/dma-direct.h
+++ b/arch/arm/include/asm/dma-direct.h
@@ -19,18 +19,18 @@ static inline bool dma_capable(struct device *dev, dma_addr_t addr, size_t size)
u64 limit, mask;
if (!dev->dma_mask)
- return 0;
+ return false;
mask = *dev->dma_mask;
limit = (mask + 1) & ~mask;
if (limit && size > limit)
- return 0;
+ return false;
if ((addr | (addr + size - 1)) & ~mask)
- return 0;
+ return false;
- return 1;
+ return true;
}
#endif /* ASM_ARM_DMA_DIRECT_H */
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-08 0:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-08 0:07 [PATCH] dma/direct: Use true and false for boolean values Gustavo A. R. Silva
2018-08-08 0:07 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.