All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: stratix10: i2c clock running out of spec
@ 2018-08-08 15:42 ` Alan Tull
  0 siblings, 0 replies; 5+ messages in thread
From: Alan Tull @ 2018-08-08 15:42 UTC (permalink / raw)
  To: linux-arm-kernel

DesignWare I2C controller was observed running at 105.93kHz rather
than the specified 100kHz.  Adjust device tree settings to bring it
within spec (a slightly conservative 98 MHz).

Signed-off-by: Alan Tull <atull@kernel.org>
---
 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
index 6edc4fa..53cf195 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
@@ -124,6 +124,8 @@
 &i2c1 {
 	status = "okay";
 	clock-frequency = <100000>;
+	i2c-sda-falling-time-ns = <890>;  /* hcnt */
+	i2c-sdl-falling-time-ns = <890>;  /* lcnt */
 
 	adc at 14 {
 		compatible = "lltc,ltc2497";
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] arm64: dts: stratix10: i2c clock running out of spec
@ 2018-08-08 15:42 ` Alan Tull
  0 siblings, 0 replies; 5+ messages in thread
From: Alan Tull @ 2018-08-08 15:42 UTC (permalink / raw)
  To: Dinh Nguyen, Rob Herring, Mark Rutland, Catalin Marinas,
	Will Deacon
  Cc: Alan Tull, devicetree, linux-arm-kernel, linux-kernel

DesignWare I2C controller was observed running at 105.93kHz rather
than the specified 100kHz.  Adjust device tree settings to bring it
within spec (a slightly conservative 98 MHz).

Signed-off-by: Alan Tull <atull@kernel.org>
---
 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
index 6edc4fa..53cf195 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
@@ -124,6 +124,8 @@
 &i2c1 {
 	status = "okay";
 	clock-frequency = <100000>;
+	i2c-sda-falling-time-ns = <890>;  /* hcnt */
+	i2c-sdl-falling-time-ns = <890>;  /* lcnt */
 
 	adc@14 {
 		compatible = "lltc,ltc2497";
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH] arm64: dts: stratix10: i2c clock running out of spec
  2018-08-08 15:42 ` Alan Tull
  (?)
@ 2018-08-15 15:08   ` Dinh Nguyen
  -1 siblings, 0 replies; 5+ messages in thread
From: Dinh Nguyen @ 2018-08-15 15:08 UTC (permalink / raw)
  To: linux-arm-kernel



On 08/08/2018 10:42 AM, Alan Tull wrote:
> DesignWare I2C controller was observed running at 105.93kHz rather
> than the specified 100kHz.  Adjust device tree settings to bring it
> within spec (a slightly conservative 98 MHz).
> 
> Signed-off-by: Alan Tull <atull@kernel.org>
> ---
>  arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> index 6edc4fa..53cf195 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> @@ -124,6 +124,8 @@
>  &i2c1 {
>  	status = "okay";
>  	clock-frequency = <100000>;
> +	i2c-sda-falling-time-ns = <890>;  /* hcnt */
> +	i2c-sdl-falling-time-ns = <890>;  /* lcnt */
>  
>  	adc at 14 {
>  		compatible = "lltc,ltc2497";
> 

Applied!

Thanks,
Dinh

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: stratix10: i2c clock running out of spec
@ 2018-08-15 15:08   ` Dinh Nguyen
  0 siblings, 0 replies; 5+ messages in thread
From: Dinh Nguyen @ 2018-08-15 15:08 UTC (permalink / raw)
  To: Alan Tull, Rob Herring, Mark Rutland, Catalin Marinas,
	Will Deacon
  Cc: devicetree, linux-kernel, linux-arm-kernel



On 08/08/2018 10:42 AM, Alan Tull wrote:
> DesignWare I2C controller was observed running at 105.93kHz rather
> than the specified 100kHz.  Adjust device tree settings to bring it
> within spec (a slightly conservative 98 MHz).
> 
> Signed-off-by: Alan Tull <atull@kernel.org>
> ---
>  arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> index 6edc4fa..53cf195 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> @@ -124,6 +124,8 @@
>  &i2c1 {
>  	status = "okay";
>  	clock-frequency = <100000>;
> +	i2c-sda-falling-time-ns = <890>;  /* hcnt */
> +	i2c-sdl-falling-time-ns = <890>;  /* lcnt */
>  
>  	adc@14 {
>  		compatible = "lltc,ltc2497";
> 

Applied!

Thanks,
Dinh

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: stratix10: i2c clock running out of spec
@ 2018-08-15 15:08   ` Dinh Nguyen
  0 siblings, 0 replies; 5+ messages in thread
From: Dinh Nguyen @ 2018-08-15 15:08 UTC (permalink / raw)
  To: Alan Tull, Rob Herring, Mark Rutland, Catalin Marinas,
	Will Deacon
  Cc: devicetree, linux-arm-kernel, linux-kernel



On 08/08/2018 10:42 AM, Alan Tull wrote:
> DesignWare I2C controller was observed running at 105.93kHz rather
> than the specified 100kHz.  Adjust device tree settings to bring it
> within spec (a slightly conservative 98 MHz).
> 
> Signed-off-by: Alan Tull <atull@kernel.org>
> ---
>  arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> index 6edc4fa..53cf195 100644
> --- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> +++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
> @@ -124,6 +124,8 @@
>  &i2c1 {
>  	status = "okay";
>  	clock-frequency = <100000>;
> +	i2c-sda-falling-time-ns = <890>;  /* hcnt */
> +	i2c-sdl-falling-time-ns = <890>;  /* lcnt */
>  
>  	adc@14 {
>  		compatible = "lltc,ltc2497";
> 

Applied!

Thanks,
Dinh

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-15 15:09 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-08 15:42 [PATCH] arm64: dts: stratix10: i2c clock running out of spec Alan Tull
2018-08-08 15:42 ` Alan Tull
2018-08-15 15:08 ` Dinh Nguyen
2018-08-15 15:08   ` Dinh Nguyen
2018-08-15 15:08   ` Dinh Nguyen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.