* [PATCH] firmware: qcom: scm: Add sdm660 soc compatible
@ 2018-08-11 16:24 ` Craig Tatlor
0 siblings, 0 replies; 7+ messages in thread
From: Craig Tatlor @ 2018-08-11 16:24 UTC (permalink / raw)
Cc: ctatlor97, linux-arm-msm, Rob Herring, Mark Rutland, Andy Gross,
David Brown, Bjorn Andersson, Sricharan R, Stephen Boyd,
devicetree, linux-kernel, linux-soc
Add the compatible for SDM660.
This does not need clocks to do scm calls
Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
---
Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 +
drivers/firmware/qcom_scm.c | 3 +++
2 files changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
index fcf6979c0b6d..499608fcc864 100644
--- a/Documentation/devicetree/bindings/firmware/qcom,scm.txt
+++ b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
@@ -11,6 +11,7 @@ Required properties:
* "qcom,scm-msm8660" for MSM8660 platforms
* "qcom,scm-msm8690" for MSM8690 platforms
* "qcom,scm-msm8996" for MSM8996 platforms
+ * "qcom,scm-sdm660" for SDM660 platforms
* "qcom,scm-ipq4019" for IPQ4019 platforms
* "qcom,scm" for later processors (MSM8916, APQ8084, MSM8974, etc)
- clocks: One to three clocks may be required based on compatible.
diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
index e778af766fae..ee113ceb5d41 100644
--- a/drivers/firmware/qcom_scm.c
+++ b/drivers/firmware/qcom_scm.c
@@ -603,6 +603,9 @@ static const struct of_device_id qcom_scm_dt_match[] = {
{ .compatible = "qcom,scm-msm8996",
.data = NULL, /* no clocks */
},
+ { .compatible = "qcom,scm-sdm660",
+ .data = NULL, /* no clocks */
+ },
{ .compatible = "qcom,scm-ipq4019",
.data = NULL, /* no clocks */
},
--
2.18.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] firmware: qcom: scm: Add sdm660 soc compatible
2018-08-11 16:24 ` Craig Tatlor
@ 2018-08-14 20:57 ` Rob Herring
-1 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2018-08-14 20:57 UTC (permalink / raw)
Cc: ctatlor97, linux-arm-msm, Mark Rutland, Andy Gross, David Brown,
Bjorn Andersson, Sricharan R, Stephen Boyd, devicetree,
linux-kernel, linux-soc
On Sat, 11 Aug 2018 17:24:50 +0100, Craig Tatlor wrote:
> Add the compatible for SDM660.
> This does not need clocks to do scm calls
>
> Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
> ---
> Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 +
> drivers/firmware/qcom_scm.c | 3 +++
> 2 files changed, 4 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] firmware: qcom: scm: Add sdm660 soc compatible
@ 2018-08-14 20:57 ` Rob Herring
0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2018-08-14 20:57 UTC (permalink / raw)
To: Craig Tatlor
Cc: ctatlor97, linux-arm-msm, Mark Rutland, Andy Gross, David Brown,
Bjorn Andersson, Sricharan R, Stephen Boyd, devicetree,
linux-kernel, linux-soc
On Sat, 11 Aug 2018 17:24:50 +0100, Craig Tatlor wrote:
> Add the compatible for SDM660.
> This does not need clocks to do scm calls
>
> Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
> ---
> Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 +
> drivers/firmware/qcom_scm.c | 3 +++
> 2 files changed, 4 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] firmware: qcom: scm: Add sdm660 soc compatible
2018-08-11 16:24 ` Craig Tatlor
@ 2018-08-15 20:31 ` Stephen Boyd
-1 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2018-08-15 20:31 UTC (permalink / raw)
Cc: ctatlor97, linux-arm-msm, Rob Herring, Mark Rutland, Andy Gross,
David Brown, Bjorn Andersson, Sricharan R, Stephen Boyd,
devicetree, linux-kernel, linux-soc
Quoting Craig Tatlor (2018-08-11 09:24:50)
> Add the compatible for SDM660.
> This does not need clocks to do scm calls
>
> Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
> ---
> Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 +
> drivers/firmware/qcom_scm.c | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> index fcf6979c0b6d..499608fcc864 100644
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> @@ -11,6 +11,7 @@ Required properties:
> * "qcom,scm-msm8660" for MSM8660 platforms
> * "qcom,scm-msm8690" for MSM8690 platforms
> * "qcom,scm-msm8996" for MSM8996 platforms
> + * "qcom,scm-sdm660" for SDM660 platforms
> * "qcom,scm-ipq4019" for IPQ4019 platforms
> * "qcom,scm" for later processors (MSM8916, APQ8084, MSM8974, etc)
> - clocks: One to three clocks may be required based on compatible.
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index e778af766fae..ee113ceb5d41 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -603,6 +603,9 @@ static const struct of_device_id qcom_scm_dt_match[] = {
> { .compatible = "qcom,scm-msm8996",
> .data = NULL, /* no clocks */
> },
> + { .compatible = "qcom,scm-sdm660",
> + .data = NULL, /* no clocks */
> + },
Do you need to update the driver? It looks like the scm driver should be
changed to just try and get all the clks it can and treat them as
optional clks, i.e. don't fail if they aren't actually listed in DT.
Then we can just have one qcom,scm compatible string in this driver but
we're free to add different compatibles to the binding for all the
different SoCs out there.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] firmware: qcom: scm: Add sdm660 soc compatible
@ 2018-08-15 20:31 ` Stephen Boyd
0 siblings, 0 replies; 7+ messages in thread
From: Stephen Boyd @ 2018-08-15 20:31 UTC (permalink / raw)
To: Craig Tatlor
Cc: ctatlor97, linux-arm-msm, Rob Herring, Mark Rutland, Andy Gross,
David Brown, Bjorn Andersson, Sricharan R, Stephen Boyd,
devicetree, linux-kernel, linux-soc
Quoting Craig Tatlor (2018-08-11 09:24:50)
> Add the compatible for SDM660.
> This does not need clocks to do scm calls
>
> Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
> ---
> Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 +
> drivers/firmware/qcom_scm.c | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> index fcf6979c0b6d..499608fcc864 100644
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> @@ -11,6 +11,7 @@ Required properties:
> * "qcom,scm-msm8660" for MSM8660 platforms
> * "qcom,scm-msm8690" for MSM8690 platforms
> * "qcom,scm-msm8996" for MSM8996 platforms
> + * "qcom,scm-sdm660" for SDM660 platforms
> * "qcom,scm-ipq4019" for IPQ4019 platforms
> * "qcom,scm" for later processors (MSM8916, APQ8084, MSM8974, etc)
> - clocks: One to three clocks may be required based on compatible.
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index e778af766fae..ee113ceb5d41 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -603,6 +603,9 @@ static const struct of_device_id qcom_scm_dt_match[] = {
> { .compatible = "qcom,scm-msm8996",
> .data = NULL, /* no clocks */
> },
> + { .compatible = "qcom,scm-sdm660",
> + .data = NULL, /* no clocks */
> + },
Do you need to update the driver? It looks like the scm driver should be
changed to just try and get all the clks it can and treat them as
optional clks, i.e. don't fail if they aren't actually listed in DT.
Then we can just have one qcom,scm compatible string in this driver but
we're free to add different compatibles to the binding for all the
different SoCs out there.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] firmware: qcom: scm: Add sdm660 soc compatible
2018-08-11 16:24 ` Craig Tatlor
` (2 preceding siblings ...)
(?)
@ 2018-09-24 17:43 ` Bjorn Andersson
-1 siblings, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2018-09-24 17:43 UTC (permalink / raw)
To: Craig Tatlor
Cc: linux-arm-msm, Rob Herring, Mark Rutland, Andy Gross, David Brown,
Sricharan R, Stephen Boyd, devicetree, linux-kernel, linux-soc
On Sat 11 Aug 09:24 PDT 2018, Craig Tatlor wrote:
> Add the compatible for SDM660.
> This does not need clocks to do scm calls
>
> Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
Andy picked my clock-rework patch for the scm driver, so we can now do:
compatible = "qcom,scm-sdm660", "qcom,scm";
and get the desired result.
Please respin your patch without the code update.
Regards,
Bjorn
> ---
> Documentation/devicetree/bindings/firmware/qcom,scm.txt | 1 +
> drivers/firmware/qcom_scm.c | 3 +++
> 2 files changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.txt b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> index fcf6979c0b6d..499608fcc864 100644
> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.txt
> @@ -11,6 +11,7 @@ Required properties:
> * "qcom,scm-msm8660" for MSM8660 platforms
> * "qcom,scm-msm8690" for MSM8690 platforms
> * "qcom,scm-msm8996" for MSM8996 platforms
> + * "qcom,scm-sdm660" for SDM660 platforms
> * "qcom,scm-ipq4019" for IPQ4019 platforms
> * "qcom,scm" for later processors (MSM8916, APQ8084, MSM8974, etc)
> - clocks: One to three clocks may be required based on compatible.
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index e778af766fae..ee113ceb5d41 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -603,6 +603,9 @@ static const struct of_device_id qcom_scm_dt_match[] = {
> { .compatible = "qcom,scm-msm8996",
> .data = NULL, /* no clocks */
> },
> + { .compatible = "qcom,scm-sdm660",
> + .data = NULL, /* no clocks */
> + },
> { .compatible = "qcom,scm-ipq4019",
> .data = NULL, /* no clocks */
> },
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 7+ messages in thread