* [PATCH] staging: erofs: change 'unsigned' to 'unsigned int'
@ 2018-08-13 15:20 Leon Imhof
2018-08-13 16:01 ` Gao Xiang
2018-08-16 7:18 ` Chao Yu
0 siblings, 2 replies; 3+ messages in thread
From: Leon Imhof @ 2018-08-13 15:20 UTC (permalink / raw)
Fix coding style issue "Prefer 'unsigned int' to bare use of 'unsigned'"
detected by checkpatch.pl
Signed-off-by: Leon Imhof <leon.imhof at in.tum.de>
---
drivers/staging/erofs/data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/erofs/data.c b/drivers/staging/erofs/data.c
index ac263a180253..2a401216007a 100644
--- a/drivers/staging/erofs/data.c
+++ b/drivers/staging/erofs/data.c
@@ -337,7 +337,7 @@ static int erofs_raw_access_readpage(struct file *file, struct page *page)
static int erofs_raw_access_readpages(struct file *filp,
struct address_space *mapping,
- struct list_head *pages, unsigned nr_pages)
+ struct list_head *pages, unsigned int nr_pages)
{
erofs_off_t last_block;
struct bio *bio = NULL;
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] staging: erofs: change 'unsigned' to 'unsigned int'
2018-08-13 15:20 [PATCH] staging: erofs: change 'unsigned' to 'unsigned int' Leon Imhof
@ 2018-08-13 16:01 ` Gao Xiang
2018-08-16 7:18 ` Chao Yu
1 sibling, 0 replies; 3+ messages in thread
From: Gao Xiang @ 2018-08-13 16:01 UTC (permalink / raw)
Hi Leon,
On 2018/8/13 23:20, Leon Imhof wrote:
> Fix coding style issue "Prefer 'unsigned int' to bare use of 'unsigned'"
> detected by checkpatch.pl
>
> Signed-off-by: Leon Imhof <leon.imhof at in.tum.de>
> ---
Thanks for the patch, could be better if use `[PATCH v2]' to indicate
that you send a new version of `[PATCH] staging: erofs: add int to usigned'.
Reviewed-by: Gao Xiang <gaoxiang25 at huawei.com>
Thanks,
Gao Xiang
> drivers/staging/erofs/data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/erofs/data.c b/drivers/staging/erofs/data.c
> index ac263a180253..2a401216007a 100644
> --- a/drivers/staging/erofs/data.c
> +++ b/drivers/staging/erofs/data.c
> @@ -337,7 +337,7 @@ static int erofs_raw_access_readpage(struct file *file, struct page *page)
>
> static int erofs_raw_access_readpages(struct file *filp,
> struct address_space *mapping,
> - struct list_head *pages, unsigned nr_pages)
> + struct list_head *pages, unsigned int nr_pages)
> {
> erofs_off_t last_block;
> struct bio *bio = NULL;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] staging: erofs: change 'unsigned' to 'unsigned int'
2018-08-13 15:20 [PATCH] staging: erofs: change 'unsigned' to 'unsigned int' Leon Imhof
2018-08-13 16:01 ` Gao Xiang
@ 2018-08-16 7:18 ` Chao Yu
1 sibling, 0 replies; 3+ messages in thread
From: Chao Yu @ 2018-08-16 7:18 UTC (permalink / raw)
On 2018/8/13 23:20, Leon Imhof wrote:
> Fix coding style issue "Prefer 'unsigned int' to bare use of 'unsigned'"
> detected by checkpatch.pl
>
> Signed-off-by: Leon Imhof <leon.imhof at in.tum.de>
Reviewed-by: Chao Yu <yuchao0 at huawei.com>
> ---
It would be better to indicate this patch is v2 one here and in subject-prefix.
Thanks,
> drivers/staging/erofs/data.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/erofs/data.c b/drivers/staging/erofs/data.c
> index ac263a180253..2a401216007a 100644
> --- a/drivers/staging/erofs/data.c
> +++ b/drivers/staging/erofs/data.c
> @@ -337,7 +337,7 @@ static int erofs_raw_access_readpage(struct file *file, struct page *page)
>
> static int erofs_raw_access_readpages(struct file *filp,
> struct address_space *mapping,
> - struct list_head *pages, unsigned nr_pages)
> + struct list_head *pages, unsigned int nr_pages)
> {
> erofs_off_t last_block;
> struct bio *bio = NULL;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-16 7:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-13 15:20 [PATCH] staging: erofs: change 'unsigned' to 'unsigned int' Leon Imhof
2018-08-13 16:01 ` Gao Xiang
2018-08-16 7:18 ` Chao Yu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.