From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: flihp@twobit.us, jgg@ziepe.ca, linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/2] tpm: add ptr to the tpm_space struct to file_priv
Date: Tue, 14 Aug 2018 19:06:05 +0300 [thread overview]
Message-ID: <20180814160605.GC13648@linux.intel.com> (raw)
In-Reply-To: <153419237378.8189.17192381683473461307.stgit@tstruk-mobl1.jf.intel.com>
On Mon, Aug 13, 2018 at 01:32:53PM -0700, Tadeusz Struk wrote:
> Add a ptr to struct tpm_space to the file_priv to have an easy
> access to it in the async job without the need to allocate memory.
> This also allows to consolidate of the write operations for
> the two interfaces.
>
> Tested-by: Philip Tricca <philip.b.tricca@intel.com>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
NAK
A rule thumb: do not add "links" between commits unless it is you cannot
find any other way. The cover letter is made for describing feature or
features that are defined a the set of commits.
What is "async job" anyway? It is a bogus term.
Please refer to only merged code in your commit message, not futures.
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v5 1/2] tpm: add ptr to the tpm_space struct to file_priv
Date: Tue, 14 Aug 2018 19:06:05 +0300 [thread overview]
Message-ID: <20180814160605.GC13648@linux.intel.com> (raw)
In-Reply-To: <153419237378.8189.17192381683473461307.stgit@tstruk-mobl1.jf.intel.com>
On Mon, Aug 13, 2018 at 01:32:53PM -0700, Tadeusz Struk wrote:
> Add a ptr to struct tpm_space to the file_priv to have an easy
> access to it in the async job without the need to allocate memory.
> This also allows to consolidate of the write operations for
> the two interfaces.
>
> Tested-by: Philip Tricca <philip.b.tricca@intel.com>
> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com>
NAK
A rule thumb: do not add "links" between commits unless it is you cannot
find any other way. The cover letter is made for describing feature or
features that are defined a the set of commits.
What is "async job" anyway? It is a bogus term.
Please refer to only merged code in your commit message, not futures.
/Jarkko
next prev parent reply other threads:[~2018-08-14 18:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 20:32 [PATCH v5 0/2] tpm: add support for nonblocking operation Tadeusz Struk
2018-08-13 20:32 ` Tadeusz Struk
2018-08-13 20:32 ` [PATCH v5 1/2] tpm: add ptr to the tpm_space struct to file_priv Tadeusz Struk
2018-08-13 20:32 ` Tadeusz Struk
2018-08-14 16:06 ` Jarkko Sakkinen [this message]
2018-08-14 16:06 ` Jarkko Sakkinen
2018-08-14 16:07 ` Jarkko Sakkinen
2018-08-14 16:07 ` Jarkko Sakkinen
2018-08-13 20:32 ` [PATCH v5 2/2] tpm: add support for nonblocking operation Tadeusz Struk
2018-08-13 20:32 ` Tadeusz Struk
2018-08-31 9:02 ` Jarkko Sakkinen
2018-08-31 9:02 ` Jarkko Sakkinen
2018-08-31 8:57 ` [PATCH v5 0/2] " Jarkko Sakkinen
2018-08-31 8:57 ` Jarkko Sakkinen
2018-08-31 8:58 ` Jarkko Sakkinen
2018-08-31 8:58 ` Jarkko Sakkinen
2018-09-10 17:23 ` Tadeusz Struk
2018-09-10 17:23 ` Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180814160605.GC13648@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=flihp@twobit.us \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.