[Buildroot] [PATCH 1/1] package/pkg-golang: fix illegal variable reference

[Buildroot] [PATCH 1/1] package/pkg-golang: fix illegal variable reference

[Mirza Krak]

References to variables inside $(eval) blocks must be with a double
dollar sign, otherwise we end up with unintuitive and undesired behavior
according to the description in pkg-generic.mk

Signed-off-by: Mirza Krak <mirza.krak@northern.tech>
---
 package/pkg-golang.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/pkg-golang.mk b/package/pkg-golang.mk
index bf178622b5..6eacd14180 100644
--- a/package/pkg-golang.mk
+++ b/package/pkg-golang.mk
@@ -77,9 +77,9 @@ $(2)_INSTALL_BINS ?= $(1)
 # of GOPATH. It usually resolves around domain/vendor/software. By default, we
 # derive domain/vendor/software from the upstream URL of the project, but we
 # allow $(2)_SRC_SUBDIR to be overridden if needed.
-$(2)_SRC_DOMAIN = $$(call domain,$($(2)_SITE))
-$(2)_SRC_VENDOR = $$(word 1,$$(subst /, ,$$(call notdomain,$($(2)_SITE))))
-$(2)_SRC_SOFTWARE = $$(word 2,$$(subst /, ,$$(call notdomain,$($(2)_SITE))))
+$(2)_SRC_DOMAIN = $$(call domain,$$($(2)_SITE))
+$(2)_SRC_VENDOR = $$(word 1,$$(subst /, ,$$(call notdomain,$$($(2)_SITE))))
+$(2)_SRC_SOFTWARE = $$(word 2,$$(subst /, ,$$(call notdomain,$$($(2)_SITE))))
 
 $(2)_SRC_SUBDIR ?= $$($(2)_SRC_DOMAIN)/$$($(2)_SRC_VENDOR)/$$($(2)_SRC_SOFTWARE)
 $(2)_SRC_PATH = $$(@D)/$$($(2)_WORKSPACE)/src/$$($(2)_SRC_SUBDIR)
-- 
2.18.0

[Buildroot] [PATCH 1/1] package/pkg-golang: fix illegal variable reference

[Thomas Petazzoni]

Hello,

On Wed, 15 Aug 2018 09:16:09 +0200, Mirza Krak wrote:
> References to variables inside $(eval) blocks must be with a double
> dollar sign, otherwise we end up with unintuitive and undesired behavior
> according to the description in pkg-generic.mk
> 
> Signed-off-by: Mirza Krak <mirza.krak@northern.tech>
> ---
>  package/pkg-golang.mk | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

I hesitated a bit between applying to master or next. It is a bug fix,
so it should be master. But it doesn't cause any visible issue for now,
so maybe not master. In the end, since the fix is pretty trivial, I
applied to master.

However, I rewrote the commit log to provide (I believe) a better
explanation of the issue being fixed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/pkg-golang: fix illegal variable reference

[Mirza Krak]

On Wed, Aug 15, 2018 at 2:36 PM, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
> Hello,
>
> On Wed, 15 Aug 2018 09:16:09 +0200, Mirza Krak wrote:
>> References to variables inside $(eval) blocks must be with a double
>> dollar sign, otherwise we end up with unintuitive and undesired behavior
>> according to the description in pkg-generic.mk
>>
>> Signed-off-by: Mirza Krak <mirza.krak@northern.tech>
>> ---
>>  package/pkg-golang.mk | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> I hesitated a bit between applying to master or next. It is a bug fix,
> so it should be master. But it doesn't cause any visible issue for now,
> so maybe not master. In the end, since the fix is pretty trivial, I
> applied to master.
>
> However, I rewrote the commit log to provide (I believe) a better
> explanation of the issue being fixed.

Much better :). Thanks!

-- 
Mirza Krak | Embedded Solutions Architect | https://mender.io

 Northern.tech AS | @northerntechHQ