* [PATCH] futex: Mark expected switch fall-throughs
@ 2018-08-16 17:21 Gustavo A. R. Silva
2018-08-20 16:27 ` [tip:locking/urgent] " tip-bot for Gustavo A. R. Silva
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-16 17:21 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, Peter Zijlstra, Darren Hart
Cc: linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
kernel/futex.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/futex.c b/kernel/futex.c
index 1f450e0..11fc3bb 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -3523,10 +3523,12 @@ long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout,
switch (cmd) {
case FUTEX_WAIT:
val3 = FUTEX_BITSET_MATCH_ANY;
+ /* fall through */
case FUTEX_WAIT_BITSET:
return futex_wait(uaddr, flags, val, timeout, val3);
case FUTEX_WAKE:
val3 = FUTEX_BITSET_MATCH_ANY;
+ /* fall through */
case FUTEX_WAKE_BITSET:
return futex_wake(uaddr, flags, val, val3);
case FUTEX_REQUEUE:
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* [tip:locking/urgent] futex: Mark expected switch fall-throughs
2018-08-16 17:21 [PATCH] futex: Mark expected switch fall-throughs Gustavo A. R. Silva
@ 2018-08-20 16:27 ` tip-bot for Gustavo A. R. Silva
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Gustavo A. R. Silva @ 2018-08-20 16:27 UTC (permalink / raw)
To: linux-tip-commits; +Cc: linux-kernel, mingo, gustavo, dvhart, hpa, tglx, peterz
Commit-ID: b639186ffe9168fd1d2f95a1fff8571720739126
Gitweb: https://git.kernel.org/tip/b639186ffe9168fd1d2f95a1fff8571720739126
Author: Gustavo A. R. Silva <gustavo@embeddedor.com>
AuthorDate: Thu, 16 Aug 2018 12:21:24 -0500
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 20 Aug 2018 18:23:00 +0200
futex: Mark expected switch fall-throughs
In preparation of enabling -Wimplicit-fallthrough, mark switch cases which
fall through.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Darren Hart <dvhart@infradead.org>
Link: https://lkml.kernel.org/r/20180816172124.GA2407@embeddedor.com
---
kernel/futex.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/futex.c b/kernel/futex.c
index 1f450e092c74..11fc3bb456d6 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -3523,10 +3523,12 @@ long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout,
switch (cmd) {
case FUTEX_WAIT:
val3 = FUTEX_BITSET_MATCH_ANY;
+ /* fall through */
case FUTEX_WAIT_BITSET:
return futex_wait(uaddr, flags, val, timeout, val3);
case FUTEX_WAKE:
val3 = FUTEX_BITSET_MATCH_ANY;
+ /* fall through */
case FUTEX_WAKE_BITSET:
return futex_wake(uaddr, flags, val, val3);
case FUTEX_REQUEUE:
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-20 16:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-16 17:21 [PATCH] futex: Mark expected switch fall-throughs Gustavo A. R. Silva
2018-08-20 16:27 ` [tip:locking/urgent] " tip-bot for Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.