All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] fpga: small fixes for 4.19
@ 2018-08-16 19:42 Alan Tull
  2018-08-16 19:42 ` [PATCH 1/2] fpga: dfl: fme: fix return value check in in pr_mgmt_init() Alan Tull
  2018-08-16 19:42 ` [PATCH 2/2] drivers: fpga: fix two trivial spelling mistakes Alan Tull
  0 siblings, 2 replies; 3+ messages in thread
From: Alan Tull @ 2018-08-16 19:42 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Moritz Fischer, Alan Tull, linux-kernel, linux-fpga

Hi Greg,

Please take these two small fixes for FPGA.  They've been
reviewed on the mailing lists.  They apply cleanly on
linux-next/master.

Thanks,
Alan

Colin Ian King (1):
  drivers: fpga: fix two trivial spelling mistakes

Wei Yongjun (1):
  fpga: dfl: fme: fix return value check in in pr_mgmt_init()

 drivers/fpga/dfl-afu-dma-region.c | 2 +-
 drivers/fpga/dfl-fme-mgr.c        | 2 +-
 drivers/fpga/dfl-fme-pr.c         | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] fpga: dfl: fme: fix return value check in in pr_mgmt_init()
  2018-08-16 19:42 [PATCH 0/2] fpga: small fixes for 4.19 Alan Tull
@ 2018-08-16 19:42 ` Alan Tull
  2018-08-16 19:42 ` [PATCH 2/2] drivers: fpga: fix two trivial spelling mistakes Alan Tull
  1 sibling, 0 replies; 3+ messages in thread
From: Alan Tull @ 2018-08-16 19:42 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Moritz Fischer, Alan Tull, linux-kernel, linux-fpga, Wei Yongjun

From: Wei Yongjun <weiyongjun1@huawei.com>

In case of error, the function dfl_fme_create_region() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature support")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Moritz Fischer <mdf@kernel.org>
Acked-by: Alan Tull <atull@kernel.org>
---
 drivers/fpga/dfl-fme-pr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c
index fc9fd2d..0b84053 100644
--- a/drivers/fpga/dfl-fme-pr.c
+++ b/drivers/fpga/dfl-fme-pr.c
@@ -420,7 +420,7 @@ static int pr_mgmt_init(struct platform_device *pdev,
 		/* Create region for each port */
 		fme_region = dfl_fme_create_region(pdata, mgr,
 						   fme_br->br, i);
-		if (!fme_region) {
+		if (IS_ERR(fme_region)) {
 			ret = PTR_ERR(fme_region);
 			goto destroy_region;
 		}
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] drivers: fpga: fix two trivial spelling mistakes
  2018-08-16 19:42 [PATCH 0/2] fpga: small fixes for 4.19 Alan Tull
  2018-08-16 19:42 ` [PATCH 1/2] fpga: dfl: fme: fix return value check in in pr_mgmt_init() Alan Tull
@ 2018-08-16 19:42 ` Alan Tull
  1 sibling, 0 replies; 3+ messages in thread
From: Alan Tull @ 2018-08-16 19:42 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Moritz Fischer, Alan Tull, linux-kernel, linux-fpga,
	Colin Ian King

From: Colin Ian King <colin.king@canonical.com>

Trivial fix to two spelling mistakes
"execeeded" -> "exceeded"
"Invaild" -> "Invalid"

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Alan Tull <atull@kernel.org>
Acked-by: Moritz Fischer <mdf@kernel.org>
---
 drivers/fpga/dfl-afu-dma-region.c | 2 +-
 drivers/fpga/dfl-fme-mgr.c        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/fpga/dfl-afu-dma-region.c b/drivers/fpga/dfl-afu-dma-region.c
index 0e81d33..025aba3 100644
--- a/drivers/fpga/dfl-afu-dma-region.c
+++ b/drivers/fpga/dfl-afu-dma-region.c
@@ -70,7 +70,7 @@ static int afu_dma_adjust_locked_vm(struct device *dev, long npages, bool incr)
 	dev_dbg(dev, "[%d] RLIMIT_MEMLOCK %c%ld %ld/%ld%s\n", current->pid,
 		incr ? '+' : '-', npages << PAGE_SHIFT,
 		current->mm->locked_vm << PAGE_SHIFT, rlimit(RLIMIT_MEMLOCK),
-		ret ? "- execeeded" : "");
+		ret ? "- exceeded" : "");
 
 	up_write(&current->mm->mmap_sem);
 
diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c
index b5ef405..9f045d0 100644
--- a/drivers/fpga/dfl-fme-mgr.c
+++ b/drivers/fpga/dfl-fme-mgr.c
@@ -201,7 +201,7 @@ static int fme_mgr_write(struct fpga_manager *mgr,
 		}
 
 		if (count < 4) {
-			dev_err(dev, "Invaild PR bitstream size\n");
+			dev_err(dev, "Invalid PR bitstream size\n");
 			return -EINVAL;
 		}
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-08-16 19:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-16 19:42 [PATCH 0/2] fpga: small fixes for 4.19 Alan Tull
2018-08-16 19:42 ` [PATCH 1/2] fpga: dfl: fme: fix return value check in in pr_mgmt_init() Alan Tull
2018-08-16 19:42 ` [PATCH 2/2] drivers: fpga: fix two trivial spelling mistakes Alan Tull

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.