From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: David Hildenbrand <david@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Michal Hocko <mhocko@suse.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Paul Mackerras <paulus@samba.org>,
linux-s390@vger.kernel.org, sthemmin@microsoft.com,
Pavel Tatashin <pasha.tatashin@oracle.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
David Rientjes <rientjes@google.com>,
xen-devel@lists.xenproject.org, Len Brown <lenb@kernel.org>,
haiyangz@microsoft.com, Dan Williams <dan.j.williams@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
osalvador@suse.de, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Martin
Subject: Re: [PATCH RFC 1/2] drivers/base: export lock_device_hotplug/unlock_device_hotplug
Date: Fri, 17 Aug 2018 13:28:50 +0200 [thread overview]
Message-ID: <20180817112850.GB3565@osiris> (raw)
In-Reply-To: <4ac624be-d2d6-5975-821f-b20a475781dc@redhat.com>
On Fri, Aug 17, 2018 at 01:04:58PM +0200, David Hildenbrand wrote:
> >> If there are no objections, I'll go into that direction. But I'll wait
> >> for more comments regarding the general concept first.
> >
> > It is the middle of the merge window, and maintainers are really busy
> > right now. I doubt you will get many review comments just yet...
> >
>
> This has been broken since 2015, so I guess it can wait a bit :)
I hope you figured out what needs to be locked why. Your patch description
seems to be "only" about locking order ;)
I tried to figure out and document that partially with 55adc1d05dca ("mm:
add private lock to serialize memory hotplug operations"), and that wasn't
easy to figure out. I was especially concerned about sprinkling
lock/unlock_device_hotplug() calls, which has the potential to make it the
next BKL thing.
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: David Hildenbrand <david@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Michal Hocko <mhocko@suse.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Paul Mackerras <paulus@samba.org>,
linux-s390@vger.kernel.org, sthemmin@microsoft.com,
Pavel Tatashin <pasha.tatashin@oracle.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
David Rientjes <rientjes@google.com>,
xen-devel@lists.xenproject.org, Len Brown <lenb@kernel.org>,
haiyangz@microsoft.com, Dan Williams <dan.j.williams@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
osalvador@suse.de, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
devel@linuxdriverproject.org,
Vitaly Kuznetsov <vkuznets@redhat.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH RFC 1/2] drivers/base: export lock_device_hotplug/unlock_device_hotplug
Date: Fri, 17 Aug 2018 13:28:50 +0200 [thread overview]
Message-ID: <20180817112850.GB3565@osiris> (raw)
In-Reply-To: <4ac624be-d2d6-5975-821f-b20a475781dc@redhat.com>
On Fri, Aug 17, 2018 at 01:04:58PM +0200, David Hildenbrand wrote:
> >> If there are no objections, I'll go into that direction. But I'll wait
> >> for more comments regarding the general concept first.
> >
> > It is the middle of the merge window, and maintainers are really busy
> > right now. I doubt you will get many review comments just yet...
> >
>
> This has been broken since 2015, so I guess it can wait a bit :)
I hope you figured out what needs to be locked why. Your patch description
seems to be "only" about locking order ;)
I tried to figure out and document that partially with 55adc1d05dca ("mm:
add private lock to serialize memory hotplug operations"), and that wasn't
easy to figure out. I was especially concerned about sprinkling
lock/unlock_device_hotplug() calls, which has the potential to make it the
next BKL thing.
next prev parent reply other threads:[~2018-08-17 11:28 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 7:58 [PATCH RFC 0/2] mm: online/offline_pages called w.o. mem_hotplug_lock David Hildenbrand
2018-08-17 7:58 ` David Hildenbrand
2018-08-17 7:59 ` [PATCH RFC 1/2] drivers/base: export lock_device_hotplug/unlock_device_hotplug David Hildenbrand
2018-08-17 7:59 ` David Hildenbrand
2018-08-17 7:59 ` David Hildenbrand
2018-08-17 8:41 ` Greg Kroah-Hartman
2018-08-17 8:41 ` Greg Kroah-Hartman
2018-08-17 8:41 ` Greg Kroah-Hartman
2018-08-17 8:56 ` David Hildenbrand
2018-08-17 8:56 ` David Hildenbrand
2018-08-17 9:03 ` Rafael J. Wysocki
2018-08-17 9:03 ` Rafael J. Wysocki
2018-08-17 9:41 ` David Hildenbrand
2018-08-17 9:41 ` David Hildenbrand
2018-08-17 9:41 ` David Hildenbrand
2018-08-17 10:06 ` Greg Kroah-Hartman
2018-08-17 10:06 ` Greg Kroah-Hartman
2018-08-17 11:04 ` David Hildenbrand
2018-08-17 11:04 ` David Hildenbrand
2018-08-17 11:04 ` David Hildenbrand
2018-08-17 11:28 ` Heiko Carstens
2018-08-17 11:28 ` Heiko Carstens [this message]
2018-08-17 11:28 ` Heiko Carstens
2018-08-17 11:56 ` David Hildenbrand
2018-08-17 11:56 ` David Hildenbrand
2018-08-17 11:56 ` David Hildenbrand
2018-08-17 17:02 ` Greg Kroah-Hartman
2018-08-17 17:02 ` Greg Kroah-Hartman
2018-08-17 17:02 ` Greg Kroah-Hartman
2018-08-17 10:06 ` Greg Kroah-Hartman
2018-08-17 9:03 ` Rafael J. Wysocki
2018-08-17 8:56 ` David Hildenbrand
2018-08-17 8:57 ` Rafael J. Wysocki
2018-08-17 8:57 ` Rafael J. Wysocki
2018-08-17 8:57 ` Rafael J. Wysocki
2018-08-17 7:59 ` [PATCH RFC 2/2] mm/memory_hotplug: fix online/offline_pages called w.o. mem_hotplug_lock David Hildenbrand
2018-08-17 7:59 ` David Hildenbrand
2018-08-17 7:59 ` David Hildenbrand
2018-08-17 8:20 ` Rafael J. Wysocki
2018-08-17 8:20 ` Rafael J. Wysocki
2018-08-17 8:27 ` David Hildenbrand
2018-08-17 8:27 ` David Hildenbrand
2018-08-17 8:27 ` David Hildenbrand
2018-08-17 8:20 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817112850.GB3565@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@oracle.com \
--cc=paulus@samba.org \
--cc=rafael@kernel.org \
--cc=rientjes@google.com \
--cc=rjw@rjwysocki.net \
--cc=sthemmin@microsoft.com \
--cc=vbabka@suse.cz \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.