From: Al Viro <viro@ZenIV.linux.org.uk>
To: Mukesh Ojha <mojha@codeaurora.org>
Cc: linux-fsdevel@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: Query on shrink list
Date: Fri, 17 Aug 2018 13:58:12 +0100 [thread overview]
Message-ID: <20180817125812.GC6515@ZenIV.linux.org.uk> (raw)
In-Reply-To: <301a5546-d326-d78e-3be6-41b5a6a08c0e@codeaurora.org>
On Fri, Aug 17, 2018 at 03:39:22PM +0530, Mukesh Ojha wrote:
> Hi Al Viro,
>
> Is there is reason we have kept data->found++, if the dentry already there
> in shrink list ?
>
> static enum d_walk_ret select_collect(
> ...
> ������� if (dentry->d_flags & DCACHE_SHRINK_LIST) {
> ��������������� data->found++;
> ������� } else {
> � ..
>
> If the dentry is already there on shrink list, does it not mean that
> data->found is already non-zero ?
Nope. It can be on *another* shrink list - if two processes are doing
that...
> Can't we just go out from here directly?
WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Mukesh Ojha <mojha@codeaurora.org>
Cc: linux-fsdevel@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: Query on shrink list
Date: Fri, 17 Aug 2018 13:58:12 +0100 [thread overview]
Message-ID: <20180817125812.GC6515@ZenIV.linux.org.uk> (raw)
In-Reply-To: <301a5546-d326-d78e-3be6-41b5a6a08c0e@codeaurora.org>
On Fri, Aug 17, 2018 at 03:39:22PM +0530, Mukesh Ojha wrote:
> Hi Al Viro,
>
> Is there is reason we have kept data->found++, if the dentry already there
> in shrink list ?
>
> static enum d_walk_ret select_collect(
> ...
> if (dentry->d_flags & DCACHE_SHRINK_LIST) {
> data->found++;
> } else {
> ..
>
> If the dentry is already there on shrink list, does it not mean that
> data->found is already non-zero ?
Nope. It can be on *another* shrink list - if two processes are doing
that...
> Can't we just go out from here directly?
next prev parent reply other threads:[~2018-08-17 16:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 10:09 Query on shrink list Mukesh Ojha
2018-08-17 12:58 ` Al Viro [this message]
2018-08-17 12:58 ` Al Viro
2018-08-17 14:37 ` Mukesh Ojha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817125812.GC6515@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mojha@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.