* [PATCH] block: remove duplicate initialization
@ 2018-08-16 22:45 Chaitanya Kulkarni
2018-08-17 18:09 ` Omar Sandoval
2018-08-17 18:34 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2018-08-16 22:45 UTC (permalink / raw)
To: linux-block; +Cc: Chaitanya Kulkarni
This patch removes the duplicate initialization of q->queue_head
in the blk_alloc_queue_node(). This removes the 2nd initialization
so that we preserve the initialization order same as declaration
present in struct request_queue.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
block/blk-core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index 21c7cb35d3b4..dee56c282efb 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -1036,7 +1036,6 @@ struct request_queue *blk_alloc_queue_node(gfp_t gfp_mask, int node_id,
laptop_mode_timer_fn, 0);
timer_setup(&q->timeout, blk_rq_timed_out_timer, 0);
INIT_WORK(&q->timeout_work, NULL);
- INIT_LIST_HEAD(&q->queue_head);
INIT_LIST_HEAD(&q->timeout_list);
INIT_LIST_HEAD(&q->icq_list);
#ifdef CONFIG_BLK_CGROUP
--
2.17.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] block: remove duplicate initialization
2018-08-16 22:45 [PATCH] block: remove duplicate initialization Chaitanya Kulkarni
@ 2018-08-17 18:09 ` Omar Sandoval
2018-08-17 18:34 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Omar Sandoval @ 2018-08-17 18:09 UTC (permalink / raw)
To: Chaitanya Kulkarni; +Cc: linux-block
On Thu, Aug 16, 2018 at 03:45:29PM -0700, Chaitanya Kulkarni wrote:
> This patch removes the duplicate initialization of q->queue_head
> in the blk_alloc_queue_node(). This removes the 2nd initialization
> so that we preserve the initialization order same as declaration
> present in struct request_queue.
Reviewed-by: Omar Sandoval <osandov@fb.com>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> block/blk-core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/blk-core.c b/block/blk-core.c
> index 21c7cb35d3b4..dee56c282efb 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -1036,7 +1036,6 @@ struct request_queue *blk_alloc_queue_node(gfp_t gfp_mask, int node_id,
> laptop_mode_timer_fn, 0);
> timer_setup(&q->timeout, blk_rq_timed_out_timer, 0);
> INIT_WORK(&q->timeout_work, NULL);
> - INIT_LIST_HEAD(&q->queue_head);
> INIT_LIST_HEAD(&q->timeout_list);
> INIT_LIST_HEAD(&q->icq_list);
> #ifdef CONFIG_BLK_CGROUP
> --
> 2.17.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] block: remove duplicate initialization
2018-08-16 22:45 [PATCH] block: remove duplicate initialization Chaitanya Kulkarni
2018-08-17 18:09 ` Omar Sandoval
@ 2018-08-17 18:34 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2018-08-17 18:34 UTC (permalink / raw)
To: Chaitanya Kulkarni, linux-block
On 8/16/18 4:45 PM, Chaitanya Kulkarni wrote:
> This patch removes the duplicate initialization of q->queue_head
> in the blk_alloc_queue_node(). This removes the 2nd initialization
> so that we preserve the initialization order same as declaration
> present in struct request_queue.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-17 21:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-16 22:45 [PATCH] block: remove duplicate initialization Chaitanya Kulkarni
2018-08-17 18:09 ` Omar Sandoval
2018-08-17 18:34 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.