* [PATCH] fpga: dfl: region: Restory symmetry in probe()/remove()
@ 2018-08-17 23:40 Moritz Fischer
2018-08-18 0:44 ` Moritz Fischer
0 siblings, 1 reply; 2+ messages in thread
From: Moritz Fischer @ 2018-08-17 23:40 UTC (permalink / raw)
To: hao.wu; +Cc: atull, linux-fpga, linux-kernel, Moritz Fischer
Replace dev_get_drvdata() with platform_get_drvdata() to
match the platform_set_drvdata() in the probe function of
the platform driver.
Fixes commit bb61b9be3e6b ("fpga: dfl: add fpga region platform driver for
FME")
Signed-off-by: Moritz Fischer <mdf@kernel.org>
---
drivers/fpga/dfl-fme-region.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/dfl-fme-region.c b/drivers/fpga/dfl-fme-region.c
index 0b7e19c27c6d..ce7ebe4b3212 100644
--- a/drivers/fpga/dfl-fme-region.c
+++ b/drivers/fpga/dfl-fme-region.c
@@ -65,7 +65,7 @@ static int fme_region_probe(struct platform_device *pdev)
static int fme_region_remove(struct platform_device *pdev)
{
- struct fpga_region *region = dev_get_drvdata(&pdev->dev);
+ struct fpga_region *region = platform_get_drvdata(&pdev->dev);
fpga_region_unregister(region);
fpga_mgr_put(region->mgr);
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] fpga: dfl: region: Restory symmetry in probe()/remove()
2018-08-17 23:40 [PATCH] fpga: dfl: region: Restory symmetry in probe()/remove() Moritz Fischer
@ 2018-08-18 0:44 ` Moritz Fischer
0 siblings, 0 replies; 2+ messages in thread
From: Moritz Fischer @ 2018-08-18 0:44 UTC (permalink / raw)
To: Wu Hao; +Cc: Alan Tull, linux-fpga, Linux Kernel Mailing List, Moritz Fischer
On Fri, Aug 17, 2018 at 4:40 PM, Moritz Fischer <mdf@kernel.org> wrote:
> Replace dev_get_drvdata() with platform_get_drvdata() to
> match the platform_set_drvdata() in the probe function of
> the platform driver.
>
> Fixes commit bb61b9be3e6b ("fpga: dfl: add fpga region platform driver for
> FME")
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
> drivers/fpga/dfl-fme-region.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/dfl-fme-region.c b/drivers/fpga/dfl-fme-region.c
> index 0b7e19c27c6d..ce7ebe4b3212 100644
> --- a/drivers/fpga/dfl-fme-region.c
> +++ b/drivers/fpga/dfl-fme-region.c
> @@ -65,7 +65,7 @@ static int fme_region_probe(struct platform_device *pdev)
>
> static int fme_region_remove(struct platform_device *pdev)
> {
> - struct fpga_region *region = dev_get_drvdata(&pdev->dev);
> + struct fpga_region *region = platform_get_drvdata(&pdev->dev);
Blergh ... that doesn't even compile. I'll resubmit next week. Sorry
for the noise.
Should of course be platform_get_drvdata(pdev);
- Moritz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-18 0:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-17 23:40 [PATCH] fpga: dfl: region: Restory symmetry in probe()/remove() Moritz Fischer
2018-08-18 0:44 ` Moritz Fischer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.