From: Shawn Guo <shawnguo@kernel.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: "A.s. Dong" <aisheng.dong@nxp.com>,
"Joao.Pinto@synopsys.com" <Joao.Pinto@synopsys.com>,
Richard Zhu <hongxing.zhu@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Anson Huang <anson.huang@nxp.com>,
"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
"jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
dl-linux-imx <linux-imx@nxp.com>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>
Subject: Re: [PATCH v3 0/2] PCI: imx: Initial imx7d pm support
Date: Tue, 21 Aug 2018 23:26:44 +0800 [thread overview]
Message-ID: <20180821152643.GC32159@dragon> (raw)
In-Reply-To: <20180810151341.GA6863@e107981-ln.cambridge.arm.com>
On Fri, Aug 10, 2018 at 04:13:41PM +0100, Lorenzo Pieralisi wrote:
> On Fri, Aug 10, 2018 at 11:11:55AM +0000, Leonard Crestez wrote:
>
> [...]
>
> > This needs further clarification: without the reset patch this will
> > hang on imx7 suspend/resume but this is the current behavior anyway.
> >
> > Both patches are required for imx7 pci suspend and including them out
> > of order shouldn't break unrelated functionality.
> >
> > So it should actually be fine to just include the pci changes now,
> > right?
>
> It is a bit late for v4.19 but before considering that, this series
> is actually a set of fixes, correct ? If that's the case I think
> Shawn can send them upstream for a v4.19-rc*, I can ACK them if that
> sounds reasonable.
>
> Patch (2) subject must make clear you are actually fixing a problem if
> we choose this course of action.
This is something never worked before, so it's a new feature to me.
That said, I'm not in the position to send the PCI patch for 4.19-rc as
a fix though IMX (arm-soc) tree.
I will send the DTS patch for 4.19-rc inclusion though, since that's
indeed a fix.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/2] PCI: imx: Initial imx7d pm support
Date: Tue, 21 Aug 2018 23:26:44 +0800 [thread overview]
Message-ID: <20180821152643.GC32159@dragon> (raw)
In-Reply-To: <20180810151341.GA6863@e107981-ln.cambridge.arm.com>
On Fri, Aug 10, 2018 at 04:13:41PM +0100, Lorenzo Pieralisi wrote:
> On Fri, Aug 10, 2018 at 11:11:55AM +0000, Leonard Crestez wrote:
>
> [...]
>
> > This needs further clarification: without the reset patch this will
> > hang on imx7 suspend/resume but this is the current behavior anyway.
> >
> > Both patches are required for imx7 pci suspend and including them out
> > of order shouldn't break unrelated functionality.
> >
> > So it should actually be fine to just include the pci changes now,
> > right?
>
> It is a bit late for v4.19 but before considering that, this series
> is actually a set of fixes, correct ? If that's the case I think
> Shawn can send them upstream for a v4.19-rc*, I can ACK them if that
> sounds reasonable.
>
> Patch (2) subject must make clear you are actually fixing a problem if
> we choose this course of action.
This is something never worked before, so it's a new feature to me.
That said, I'm not in the position to send the PCI patch for 4.19-rc as
a fix though IMX (arm-soc) tree.
I will send the DTS patch for 4.19-rc inclusion though, since that's
indeed a fix.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Leonard Crestez <leonard.crestez@nxp.com>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Richard Zhu <hongxing.zhu@nxp.com>,
"jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"A.s. Dong" <aisheng.dong@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
"Joao.Pinto@synopsys.com" <Joao.Pinto@synopsys.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"andrew.smirnov@gmail.com" <andrew.smirnov@gmail.com>,
Anson Huang <anson.huang@nxp.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH v3 0/2] PCI: imx: Initial imx7d pm support
Date: Tue, 21 Aug 2018 23:26:44 +0800 [thread overview]
Message-ID: <20180821152643.GC32159@dragon> (raw)
In-Reply-To: <20180810151341.GA6863@e107981-ln.cambridge.arm.com>
On Fri, Aug 10, 2018 at 04:13:41PM +0100, Lorenzo Pieralisi wrote:
> On Fri, Aug 10, 2018 at 11:11:55AM +0000, Leonard Crestez wrote:
>
> [...]
>
> > This needs further clarification: without the reset patch this will
> > hang on imx7 suspend/resume but this is the current behavior anyway.
> >
> > Both patches are required for imx7 pci suspend and including them out
> > of order shouldn't break unrelated functionality.
> >
> > So it should actually be fine to just include the pci changes now,
> > right?
>
> It is a bit late for v4.19 but before considering that, this series
> is actually a set of fixes, correct ? If that's the case I think
> Shawn can send them upstream for a v4.19-rc*, I can ACK them if that
> sounds reasonable.
>
> Patch (2) subject must make clear you are actually fixing a problem if
> we choose this course of action.
This is something never worked before, so it's a new feature to me.
That said, I'm not in the position to send the PCI patch for 4.19-rc as
a fix though IMX (arm-soc) tree.
I will send the DTS patch for 4.19-rc inclusion though, since that's
indeed a fix.
Shawn
next prev parent reply other threads:[~2018-08-21 15:26 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 16:14 [PATCH v3 0/2] PCI: imx: Initial imx7d pm support Leonard Crestez
2018-07-24 16:14 ` Leonard Crestez
2018-07-24 16:14 ` Leonard Crestez
2018-07-24 16:14 ` [PATCH v3 1/2] Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping" Leonard Crestez
2018-07-24 16:14 ` Leonard Crestez
2018-07-24 16:14 ` Leonard Crestez
2018-07-24 16:52 ` Lucas Stach
2018-07-24 16:52 ` Lucas Stach
2018-07-24 16:52 ` Lucas Stach
2018-08-21 15:31 ` Shawn Guo
2018-08-21 15:31 ` Shawn Guo
2018-08-21 15:31 ` Shawn Guo
2018-07-24 16:14 ` [PATCH v3 2/2] PCI: imx: Initial imx7d pm support Leonard Crestez
2018-07-24 16:14 ` Leonard Crestez
2018-07-24 16:14 ` Leonard Crestez
2018-07-24 16:55 ` Lucas Stach
2018-07-24 16:55 ` Lucas Stach
2018-07-24 16:55 ` Lucas Stach
2018-08-08 10:53 ` [PATCH v3 0/2] " Leonard Crestez
2018-08-08 10:53 ` Leonard Crestez
2018-08-08 10:53 ` Leonard Crestez
2018-08-08 11:14 ` Lorenzo Pieralisi
2018-08-08 11:14 ` Lorenzo Pieralisi
2018-08-08 11:14 ` Lorenzo Pieralisi
2018-08-08 11:37 ` Leonard Crestez
2018-08-08 11:37 ` Leonard Crestez
2018-08-08 11:37 ` Leonard Crestez
2018-08-08 14:19 ` Lorenzo Pieralisi
2018-08-08 14:19 ` Lorenzo Pieralisi
2018-08-08 14:19 ` Lorenzo Pieralisi
2018-08-08 14:58 ` Leonard Crestez
2018-08-08 14:58 ` Leonard Crestez
2018-08-08 14:58 ` Leonard Crestez
2018-08-08 15:27 ` Lorenzo Pieralisi
2018-08-08 15:27 ` Lorenzo Pieralisi
2018-08-10 11:11 ` Leonard Crestez
2018-08-10 11:11 ` Leonard Crestez
2018-08-10 11:11 ` Leonard Crestez
2018-08-10 15:13 ` Lorenzo Pieralisi
2018-08-10 15:13 ` Lorenzo Pieralisi
2018-08-10 15:13 ` Lorenzo Pieralisi
2018-08-21 15:26 ` Shawn Guo [this message]
2018-08-21 15:26 ` Shawn Guo
2018-08-21 15:26 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180821152643.GC32159@dragon \
--to=shawnguo@kernel.org \
--cc=Joao.Pinto@synopsys.com \
--cc=aisheng.dong@nxp.com \
--cc=andrew.smirnov@gmail.com \
--cc=anson.huang@nxp.com \
--cc=bhelgaas@google.com \
--cc=fabio.estevam@nxp.com \
--cc=hongxing.zhu@nxp.com \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.