[PATCH 0/3] Add secondary toolchain to devkit

[PATCH 0/3] Add secondary toolchain to devkit

[Jacob Stiffler]

Add a method to install a second toolchain in the devkit for situation
when a chip has multiple cores with different architectures.


Changes from RFC:
* Move all changes to meta-arago-distro
* Move configuration from arago-prefs.inc to toolchain-linaro.inc

Jacob Stiffler (3):
  external-linaro-secondary-sdk-toolchain: secondary toolchain for
    devkit
  packagegroup-arago-cross-canadian: add SECONDARY_TOOLCHAIN
  toolchain-linaro: enable SECONDARY_TOOLCHAIN

 meta-arago-distro/conf/distro/include/toolchain-linaro.inc        | 3 +++
 .../recipes-core/meta/external-linaro-secondary-sdk-toolchain.bb  | 4 ++++
 .../packagegroups/packagegroup-arago-cross-canadian.bbappend      | 8 ++++++++
 3 files changed, 15 insertions(+)
 create mode 100644 meta-arago-distro/recipes-core/meta/external-linaro-secondary-sdk-toolchain.bb
 create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-cross-canadian.bbappend

-- 
2.7.4

[PATCH 1/3] external-linaro-secondary-sdk-toolchain: secondary toolchain for devkit

[Jacob Stiffler]

* Add a method to install an secondary toolchain in the devkit.
* The architecture for this toolchain can be configured by setting
  "SECONDARY_TOOLCHAIN_ARCH" in some top-level config file.

Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
---
 .../recipes-core/meta/external-linaro-secondary-sdk-toolchain.bb      | 4 ++++
 1 file changed, 4 insertions(+)
 create mode 100644 meta-arago-distro/recipes-core/meta/external-linaro-secondary-sdk-toolchain.bb

diff --git a/meta-arago-distro/recipes-core/meta/external-linaro-secondary-sdk-toolchain.bb b/meta-arago-distro/recipes-core/meta/external-linaro-secondary-sdk-toolchain.bb
new file mode 100644
index 0000000..d94070e
--- /dev/null
+++ b/meta-arago-distro/recipes-core/meta/external-linaro-secondary-sdk-toolchain.bb
@@ -0,0 +1,4 @@
+TARGET_ARCH := "${SECONDARY_TARGET_ARCH}"
+MACHINEOVERRIDES := "${SECONDARY_TARGET_ARCH}"
+
+require recipes-core/meta/external-linaro-sdk-toolchain.bb
-- 
2.7.4

[PATCH 2/3] packagegroup-arago-cross-canadian: add SECONDARY_TOOLCHAIN

[Jacob Stiffler]

* Add the secondary toolchain to the devkit
 if SECONDARY_TOOLCHAIN_ARCH is defined.

Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
---
 .../packagegroups/packagegroup-arago-cross-canadian.bbappend      | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-cross-canadian.bbappend

diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-cross-canadian.bbappend b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-cross-canadian.bbappend
new file mode 100644
index 0000000..f02dfd9
--- /dev/null
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-cross-canadian.bbappend
@@ -0,0 +1,8 @@
+PR_append = ".arago0"
+
+SECONDARY_TOOLCHAIN = "gcc-cross-canadian-${SECONDARY_TARGET_ARCH} \
+                       binutils-cross-canadian-${SECONDARY_TARGET_ARCH}"
+
+RDEPENDS_${PN}_append = " \
+    ${@base_conditional('SECONDARY_TARGET_ARCH', '', '', '${SECONDARY_TOOLCHAIN}', d)} \
+"
-- 
2.7.4

[PATCH 3/3] toolchain-linaro: enable SECONDARY_TOOLCHAIN

[Jacob Stiffler]

* disable SECONDARY_TOOLCHAIN by default
* For k3, configure the secondary toolchain as armv7a for the R5
  cores.

Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
---
 meta-arago-distro/conf/distro/include/toolchain-linaro.inc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta-arago-distro/conf/distro/include/toolchain-linaro.inc b/meta-arago-distro/conf/distro/include/toolchain-linaro.inc
index 9836e5c..06de680 100644
--- a/meta-arago-distro/conf/distro/include/toolchain-linaro.inc
+++ b/meta-arago-distro/conf/distro/include/toolchain-linaro.inc
@@ -10,6 +10,9 @@ ELT_TARGET_SYS_arm = "${ELT_TARGET_SYS_ARMV5}"
 ELT_TARGET_SYS_armv7a = "${ELT_TARGET_SYS_ARMV7}"
 ELT_TARGET_SYS_aarch64 = "${ELT_TARGET_SYS_ARMV8}"
 
+SECONDARY_TARGET_ARCH = ""
+SECONDARY_TARGET_ARCH_k3 = "armv7a"
+
 TARGET_VENDOR = ""
 
 TOOLCHAIN_BASE ?= "/opt"
-- 
2.7.4

Re: [PATCH 2/3] packagegroup-arago-cross-canadian: add SECONDARY_TOOLCHAIN

[Denys Dmytriyenko]

On Tue, Aug 21, 2018 at 03:13:56PM -0400, Jacob Stiffler wrote:
> * Add the secondary toolchain to the devkit
>  if SECONDARY_TOOLCHAIN_ARCH is defined.
> 
> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> ---
>  .../packagegroups/packagegroup-arago-cross-canadian.bbappend      | 8 ++++++++
>  1 file changed, 8 insertions(+)
>  create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-cross-canadian.bbappend
> 
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-cross-canadian.bbappend b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-cross-canadian.bbappend
> new file mode 100644
> index 0000000..f02dfd9
> --- /dev/null
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-cross-canadian.bbappend
> @@ -0,0 +1,8 @@
> +PR_append = ".arago0"
> +
> +SECONDARY_TOOLCHAIN = "gcc-cross-canadian-${SECONDARY_TARGET_ARCH} \
> +                       binutils-cross-canadian-${SECONDARY_TARGET_ARCH}"

Since this is a bbappend, it will come into play for internal toolchain as 
well, but in that case SECONDARY_TARGET_ARCH won't be set.

You might want to do something like this:
http://arago-project.org/git/?p=meta-arago.git;a=blob;f=meta-arago-distro/recipes-devtools/gcc/gcc_%25.bbappend;hb=HEAD


> +RDEPENDS_${PN}_append = " \
> +    ${@base_conditional('SECONDARY_TARGET_ARCH', '', '', '${SECONDARY_TOOLCHAIN}', d)} \
> +"
> -- 
> 2.7.4
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH 2/3] packagegroup-arago-cross-canadian: add SECONDARY_TOOLCHAIN

[Denys Dmytriyenko]

On Tue, Aug 21, 2018 at 05:40:44PM -0400, Denys Dmytriyenko wrote:
> On Tue, Aug 21, 2018 at 03:13:56PM -0400, Jacob Stiffler wrote:
> > * Add the secondary toolchain to the devkit
> >  if SECONDARY_TOOLCHAIN_ARCH is defined.
> > 
> > Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> > ---
> >  .../packagegroups/packagegroup-arago-cross-canadian.bbappend      | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >  create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-cross-canadian.bbappend
> > 
> > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-cross-canadian.bbappend b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-cross-canadian.bbappend
> > new file mode 100644
> > index 0000000..f02dfd9
> > --- /dev/null
> > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-cross-canadian.bbappend
> > @@ -0,0 +1,8 @@
> > +PR_append = ".arago0"
> > +
> > +SECONDARY_TOOLCHAIN = "gcc-cross-canadian-${SECONDARY_TARGET_ARCH} \
> > +                       binutils-cross-canadian-${SECONDARY_TARGET_ARCH}"
> 
> Since this is a bbappend, it will come into play for internal toolchain as 
> well, but in that case SECONDARY_TARGET_ARCH won't be set.
> 
> You might want to do something like this:
> http://arago-project.org/git/?p=meta-arago.git;a=blob;f=meta-arago-distro/recipes-devtools/gcc/gcc_%25.bbappend;hb=HEAD

Or you can simply set it empty here if not already set.

SECONDADRY_TARGET_ARCH ?= ""


> > +RDEPENDS_${PN}_append = " \
> > +    ${@base_conditional('SECONDARY_TARGET_ARCH', '', '', '${SECONDARY_TOOLCHAIN}', d)} \
> > +"
> > -- 
> > 2.7.4
> > 
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH 2/3] packagegroup-arago-cross-canadian: add SECONDARY_TOOLCHAIN

[Jacob Stiffler]

On 8/21/2018 5:44 PM, Denys Dmytriyenko wrote:
> On Tue, Aug 21, 2018 at 05:40:44PM -0400, Denys Dmytriyenko wrote:
>> On Tue, Aug 21, 2018 at 03:13:56PM -0400, Jacob Stiffler wrote:
>>> * Add the secondary toolchain to the devkit
>>>   if SECONDARY_TOOLCHAIN_ARCH is defined.
>>>
>>> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
>>> ---
>>>   .../packagegroups/packagegroup-arago-cross-canadian.bbappend      | 8 ++++++++
>>>   1 file changed, 8 insertions(+)
>>>   create mode 100644 meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-cross-canadian.bbappend
>>>
>>> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-cross-canadian.bbappend b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-cross-canadian.bbappend
>>> new file mode 100644
>>> index 0000000..f02dfd9
>>> --- /dev/null
>>> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-cross-canadian.bbappend
>>> @@ -0,0 +1,8 @@
>>> +PR_append = ".arago0"
>>> +
>>> +SECONDARY_TOOLCHAIN = "gcc-cross-canadian-${SECONDARY_TARGET_ARCH} \
>>> +                       binutils-cross-canadian-${SECONDARY_TARGET_ARCH}"
>> Since this is a bbappend, it will come into play for internal toolchain as
>> well, but in that case SECONDARY_TARGET_ARCH won't be set.

I forgot how uninitialized variables are not "empty".

>> You might want to do something like this:
>> http://arago-project.org/git/?p=meta-arago.git;a=blob;f=meta-arago-distro/recipes-devtools/gcc/gcc_%25.bbappend;hb=HEAD
> Or you can simply set it empty here if not already set.
>
> SECONDADRY_TARGET_ARCH ?= ""

I think I will go with this to make is somewhat easier to read.

>
>>> +RDEPENDS_${PN}_append = " \
>>> +    ${@base_conditional('SECONDARY_TARGET_ARCH', '', '', '${SECONDARY_TOOLCHAIN}', d)} \
>>> +"
>>> -- 
>>> 2.7.4
>>>
>>> _______________________________________________
>>> meta-arago mailing list
>>> meta-arago@arago-project.org
>>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>> _______________________________________________
>> meta-arago mailing list
>> meta-arago@arago-project.org
>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago