From: Sam Ravnborg <sam@ravnborg.org>
To: Barebox List <barebox@lists.infradead.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Subject: [PATCH v4 0/3] Add Davicom phy + reset-gpios
Date: Wed, 22 Aug 2018 20:35:55 +0200 [thread overview]
Message-ID: <20180822183555.GA24084@ravnborg.org> (raw)
Changes in v4:
- Either register a mdio node or phy child nodes
- Check for valid phy node before registering the phy node
This is like the kernel does it
- Also recognize compatible="ethernet-phy-id*" as PHY's
again like the kernel, but with a simpler implementation,
as we do not try to read the actual phy_id
Changes in v3:
- Consider the v3 a new implmentation - almost nothing was
left from v2. Thus also invalidate any former review - sorry.
- Dropped the need for the mdio {} node, as this node is
only used when there is dedicated HW support for the mdio.
- Added so PHY child nodes to ethernet nodes are registered,
and as part of registration the PHY nodes are reset if
the reset-gpios property is present.
- Further dropped that the parsed info is stored in the bus,
as we only do reset once, thus there is no need to
save the info from the DT
- Futher dropped helper function to reset. They was not needed
- Named the gpio with the name of the PHY node
in the DT. This makes it unique and easier to recognize.
Changes in v2:
- Added patch to enable Davicom PHY on at91sam9263ek - evaluation kit
- Fix so we do reset before comunicating with the PHY
- Rename to mdio_reset()
- Reference correct binding file in commit log (mdio.txt)
- Tested on at91sam9263ek
The at91sam9263ek kit do not require the reset like my
proprietary board, so no DT changes required
Intro:
The following patches was necessary to get networking
operational on my proprietary target.
The target is at91sam9263 based with a Davicom PHY.
The Davicom PHY is a straight copy form the Linux
kernel with the interrupt routine removed and
minor adjustments to the rest.
The davicom PHY would not work until it had seen a reset
cycle - which I think may be an artifact of the board design.
To fix the reset issue I have implemented support for the
reset-gpios binding (see net/phy.txt bindings).
A minimal implmentation was done, just enough to get
my target running.
I could have implemented something in macb -
but I preferred the more generic solution.
Also included are a patch that for the at91sam9263ek
evaluation board. The patch adds several extra tools
that are usefull for testing, and enable the Davicom PHY.
Sam
Sam Ravnborg (3):
phylib: add Davicom PHY support
phylib: add support for reset-gpios
at91sam9263ek: add PHY, miitool etc. to config
arch/arm/configs/at91sam9263ek_defconfig | 12 ++-
drivers/net/phy/Kconfig | 5 ++
drivers/net/phy/Makefile | 1 +
drivers/net/phy/davicom.c | 140 +++++++++++++++++++++++++++++++
drivers/net/phy/mdio_bus.c | 97 ++++++++++++++++++++-
5 files changed, 253 insertions(+), 2 deletions(-)
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2018-08-22 18:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 18:35 Sam Ravnborg [this message]
2018-08-22 18:36 ` [PATCH v4 1/3] phylib: add Davicom PHY support Sam Ravnborg
2018-08-22 18:36 ` [PATCH v4 2/3] phylib: add support for reset-gpios Sam Ravnborg
2018-08-22 18:36 ` [PATCH v4 3/3] at91sam9263ek: add PHY, miitool etc. to config Sam Ravnborg
2018-08-24 8:03 ` [PATCH v4 0/3] Add Davicom phy + reset-gpios Sascha Hauer
2018-09-07 19:35 ` [PATCH v1 0/5] add quartz load support to NXP rtc drivers Sam Ravnborg
2018-09-07 19:35 ` [PATCH v1 1/5] dt-binding: rtci-pcf8523: add quartz_load property Sam Ravnborg
2018-09-07 21:43 ` Sam Ravnborg
2018-09-13 19:05 ` Alexandre Belloni
2018-09-13 20:44 ` Sam Ravnborg
2018-09-13 20:51 ` Alexandre Belloni
2018-09-26 15:47 ` Rob Herring
2018-09-26 18:51 ` Alexandre Belloni
2018-09-26 20:42 ` Sam Ravnborg
2018-09-07 19:35 ` [PATCH v1 2/5] dt-binding: rtc-pcf85063: add quartz load property Sam Ravnborg
2018-09-13 19:11 ` Alexandre Belloni
2018-09-07 19:35 ` [PATCH v1 3/5] dts: add nxp,quartz_load_12.5pf to all pcf8523 nodes Sam Ravnborg
2018-09-13 19:14 ` Alexandre Belloni
2018-09-07 19:35 ` [PATCH v1 4/5] rtc: pcf8523: external capacitor configuration Sam Ravnborg
2018-09-13 19:27 ` Alexandre Belloni
2018-09-07 19:35 ` [PATCH v1 5/5] rtc: pcf85063: " Sam Ravnborg
2018-09-13 19:29 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180822183555.GA24084@ravnborg.org \
--to=sam@ravnborg.org \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.