From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "Alessandro Zummo" <a.zummo@towertech.it>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"Joel Stanley" <joel@jms.id.au>,
"Mark Rutland" <mark.rutland@arm.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rtc@vger.kernel.org, "Søren Andersen" <san@skov.dk>
Subject: Re: [PATCH v1 3/5] dts: add nxp,quartz_load_12.5pf to all pcf8523 nodes
Date: Thu, 13 Sep 2018 21:14:50 +0200 [thread overview]
Message-ID: <20180913191450.GI14988@piout.net> (raw)
In-Reply-To: <20180907193508.24974-4-sam@ravnborg.org>
On 07/09/2018 21:35:06+0200, Sam Ravnborg wrote:
> From: Søren Andersen <san@skov.dk>
>
> Add "nxp,quartz_load_12.5pf" to all pcf8523 nodes.
>
> The device tree binding for the pcf8523 now includes
> a property "nxp,quartz_load_12.5pf" to specify
> that the connected x-tal has an internal capacitance
> of 12.5 pF.
> Add this to all pcf8523 nodes, because this was implicit before,
> at least in the Linux kernel where the driver was hardcoded
> to set the rtc to use 12.5 pF.
>
Well, this patch is not needed as we should not break the DT ABI. See
comment on the next patch...
> Signed-off-by: Søren Andersen <san@skov.dk>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Joel Stanley <joel@jms.id.au>
> Cc: Andrew Jeffery <andrew@aj.id.au>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Russell King <linux@armlinux.org.uk>
> ---
> arch/arm/boot/dts/aspeed-bmc-opp-lanyang.dts | 1 +
> arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 1 +
> arch/arm/boot/dts/imx6q-h100.dts | 1 +
> arch/arm/boot/dts/imx6q-novena.dts | 1 +
> arch/arm/boot/dts/imx6qdl-cubox-i.dtsi | 1 +
> arch/arm/boot/dts/imx6qdl-hummingboard.dtsi | 1 +
> arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi | 1 +
> 7 files changed, 7 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-lanyang.dts b/arch/arm/boot/dts/aspeed-bmc-opp-lanyang.dts
> index d598b6391362..d1a0e3521e2b 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-lanyang.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-lanyang.dts
> @@ -200,6 +200,7 @@
> rtc@68 {
> compatible = "nxp,pcf8523";
> reg = <0x68>;
> + nxp,quartz_load_12.5pf;
> };
>
> tmp75@48 {
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> index 2c5aa90a546d..b5088414e610 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> @@ -201,6 +201,7 @@
> rtc@68 {
> compatible = "nxp,pcf8523";
> reg = <0x68>;
> + nxp,quartz_load_12.5pf;
> };
>
> ucd90160@64 {
> diff --git a/arch/arm/boot/dts/imx6q-h100.dts b/arch/arm/boot/dts/imx6q-h100.dts
> index 714e09e04dcb..3b6116069b11 100644
> --- a/arch/arm/boot/dts/imx6q-h100.dts
> +++ b/arch/arm/boot/dts/imx6q-h100.dts
> @@ -173,6 +173,7 @@
> rtc: pcf8523@68 {
> compatible = "nxp,pcf8523";
> reg = <0x68>;
> + nxp,quartz_load_12.5pf;
> };
>
> sgtl5000: sgtl5000@a {
> diff --git a/arch/arm/boot/dts/imx6q-novena.dts b/arch/arm/boot/dts/imx6q-novena.dts
> index fcd824dc485b..6a2eaaa6e220 100644
> --- a/arch/arm/boot/dts/imx6q-novena.dts
> +++ b/arch/arm/boot/dts/imx6q-novena.dts
> @@ -257,6 +257,7 @@
> rtc: pcf8523@68 {
> compatible = "nxp,pcf8523";
> reg = <0x68>;
> + nxp,quartz_load_12.5pf;
> };
>
> sbs_battery: bq20z75@b {
> diff --git a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> index 9332a31e6c8b..e0f601bce3d3 100644
> --- a/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-cubox-i.dtsi
> @@ -143,6 +143,7 @@
> rtc@68 {
> compatible = "nxp,pcf8523";
> reg = <0x68>;
> + nxp,quartz_load_12.5pf;
> };
> };
>
> diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
> index 0e64016e765f..7848b818078e 100644
> --- a/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-hummingboard.dtsi
> @@ -189,6 +189,7 @@
> rtc@68 {
> compatible = "nxp,pcf8523";
> reg = <0x68>;
> + nxp,quartz_load_12.5pf;
> };
>
> /* Pro baseboard model */
> diff --git a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
> index c413f9c3540f..7bc264234085 100644
> --- a/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-hummingboard2.dtsi
> @@ -222,6 +222,7 @@
> pcf8523: rtc@68 {
> compatible = "nxp,pcf8523";
> reg = <0x68>;
> + nxp,quartz_load_12.5pf;
> };
>
> sgtl5000: codec@a {
> --
> 2.12.0
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-09-14 0:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 18:35 [PATCH v4 0/3] Add Davicom phy + reset-gpios Sam Ravnborg
2018-08-22 18:36 ` [PATCH v4 1/3] phylib: add Davicom PHY support Sam Ravnborg
2018-08-22 18:36 ` [PATCH v4 2/3] phylib: add support for reset-gpios Sam Ravnborg
2018-08-22 18:36 ` [PATCH v4 3/3] at91sam9263ek: add PHY, miitool etc. to config Sam Ravnborg
2018-08-24 8:03 ` [PATCH v4 0/3] Add Davicom phy + reset-gpios Sascha Hauer
2018-09-07 19:35 ` [PATCH v1 0/5] add quartz load support to NXP rtc drivers Sam Ravnborg
2018-09-07 19:35 ` [PATCH v1 1/5] dt-binding: rtci-pcf8523: add quartz_load property Sam Ravnborg
2018-09-07 21:43 ` Sam Ravnborg
2018-09-13 19:05 ` Alexandre Belloni
2018-09-13 20:44 ` Sam Ravnborg
2018-09-13 20:51 ` Alexandre Belloni
2018-09-26 15:47 ` Rob Herring
2018-09-26 18:51 ` Alexandre Belloni
2018-09-26 20:42 ` Sam Ravnborg
2018-09-07 19:35 ` [PATCH v1 2/5] dt-binding: rtc-pcf85063: add quartz load property Sam Ravnborg
2018-09-13 19:11 ` Alexandre Belloni
2018-09-07 19:35 ` [PATCH v1 3/5] dts: add nxp,quartz_load_12.5pf to all pcf8523 nodes Sam Ravnborg
2018-09-13 19:14 ` Alexandre Belloni [this message]
2018-09-07 19:35 ` [PATCH v1 4/5] rtc: pcf8523: external capacitor configuration Sam Ravnborg
2018-09-13 19:27 ` Alexandre Belloni
2018-09-07 19:35 ` [PATCH v1 5/5] rtc: pcf85063: " Sam Ravnborg
2018-09-13 19:29 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913191450.GI14988@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=a.zummo@towertech.it \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=san@skov.dk \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.