All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Fan <fanc.fnst@cn.fujitsu.com>
To: Baoquan He <bhe@redhat.com>
Cc: <tglx@linutronix.de>, <mingo@redhat.com>, <hpa@zytor.com>,
	<x86@kernel.org>, <linux-kernel@vger.kernel.org>,
	<keescook@chromium.org>, <n-horiguchi@ah.jp.nec.com>,
	<indou.takao@jp.fujitsu.com>, <caoj.fnst@cn.fujitsu.com>,
	<douly.fnst@cn.fujitsu.com>
Subject: Re: [PATCH v5 3/4] x86/boot/KASLR: Walk srat tables to filter immovable memory
Date: Thu, 23 Aug 2018 15:30:15 +0800	[thread overview]
Message-ID: <20180823073015.GB6769@localhost.localdomain> (raw)
In-Reply-To: <20180823072535.GL29313@MiWiFi-R3L-srv>

On Thu, Aug 23, 2018 at 03:25:35PM +0800, Baoquan He wrote:
[...]
>> +static void handle_immovable_mem(void)
>> +{
>> +	char *args = (char *)get_cmd_line_ptr();
>> +	struct acpi_table_header *table_header;
>> +	struct acpi_subtable_header *table;
>> +	struct acpi_srat_mem_affinity *ma;
>> +	unsigned long table_end;
>> +	int i = 0;
>> +
>> +	if (!strstr(args, "movable_node"))
>
>If 'acpi=off' specified, better return too here.

Thanks, you are right.
Yes, I will think about it and add it to a suitable place.
May the position where we try to get the acpi table is better.
Or just here is also OK.

Thanks,
Chao Fan

>




  reply	other threads:[~2018-08-23  7:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-07  6:49 [PATCH v5 0/4] x86/boot/KASLR: Parse ACPI table and limit kaslr in immovable memory Chao Fan
2018-08-07  6:49 ` [PATCH v5 1/4] x86/boot: Add acpitb.h to help parse acpi tables Chao Fan
2018-08-07  6:49 ` [PATCH v5 2/4] x86/boot: Add acpitb.c to " Chao Fan
2018-08-27  9:32   ` Baoquan He
2018-08-07  6:49 ` [PATCH v5 3/4] x86/boot/KASLR: Walk srat tables to filter immovable memory Chao Fan
2018-08-23  7:25   ` Baoquan He
2018-08-23  7:30     ` Chao Fan [this message]
2018-08-27  2:13   ` Baoquan He
2018-08-27  2:56     ` Chao Fan
2018-08-27  3:07       ` Baoquan He
2018-08-07  6:50 ` [PATCH v5 4/4] x86/boot/KASLR: Limit kaslr to choosing the " Chao Fan
2018-08-27  5:35   ` Baoquan He
2018-08-27  6:04     ` Baoquan He
2018-08-27  5:56   ` Baoquan He
2018-08-27  6:28     ` Chao Fan
2018-08-27  6:31       ` Chao Fan
2018-08-27  7:01       ` Baoquan He
2018-08-27  7:10     ` Baoquan He
2018-08-23  1:37 ` [PATCH v5 0/4] x86/boot/KASLR: Parse ACPI table and limit kaslr in " Chao Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180823073015.GB6769@localhost.localdomain \
    --to=fanc.fnst@cn.fujitsu.com \
    --cc=bhe@redhat.com \
    --cc=caoj.fnst@cn.fujitsu.com \
    --cc=douly.fnst@cn.fujitsu.com \
    --cc=hpa@zytor.com \
    --cc=indou.takao@jp.fujitsu.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.