From: Eduardo Habkost <ehabkost@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: haozhong.zhang@intel.com, xiaoguangrong.eric@gmail.com,
mst@redhat.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org,
john.ji@intel.com, Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] pc: acpi: revert back to 1 SRAT entry for hotpluggable area
Date: Thu, 23 Aug 2018 14:25:01 -0300 [thread overview]
Message-ID: <20180823172501.GM3778@localhost.localdomain> (raw)
In-Reply-To: <20180823101406.06320b35@redhat.com>
On Thu, Aug 23, 2018 at 10:14:06AM +0200, Igor Mammedov wrote:
> On Wed, 22 Aug 2018 15:01:12 -0300
> Eduardo Habkost <ehabkost@redhat.com> wrote:
[...]
> > However, have you considered keeping adding separate entries for
> > NVDIMM devices only (so we follow the spec), but add a single
> > (numa_nodes-1, MEM_AFFINITY_HOTPLUGGABLE|MEM_AFFINITY_ENABLED)
> > entry to the rest?
> Indeed, I did. It doesn't work either.
When exactly it didn't work? Did nvdimm + memory hotplug ever
worked together on Windows guests?
For all the other cases there should be absolutely no difference:
nvdimm users would still get a spec-compliant SRAT table (like on
QEMU 3.0).
Memory hotplug users w/o nvdimm would get the same ACPI table
that they would get after applying this patch (i.e. the one we
had before commit 848a1cc1e ("hw/acpi-build: build SRAT memory
affinity structures for DIMM devices").
--
Eduardo
next prev parent reply other threads:[~2018-08-23 17:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 9:46 [Qemu-devel] [PATCH] pc: acpi: revert back to 1 SRAT entry for hotpluggable area Igor Mammedov
2018-08-22 10:06 ` Laszlo Ersek
2018-08-22 13:05 ` Igor Mammedov
2018-08-22 18:01 ` Eduardo Habkost
2018-08-23 8:14 ` Igor Mammedov
2018-08-23 17:25 ` Eduardo Habkost [this message]
2018-08-24 8:03 ` Igor Mammedov
2018-08-24 10:46 ` Eduardo Habkost
2018-08-23 9:01 ` Yu Zhang
2018-08-23 12:34 ` Igor Mammedov
2018-08-24 7:54 ` Yu Zhang
2018-08-22 18:12 ` Eduardo Habkost
2018-09-07 20:44 ` Michael S. Tsirkin
2018-09-10 8:19 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180823172501.GM3778@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=haozhong.zhang@intel.com \
--cc=imammedo@redhat.com \
--cc=john.ji@intel.com \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.