* [PATCH] drm/i915: Free write_buf that we allocated with kzalloc.
@ 2018-08-23 20:51 ` Rodrigo Vivi
0 siblings, 0 replies; 7+ messages in thread
From: Rodrigo Vivi @ 2018-08-23 20:51 UTC (permalink / raw)
To: intel-gfx; +Cc: Sean Paul, stable, Rodrigo Vivi
We use kzalloc to allocate the write_buf that we use for
i2c transfer on hdcp write. But it seems that we are forgetting
to free the memory that is not needed after i2c transfer is
completed.
Reported-by: Brian J Wood <brian.j.wood@intel.com>
Fixes: 2320175feb74 ("drm/i915: Implement HDCP for HDMI")
Cc: Ramalingam C <ramalingam.c@intel.com>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: <stable@vger.kernel.org> # v4.17+
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/i915/intel_hdmi.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index 8363fbd18ee8..a1799b5c12bb 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -943,8 +943,12 @@ static int intel_hdmi_hdcp_write(struct intel_digital_port *intel_dig_port,
ret = i2c_transfer(adapter, &msg, 1);
if (ret == 1)
- return 0;
- return ret >= 0 ? -EIO : ret;
+ ret = 0;
+ else if (ret >= 0)
+ ret = -EIO;
+
+ kfree(write_buf);
+ return ret;
}
static
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] drm/i915: Free write_buf that we allocated with kzalloc.
@ 2018-08-23 20:51 ` Rodrigo Vivi
0 siblings, 0 replies; 7+ messages in thread
From: Rodrigo Vivi @ 2018-08-23 20:51 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi, Ramalingam C, Sean Paul, Jani Nikula, stable
We use kzalloc to allocate the write_buf that we use for
i2c transfer on hdcp write. But it seems that we are forgetting
to free the memory that is not needed after i2c transfer is
completed.
Reported-by: Brian J Wood <brian.j.wood@intel.com>
Fixes: 2320175feb74 ("drm/i915: Implement HDCP for HDMI")
Cc: Ramalingam C <ramalingam.c@intel.com>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: <stable@vger.kernel.org> # v4.17+
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/i915/intel_hdmi.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index 8363fbd18ee8..a1799b5c12bb 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -943,8 +943,12 @@ static int intel_hdmi_hdcp_write(struct intel_digital_port *intel_dig_port,
ret = i2c_transfer(adapter, &msg, 1);
if (ret == 1)
- return 0;
- return ret >= 0 ? -EIO : ret;
+ ret = 0;
+ else if (ret >= 0)
+ ret = -EIO;
+
+ kfree(write_buf);
+ return ret;
}
static
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Free write_buf that we allocated with kzalloc.
2018-08-23 20:51 ` Rodrigo Vivi
(?)
@ 2018-08-23 21:16 ` Patchwork
-1 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-08-23 21:16 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Free write_buf that we allocated with kzalloc.
URL : https://patchwork.freedesktop.org/series/48642/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4702 -> Patchwork_10001 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/48642/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10001:
=== IGT changes ===
==== Warnings ====
{igt@pm_rpm@module-reload}:
fi-byt-n2820: DMESG-FAIL -> DMESG-WARN
== Known issues ==
Here are the changes found in Patchwork_10001 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: PASS -> DMESG-FAIL (fdo#102614)
{fi-byt-clapper}: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
{fi-byt-clapper}: PASS -> FAIL (fdo#107362, fdo#103191)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
== Participating hosts (53 -> 48) ==
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4702 -> Patchwork_10001
CI_DRM_4702: 0349bfb08204a6b44f16551c2be3b58563ff73d2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4608: 94ebd21177feedf03e8f6dd1e73dca1a6ec7a0ac @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10001: e6dbb40685d5383083f6d66c1bd3df591a969639 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
e6dbb40685d5 drm/i915: Free write_buf that we allocated with kzalloc.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10001/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915: Free write_buf that we allocated with kzalloc.
2018-08-23 20:51 ` Rodrigo Vivi
(?)
(?)
@ 2018-08-23 22:03 ` Patchwork
-1 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-08-23 22:03 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Free write_buf that we allocated with kzalloc.
URL : https://patchwork.freedesktop.org/series/48642/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4702_full -> Patchwork_10001_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10001_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10001_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10001_full:
=== IGT changes ===
==== Warnings ====
igt@kms_chv_cursor_fail@pipe-b-128x128-left-edge:
shard-snb: PASS -> SKIP +5
igt@kms_cursor_legacy@cursorb-vs-flipa-toggle:
shard-hsw: SKIP -> PASS
== Known issues ==
Here are the changes found in Patchwork_10001_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_ctx_isolation@vcs1-s3:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
igt@gem_exec_await@wide-contexts:
shard-apl: PASS -> FAIL (fdo#105900, fdo#106680)
igt@gem_ppgtt@blt-vs-render-ctxn:
shard-kbl: PASS -> INCOMPLETE (fdo#106023, fdo#103665)
igt@pm_rpm@system-suspend:
shard-kbl: PASS -> INCOMPLETE (fdo#103665, fdo#107556)
==== Possible fixes ====
igt@drv_selftest@live_hangcheck:
shard-apl: DMESG-FAIL (fdo#106560, fdo#106947) -> PASS
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105363) -> PASS
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
fdo#106947 https://bugs.freedesktop.org/show_bug.cgi?id=106947
fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4702 -> Patchwork_10001
CI_DRM_4702: 0349bfb08204a6b44f16551c2be3b58563ff73d2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4608: 94ebd21177feedf03e8f6dd1e73dca1a6ec7a0ac @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10001: e6dbb40685d5383083f6d66c1bd3df591a969639 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10001/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: Free write_buf that we allocated with kzalloc.
2018-08-23 20:51 ` Rodrigo Vivi
@ 2018-08-23 22:25 ` Chris Wilson
-1 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2018-08-23 22:25 UTC (permalink / raw)
To: intel-gfx; +Cc: Sean Paul, stable, Rodrigo Vivi
Quoting Rodrigo Vivi (2018-08-23 21:51:36)
> We use kzalloc to allocate the write_buf that we use for
> i2c transfer on hdcp write. But it seems that we are forgetting
> to free the memory that is not needed after i2c transfer is
> completed.
>
> Reported-by: Brian J Wood <brian.j.wood@intel.com>
> Fixes: 2320175feb74 ("drm/i915: Implement HDCP for HDMI")
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Cc: Sean Paul <seanpaul@chromium.org>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: <stable@vger.kernel.org> # v4.17+
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: Free write_buf that we allocated with kzalloc.
@ 2018-08-23 22:25 ` Chris Wilson
0 siblings, 0 replies; 7+ messages in thread
From: Chris Wilson @ 2018-08-23 22:25 UTC (permalink / raw)
To: Rodrigo Vivi, intel-gfx; +Cc: Sean Paul, stable, Rodrigo Vivi
Quoting Rodrigo Vivi (2018-08-23 21:51:36)
> We use kzalloc to allocate the write_buf that we use for
> i2c transfer on hdcp write. But it seems that we are forgetting
> to free the memory that is not needed after i2c transfer is
> completed.
>
> Reported-by: Brian J Wood <brian.j.wood@intel.com>
> Fixes: 2320175feb74 ("drm/i915: Implement HDCP for HDMI")
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Cc: Sean Paul <seanpaul@chromium.org>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: <stable@vger.kernel.org> # v4.17+
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915: Free write_buf that we allocated with kzalloc.
2018-08-23 22:25 ` Chris Wilson
(?)
@ 2018-08-23 22:48 ` Rodrigo Vivi
-1 siblings, 0 replies; 7+ messages in thread
From: Rodrigo Vivi @ 2018-08-23 22:48 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx, Sean Paul, stable
On Thu, Aug 23, 2018 at 11:25:42PM +0100, Chris Wilson wrote:
> Quoting Rodrigo Vivi (2018-08-23 21:51:36)
> > We use kzalloc to allocate the write_buf that we use for
> > i2c transfer on hdcp write. But it seems that we are forgetting
> > to free the memory that is not needed after i2c transfer is
> > completed.
> >
> > Reported-by: Brian J Wood <brian.j.wood@intel.com>
> > Fixes: 2320175feb74 ("drm/i915: Implement HDCP for HDMI")
> > Cc: Ramalingam C <ramalingam.c@intel.com>
> > Cc: Sean Paul <seanpaul@chromium.org>
> > Cc: Jani Nikula <jani.nikula@linux.intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: <stable@vger.kernel.org> # v4.17+
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
thanks. pushed to dinq.
> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-08-24 1:57 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-23 20:51 [PATCH] drm/i915: Free write_buf that we allocated with kzalloc Rodrigo Vivi
2018-08-23 20:51 ` Rodrigo Vivi
2018-08-23 21:16 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-08-23 22:03 ` ✓ Fi.CI.IGT: " Patchwork
2018-08-23 22:25 ` [Intel-gfx] [PATCH] " Chris Wilson
2018-08-23 22:25 ` Chris Wilson
2018-08-23 22:48 ` Rodrigo Vivi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.