All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Paul Durrant <paul.durrant@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] xenforeignmemory: work around bug in older privcmd
Date: Fri, 24 Aug 2018 14:24:38 +0100	[thread overview]
Message-ID: <20180824132438.m3ic2xonpy4eaf46@citrix.com> (raw)
In-Reply-To: <20180824121626.27261-1-paul.durrant@citrix.com>

On Fri, Aug 24, 2018 at 01:16:26PM +0100, Paul Durrant wrote:
> Versions of linux privcmd prior to commit dc9eab6fd94d ("return -ENOTTY
> for unimplemented IOCTLs") will return -EINVAL rather than the conventional
> -ENOTTY for unimplemented codes. This breaks the error path in
> libxenforeignmemory resource mapping, which only translates ENOTTY into
> EOPNOTSUPP to inform callers of the need to use an alternative (legacy)
> mechanism.
> 
> This patch adds a new 'unimplemented' [1] ioctl code into the local
> privcmd header which is then used to probe for the appropriate errno to
> translate in the resource mapping error path
> 
> [1] this is a code that has, so far, never been used in any version of
>     privcmd and will be added to future versions of the header in the
>     linux source, to make sure it stays unimplemented.
> 
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> ---

Acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-08-24 13:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-24 12:16 [PATCH] xenforeignmemory: work around bug in older privcmd Paul Durrant
2018-08-24 13:24 ` Wei Liu [this message]
2018-08-24 15:16 ` Ian Jackson
2018-08-27  9:04 ` Jan Beulich
2018-08-27  9:11   ` Wei Liu
2018-08-28 14:12 ` Andrew Cooper
2018-08-28 14:20   ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180824132438.m3ic2xonpy4eaf46@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=paul.durrant@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.