Re: [PATCH] xenforeignmemory: work around bug in older privcmd

From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Paul Durrant <paul.durrant@citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH] xenforeignmemory: work around bug in older privcmd
Date: Tue, 28 Aug 2018 15:20:12 +0100	[thread overview]
Message-ID: <20180828142012.cprvk7r76i2psbbj@citrix.com> (raw)
In-Reply-To: <fcd947b7-844d-2ddf-71ee-45dfd6cf4566@citrix.com>

On Tue, Aug 28, 2018 at 03:12:32PM +0100, Andrew Cooper wrote:
> On 24/08/18 13:16, Paul Durrant wrote:
> > diff --git a/tools/libs/foreignmemory/linux.c b/tools/libs/foreignmemory/linux.c
> > index 3686cf41e0..0368aa09f4 100644
> > --- a/tools/libs/foreignmemory/linux.c
> > +++ b/tools/libs/foreignmemory/linux.c
> > @@ -53,6 +53,23 @@ int osdep_xenforeignmemory_open(xenforeignmemory_handle *fmem)
> >          return -1;
> >      }
> >  
> > +    /*
> > +     * Older versions of privcmd return -EINVAL for unimplemented ioctls
> > +     * so we need to probe for the errno to use rather than just using
> > +     * the conventional ENOTTY.
> > +     */
> > +    if ( ioctl(fd, IOCTL_PRIVCMD_UNIMPLEMENTED, NULL) >= 0 )
> > +    {
> > +        xtl_log(fmem->logger, XTL_ERROR, -1, "xenforeignmemory",
> > +                "privcmd ioctl should not be implemented");
> 
> This error path leaks fd.

Patch sent.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel