From: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Felix Fietkau <nbd-Vt+b4OUoWG0@public.gmane.org>
Cc: linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Lorenzo Bianconi
<lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 02/17] mt76: rename mt76x2_regs.h
Date: Sat, 25 Aug 2018 13:31:51 +0200 [thread overview]
Message-ID: <20180825113149.GA13833@redhat.com> (raw)
In-Reply-To: <2172355a-0703-e432-96cb-fba2383c3890-Vt+b4OUoWG0@public.gmane.org>
On Sat, Aug 25, 2018 at 11:00:39AM +0200, Felix Fietkau wrote:
> On 2018-08-24 13:15, Stanislaw Gruszka wrote:
> > MAC registers are the same for mt76x0 and mt76x2. Rename mt76x2_regs.h
> > file to reflect that.
> >
> > Signed-off-by: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > ---
> > drivers/net/wireless/mediatek/mt76/mt76x2.h | 2 +-
> > drivers/net/wireless/mediatek/mt76/mt76x2_regs.h | 619 -----------------------
> > drivers/net/wireless/mediatek/mt76/mt76xx_regs.h | 619 +++++++++++++++++++++++
> I think mt76xx_regs.h is named too generic. MT7603, MT7628, MT7615 and
> all newer chips use a completely different register layout.
> I'd prefer to stick with mt76x2_regs for now and use it for x0 as well.
I thought about that too, but choose it will be better to have some
prefix that will indicate the function/structure/header is shared between
the x0 and x2 drivers to not confuse mt76x2 code that is mt76x2 only
and one that is shared.
I choose mt76xx name, considered mt76 to be generic prefix shared also
between old and new chips. But yeah this mt76xx name also "contains" new
chips. How about mt76old_ or mt76og_ (old generation) ?
Thanks
Stanislaw
WARNING: multiple messages have this Message-ID (diff)
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 02/17] mt76: rename mt76x2_regs.h
Date: Sat, 25 Aug 2018 13:31:51 +0200 [thread overview]
Message-ID: <20180825113149.GA13833@redhat.com> (raw)
In-Reply-To: <2172355a-0703-e432-96cb-fba2383c3890@nbd.name>
On Sat, Aug 25, 2018 at 11:00:39AM +0200, Felix Fietkau wrote:
> On 2018-08-24 13:15, Stanislaw Gruszka wrote:
> > MAC registers are the same for mt76x0 and mt76x2. Rename mt76x2_regs.h
> > file to reflect that.
> >
> > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> > ---
> > drivers/net/wireless/mediatek/mt76/mt76x2.h | 2 +-
> > drivers/net/wireless/mediatek/mt76/mt76x2_regs.h | 619 -----------------------
> > drivers/net/wireless/mediatek/mt76/mt76xx_regs.h | 619 +++++++++++++++++++++++
> I think mt76xx_regs.h is named too generic. MT7603, MT7628, MT7615 and
> all newer chips use a completely different register layout.
> I'd prefer to stick with mt76x2_regs for now and use it for x0 as well.
I thought about that too, but choose it will be better to have some
prefix that will indicate the function/structure/header is shared between
the x0 and x2 drivers to not confuse mt76x2 code that is mt76x2 only
and one that is shared.
I choose mt76xx name, considered mt76 to be generic prefix shared also
between old and new chips. But yeah this mt76xx name also "contains" new
chips. How about mt76old_ or mt76og_ (old generation) ?
Thanks
Stanislaw
next prev parent reply other threads:[~2018-08-25 11:31 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 11:15 [PATCH 00/17] mt76 patches 2018-08-24 Stanislaw Gruszka
2018-08-24 11:15 ` Stanislaw Gruszka
[not found] ` <1535109321-17126-1-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-08-24 11:15 ` [PATCH 01/17] mt76: unify wait_for_mac Stanislaw Gruszka
2018-08-24 11:15 ` Stanislaw Gruszka
2018-08-24 11:15 ` [PATCH 02/17] mt76: rename mt76x2_regs.h Stanislaw Gruszka
2018-08-24 11:15 ` Stanislaw Gruszka
[not found] ` <1535109321-17126-3-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-08-25 9:00 ` Felix Fietkau
2018-08-25 9:00 ` Felix Fietkau
[not found] ` <2172355a-0703-e432-96cb-fba2383c3890-Vt+b4OUoWG0@public.gmane.org>
2018-08-25 11:31 ` Stanislaw Gruszka [this message]
2018-08-25 11:31 ` Stanislaw Gruszka
[not found] ` <20180825113149.GA13833-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-08-25 11:56 ` Felix Fietkau
2018-08-25 11:56 ` Felix Fietkau
[not found] ` <f5537708-b3b6-1d0c-1461-7a08ca48b51b-Vt+b4OUoWG0@public.gmane.org>
2018-08-25 14:44 ` Stanislaw Gruszka
2018-08-25 14:44 ` Stanislaw Gruszka
2018-08-24 11:15 ` [PATCH 03/17] mt76: merge mt76x0/regs.h into mt76xx_regs.h Stanislaw Gruszka
2018-08-24 11:15 ` Stanislaw Gruszka
2018-08-24 11:15 ` [PATCH 04/17] mt76: create new mt76xx-lib module for common mt76x{0,2} code Stanislaw Gruszka
2018-08-24 11:15 ` Stanislaw Gruszka
[not found] ` <1535109321-17126-5-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-08-25 9:02 ` Felix Fietkau
2018-08-25 9:02 ` Felix Fietkau
2018-08-24 11:15 ` [PATCH 05/17] mt76: fix mt76xx-lib module license Stanislaw Gruszka
2018-08-24 11:15 ` Stanislaw Gruszka
2018-08-24 11:15 ` [PATCH 06/17] mt76: unify mac_get_key_info Stanislaw Gruszka
2018-08-24 11:15 ` Stanislaw Gruszka
2018-08-24 11:15 ` [PATCH 07/17] mt76: add helpers for register access with mt76_dev struct Stanislaw Gruszka
2018-08-24 11:15 ` Stanislaw Gruszka
2018-08-24 11:15 ` [PATCH 08/17] mt76: unify mac_shared_key_setup Stanislaw Gruszka
2018-08-24 11:15 ` Stanislaw Gruszka
2018-08-24 11:15 ` [PATCH 09/17] mt76: unify mt76xx_mac_wcid_set_key Stanislaw Gruszka
2018-08-24 11:15 ` Stanislaw Gruszka
2018-08-24 11:15 ` [PATCH 10/17] mt76: unify mac_wcid_setup Stanislaw Gruszka
2018-08-24 11:15 ` Stanislaw Gruszka
2018-08-24 11:15 ` [PATCH 11/17] mt76: use mac_wcid_set_drop in mt76x0 Stanislaw Gruszka
2018-08-24 11:15 ` Stanislaw Gruszka
2018-08-24 11:15 ` [PATCH 12/17] mt76x0: use mt76_wcid_free " Stanislaw Gruszka
2018-08-24 11:15 ` Stanislaw Gruszka
2018-08-24 11:15 ` [PATCH 13/17] mt76: unify mt76xx_vif struct Stanislaw Gruszka
2018-08-24 11:15 ` Stanislaw Gruszka
2018-08-24 11:15 ` [PATCH 14/17] mt76: unify sta stucture part 1 Stanislaw Gruszka
2018-08-24 11:15 ` Stanislaw Gruszka
2018-08-24 11:15 ` [PATCH 15/17] mt76: unify sta structure part 2 Stanislaw Gruszka
2018-08-24 11:15 ` Stanislaw Gruszka
2018-08-24 11:15 ` [PATCH 16/17] mt76x0: initalize custom tx queues Stanislaw Gruszka
2018-08-24 11:15 ` Stanislaw Gruszka
2018-08-24 11:15 ` [PATCH 17/17] mt76x0: use mt76xx_sta and mt76xx_tx_status Stanislaw Gruszka
2018-08-24 11:15 ` Stanislaw Gruszka
2018-08-24 11:26 ` [PATCH 00/17] mt76 patches 2018-08-24 Stanislaw Gruszka
2018-08-24 11:26 ` Stanislaw Gruszka
2018-08-24 15:15 ` Lorenzo Bianconi
2018-08-24 15:15 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180825113149.GA13833@redhat.com \
--to=sgruszka-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=nbd-Vt+b4OUoWG0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.