From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/1] ARM: dts: imx6ull: keep IMX6UL_ prefix for signals on both i.MX6UL and i.MX6ULL
Date: Mon, 27 Aug 2018 16:00:11 +0800 [thread overview]
Message-ID: <20180827080008.GL3850@dragon> (raw)
In-Reply-To: <20180822113803.20965-1-sebastien.szymanski@armadeus.com>
On Wed, Aug 22, 2018 at 01:38:03PM +0200, S?bastien Szymanski wrote:
> Signals available on both i.MX6UL and i.MX6ULL should have the same name
> because it is the case of all others common signals, it avoids to make
> mistakes (use the wrong ones) and it makes writing device tree files
> less complicated. For example:
>
> imx6ul-imx6ull-board.dtsi:
> ...
> pinctrl_uart5: uart5grp {
> fsl,pins = <
> MX6UL_PAD_UART5_TX_DATA__UART5_DCE_TX 0x1b0b1
> MX6UL_PAD_UART5_RX_DATA__UART5_DCE_RX 0x1b0b1
> >;
> };
>
> imx6ul-board.dts:
> #include <imx6ul.dtsi>
> #include <imx6ul-imx6ull-board.dtsi>
> ...
>
> imx6ull-board.dts:
> #include <imx6ull.dtsi>
> #include <imx6ul-imx6ull-board.dtsi>
> ...
>
> Without this patch, the imx6ull-board.dtb will use
> MX6UL_PAD_UART5_RX_DATA__UART5_DCE_RX instead of
> MX6ULL_PAD_UART5_RX_DATA__UART5_DCE_RX and the uart5 will be
> misconfigured.
>
> Signed-off-by: S?bastien Szymanski <sebastien.szymanski@armadeus.com>
Rob and Fabio gave their review/ack tags on v1, so I applied the patch
with the tags collected.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: "Sébastien Szymanski" <sebastien.szymanski@armadeus.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Sascha Hauer <s.hauer@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/1] ARM: dts: imx6ull: keep IMX6UL_ prefix for signals on both i.MX6UL and i.MX6ULL
Date: Mon, 27 Aug 2018 16:00:11 +0800 [thread overview]
Message-ID: <20180827080008.GL3850@dragon> (raw)
In-Reply-To: <20180822113803.20965-1-sebastien.szymanski@armadeus.com>
On Wed, Aug 22, 2018 at 01:38:03PM +0200, Sébastien Szymanski wrote:
> Signals available on both i.MX6UL and i.MX6ULL should have the same name
> because it is the case of all others common signals, it avoids to make
> mistakes (use the wrong ones) and it makes writing device tree files
> less complicated. For example:
>
> imx6ul-imx6ull-board.dtsi:
> ...
> pinctrl_uart5: uart5grp {
> fsl,pins = <
> MX6UL_PAD_UART5_TX_DATA__UART5_DCE_TX 0x1b0b1
> MX6UL_PAD_UART5_RX_DATA__UART5_DCE_RX 0x1b0b1
> >;
> };
>
> imx6ul-board.dts:
> #include <imx6ul.dtsi>
> #include <imx6ul-imx6ull-board.dtsi>
> ...
>
> imx6ull-board.dts:
> #include <imx6ull.dtsi>
> #include <imx6ul-imx6ull-board.dtsi>
> ...
>
> Without this patch, the imx6ull-board.dtb will use
> MX6UL_PAD_UART5_RX_DATA__UART5_DCE_RX instead of
> MX6ULL_PAD_UART5_RX_DATA__UART5_DCE_RX and the uart5 will be
> misconfigured.
>
> Signed-off-by: Sébastien Szymanski <sebastien.szymanski@armadeus.com>
Rob and Fabio gave their review/ack tags on v1, so I applied the patch
with the tags collected.
Shawn
next prev parent reply other threads:[~2018-08-27 8:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 11:38 [PATCH v2 1/1] ARM: dts: imx6ull: keep IMX6UL_ prefix for signals on both i.MX6UL and i.MX6ULL Sébastien Szymanski
2018-08-22 11:38 ` Sébastien Szymanski
2018-08-27 8:00 ` Shawn Guo [this message]
2018-08-27 8:00 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180827080008.GL3850@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.