From: Johan Hovold <johan@kernel.org>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: Johan Hovold <johan@kernel.org>,
Romain Izard <romain.izard.pro@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>, Lars Melin <larsm17@gmail.com>
Subject: option: Do not try to bind to ADB interfaces
Date: Wed, 29 Aug 2018 09:56:10 +0200 [thread overview]
Message-ID: <20180829075610.GE28861@localhost> (raw)
On Mon, Aug 27, 2018 at 06:15:52PM +0200, Bjørn Mork wrote:
> Johan Hovold <johan@kernel.org> writes:
>
> > It would allow for simpler device-id entries, at least when ADB is the
> > only blacklisted interface, and may enable ADB for some older entries.
> >
> > On the other hand, interface class 0xff is indeed supposed to be vendor
> > specific as Lars and Greg pointed out, and with status quo we don't
> > cause any regressions. If ADB isn't currently available for some device
> > due to option binding to that interface, we'll just blacklist it as soon
> > we get a report.
> >
> > So personally I'm not sure it's worth it, but I don't have a strong
> > opinion on the matter either.
>
> +1
>
> The adb userspace application is also free to unbind any conflicting
> driver, so I don't think blacklisting is strictly necessary. Except to
> prevent any confusion caused by bogus ttyUSBx devices.
Right. Let's leave things as they are then.
Thanks,
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: Johan Hovold <johan@kernel.org>,
Romain Izard <romain.izard.pro@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>, Lars Melin <larsm17@gmail.com>
Subject: Re: [PATCH] option: Do not try to bind to ADB interfaces
Date: Wed, 29 Aug 2018 09:56:10 +0200 [thread overview]
Message-ID: <20180829075610.GE28861@localhost> (raw)
In-Reply-To: <87r2ijdbuv.fsf@miraculix.mork.no>
On Mon, Aug 27, 2018 at 06:15:52PM +0200, Bjørn Mork wrote:
> Johan Hovold <johan@kernel.org> writes:
>
> > It would allow for simpler device-id entries, at least when ADB is the
> > only blacklisted interface, and may enable ADB for some older entries.
> >
> > On the other hand, interface class 0xff is indeed supposed to be vendor
> > specific as Lars and Greg pointed out, and with status quo we don't
> > cause any regressions. If ADB isn't currently available for some device
> > due to option binding to that interface, we'll just blacklist it as soon
> > we get a report.
> >
> > So personally I'm not sure it's worth it, but I don't have a strong
> > opinion on the matter either.
>
> +1
>
> The adb userspace application is also free to unbind any conflicting
> driver, so I don't think blacklisting is strictly necessary. Except to
> prevent any confusion caused by bogus ttyUSBx devices.
Right. Let's leave things as they are then.
Thanks,
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: Johan Hovold <johan@kernel.org>,
Romain Izard <romain.izard.pro@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>, Lars Melin <larsm17@gmail.com>
Subject: Re: [PATCH] option: Do not try to bind to ADB interfaces
Date: Wed, 29 Aug 2018 09:56:10 +0200 [thread overview]
Message-ID: <20180829075610.GE28861@localhost> (raw)
In-Reply-To: <87r2ijdbuv.fsf@miraculix.mork.no>
On Mon, Aug 27, 2018 at 06:15:52PM +0200, Bj�rn Mork wrote:
> Johan Hovold <johan@kernel.org> writes:
>
> > It would allow for simpler device-id entries, at least when ADB is the
> > only blacklisted interface, and may enable ADB for some older entries.
> >
> > On the other hand, interface class 0xff is indeed supposed to be vendor
> > specific as Lars and Greg pointed out, and with status quo we don't
> > cause any regressions. If ADB isn't currently available for some device
> > due to option binding to that interface, we'll just blacklist it as soon
> > we get a report.
> >
> > So personally I'm not sure it's worth it, but I don't have a strong
> > opinion on the matter either.
>
> +1
>
> The adb userspace application is also free to unbind any conflicting
> driver, so I don't think blacklisting is strictly necessary. Except to
> prevent any confusion caused by bogus ttyUSBx devices.
Right. Let's leave things as they are then.
Thanks,
Johan
next reply other threads:[~2018-08-29 7:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 7:56 Johan Hovold [this message]
2018-08-29 7:56 ` [PATCH] option: Do not try to bind to ADB interfaces Johan Hovold
2018-08-29 7:56 ` Johan Hovold
-- strict thread matches above, loose matches on Subject: below --
2018-08-27 16:15 Bjørn Mork
2018-08-27 16:15 ` [PATCH] " Bjørn Mork
2018-08-27 13:28 Johan Hovold
2018-08-27 13:28 ` [PATCH] " Johan Hovold
2018-08-27 13:28 ` Johan Hovold
2018-07-23 16:45 Romain Izard
2018-07-23 16:45 ` [PATCH] " Romain Izard
2018-07-23 16:37 Romain Izard
2018-07-23 16:37 ` [PATCH] " Romain Izard
2018-07-23 15:15 Lars Melin
2018-07-23 15:15 ` [PATCH] " Lars Melin
2018-07-23 14:08 Greg Kroah-Hartman
2018-07-23 14:08 ` [PATCH] " Greg Kroah-Hartman
2018-07-23 14:02 Romain Izard
2018-07-23 14:02 ` [PATCH] " Romain Izard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180829075610.GE28861@localhost \
--to=johan@kernel.org \
--cc=bjorn@mork.no \
--cc=gregkh@linuxfoundation.org \
--cc=larsm17@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=romain.izard.pro@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.