From: Guillaume Nault <g.nault@alphalink.fr>
To: Arnd Bergmann <arnd@arndb.de>
Cc: paulus@samba.org, linux-ppp@vger.kernel.org,
netdev@vger.kernel.org, mitch@sfgoth.com, mostrows@earthlink.net,
jchapman@katalix.com, xeb@mail.ru, davem@davemloft.net,
viro@zeniv.linux.org.uk, y2038@lists.linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 4/5] ppp: move PPPIOCSPASS32/PPPIOCSACTIVE32 to ppp_generic.c
Date: Thu, 30 Aug 2018 11:05:04 +0000 [thread overview]
Message-ID: <20180830110504.GA19457@alphalink.fr> (raw)
In-Reply-To: <20180829140409.833488-4-arnd@arndb.de>
On Wed, Aug 29, 2018 at 04:03:29PM +0200, Arnd Bergmann wrote:
> PPPIOCSPASS and PPPIOCSACTIVE are implemented in ppp_generic and isdn_ppp,
> but the latter one doesn't work for compat mode in general, so we can
> move these two into the generic code.
>
> Again, the best implementation I could come up with was to merge
> the compat handling into the regular ppp_ioctl() function and
> treating all ioctl commands as compatible.
>
Acked-by: Guillaume Nault <g.nault@alphalink.fr>
WARNING: multiple messages have this Message-ID (diff)
From: Guillaume Nault <g.nault@alphalink.fr>
To: Arnd Bergmann <arnd@arndb.de>
Cc: paulus@samba.org, linux-ppp@vger.kernel.org,
netdev@vger.kernel.org, mitch@sfgoth.com, mostrows@earthlink.net,
jchapman@katalix.com, xeb@mail.ru, davem@davemloft.net,
viro@zeniv.linux.org.uk, y2038@lists.linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 4/5] ppp: move PPPIOCSPASS32/PPPIOCSACTIVE32 to ppp_generic.c
Date: Thu, 30 Aug 2018 13:05:04 +0200 [thread overview]
Message-ID: <20180830110504.GA19457@alphalink.fr> (raw)
In-Reply-To: <20180829140409.833488-4-arnd@arndb.de>
On Wed, Aug 29, 2018 at 04:03:29PM +0200, Arnd Bergmann wrote:
> PPPIOCSPASS and PPPIOCSACTIVE are implemented in ppp_generic and isdn_ppp,
> but the latter one doesn't work for compat mode in general, so we can
> move these two into the generic code.
>
> Again, the best implementation I could come up with was to merge
> the compat handling into the regular ppp_ioctl() function and
> treating all ioctl commands as compatible.
>
Acked-by: Guillaume Nault <g.nault@alphalink.fr>
next prev parent reply other threads:[~2018-08-30 11:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 14:03 [PATCH net-next 1/5] pppoe: fix PPPOEIOCSFWD compat handling Arnd Bergmann
2018-08-29 14:03 ` Arnd Bergmann
2018-08-29 14:03 ` [PATCH net-next 2/5] ppp: move simple ioctl compat handling out of fs_compat_ioctl.c Arnd Bergmann
2018-08-29 14:03 ` Arnd Bergmann
2018-08-29 14:03 ` [PATCH net-next 3/5] ppp: move PPPIOCSCOMPRESS32 to ppp-generic.c Arnd Bergmann
2018-08-29 14:03 ` Arnd Bergmann
2018-08-30 11:04 ` Guillaume Nault
2018-08-30 11:04 ` Guillaume Nault
2018-08-29 14:03 ` [PATCH net-next 4/5] ppp: move PPPIOCSPASS32/PPPIOCSACTIVE32 to ppp_generic.c Arnd Bergmann
2018-08-29 14:03 ` Arnd Bergmann
2018-08-30 11:05 ` Guillaume Nault [this message]
2018-08-30 11:05 ` Guillaume Nault
2018-08-29 14:03 ` [PATCH net-next 5/5] ppp: handle PPPIOCGIDLE for 64-bit time_t Arnd Bergmann
2018-08-29 14:03 ` Arnd Bergmann
2018-08-30 11:06 ` Guillaume Nault
2018-08-30 11:06 ` Guillaume Nault
2018-08-30 11:47 ` Arnd Bergmann
2018-08-30 11:47 ` Arnd Bergmann
2018-08-30 11:04 ` [PATCH net-next 1/5] pppoe: fix PPPOEIOCSFWD compat handling Guillaume Nault
2018-08-30 11:04 ` Guillaume Nault
2018-08-30 11:54 ` Arnd Bergmann
2018-08-30 11:54 ` Arnd Bergmann
2018-08-30 13:09 ` Guillaume Nault
2018-08-30 13:09 ` Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180830110504.GA19457@alphalink.fr \
--to=g.nault@alphalink.fr \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=jchapman@katalix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=mitch@sfgoth.com \
--cc=mostrows@earthlink.net \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xeb@mail.ru \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.