From: Balbir Singh <bsingharora@gmail.com>
To: jglisse@redhat.com
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Ralph Campbell <rcampbell@nvidia.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 3/7] mm/hmm: fix race between hmm_mirror_unregister() and mmu_notifier callback
Date: Fri, 31 Aug 2018 00:14:46 +1000 [thread overview]
Message-ID: <20180830141446.GB28695@350D> (raw)
In-Reply-To: <20180824192549.30844-4-jglisse@redhat.com>
On Fri, Aug 24, 2018 at 03:25:45PM -0400, jglisse@redhat.com wrote:
> From: Ralph Campbell <rcampbell@nvidia.com>
>
> In hmm_mirror_unregister(), mm->hmm is set to NULL and then
> mmu_notifier_unregister_no_release() is called. That creates a small
> window where mmu_notifier can call mmu_notifier_ops with mm->hmm equal
> to NULL. Fix this by first unregistering mmu notifier callbacks and
> then setting mm->hmm to NULL.
>
> Similarly in hmm_register(), set mm->hmm before registering mmu_notifier
> callbacks so callback functions always see mm->hmm set.
>
> Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
> Reviewed-by: Jerome Glisse <jglisse@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: stable@vger.kernel.org
Reviewed-by: Balbir Singh <bsingharora@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <bsingharora@gmail.com>
To: jglisse@redhat.com
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Ralph Campbell <rcampbell@nvidia.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 3/7] mm/hmm: fix race between hmm_mirror_unregister() and mmu_notifier callback
Date: Fri, 31 Aug 2018 00:14:46 +1000 [thread overview]
Message-ID: <20180830141446.GB28695@350D> (raw)
In-Reply-To: <20180824192549.30844-4-jglisse@redhat.com>
On Fri, Aug 24, 2018 at 03:25:45PM -0400, jglisse@redhat.com wrote:
> From: Ralph Campbell <rcampbell@nvidia.com>
>
> In hmm_mirror_unregister(), mm->hmm is set to NULL and then
> mmu_notifier_unregister_no_release() is called. That creates a small
> window where mmu_notifier can call mmu_notifier_ops with mm->hmm equal
> to NULL. Fix this by first unregistering mmu notifier callbacks and
> then setting mm->hmm to NULL.
>
> Similarly in hmm_register(), set mm->hmm before registering mmu_notifier
> callbacks so callback functions always see mm->hmm set.
>
> Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
> Reviewed-by: Jérôme Glisse <jglisse@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: stable@vger.kernel.org
Reviewed-by: Balbir Singh <bsingharora@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <bsingharora@gmail.com>
To: jglisse@redhat.com
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Ralph Campbell <rcampbell@nvidia.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 3/7] mm/hmm: fix race between hmm_mirror_unregister() and mmu_notifier callback
Date: Fri, 31 Aug 2018 00:14:46 +1000 [thread overview]
Message-ID: <20180830141446.GB28695@350D> (raw)
In-Reply-To: <20180824192549.30844-4-jglisse@redhat.com>
On Fri, Aug 24, 2018 at 03:25:45PM -0400, jglisse@redhat.com wrote:
> From: Ralph Campbell <rcampbell@nvidia.com>
>
> In hmm_mirror_unregister(), mm->hmm is set to NULL and then
> mmu_notifier_unregister_no_release() is called. That creates a small
> window where mmu_notifier can call mmu_notifier_ops with mm->hmm equal
> to NULL. Fix this by first unregistering mmu notifier callbacks and
> then setting mm->hmm to NULL.
>
> Similarly in hmm_register(), set mm->hmm before registering mmu_notifier
> callbacks so callback functions always see mm->hmm set.
>
> Signed-off-by: Ralph Campbell <rcampbell@nvidia.com>
> Reviewed-by: John Hubbard <jhubbard@nvidia.com>
> Reviewed-by: J�r�me Glisse <jglisse@redhat.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: stable@vger.kernel.org
Reviewed-by: Balbir Singh <bsingharora@gmail.com>
next prev parent reply other threads:[~2018-08-30 14:14 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 19:25 [PATCH 0/7] HMM updates, improvements and fixes jglisse
2018-08-24 19:25 ` jglisse
2018-08-24 19:25 ` [PATCH 1/7] mm/hmm: fix utf8 jglisse
2018-08-24 19:25 ` jglisse
2018-08-24 19:25 ` [PATCH 2/7] mm/rmap: map_pte() was not handling private ZONE_DEVICE page properly jglisse
2018-08-24 19:25 ` jglisse
2018-08-30 14:05 ` Balbir Singh
2018-08-30 14:05 ` Balbir Singh
2018-08-30 14:05 ` Balbir Singh
2018-08-30 14:34 ` Jerome Glisse
2018-08-30 14:34 ` Jerome Glisse
2018-08-30 14:34 ` Jerome Glisse
2018-08-30 14:41 ` [PATCH 3/7] mm/rmap: map_pte() was not handling private ZONE_DEVICE page properly v2 jglisse
2018-08-30 14:41 ` jglisse
2018-08-31 9:27 ` Balbir Singh
2018-08-31 9:27 ` Balbir Singh
2018-08-31 9:27 ` Balbir Singh
2018-08-31 16:19 ` Jerome Glisse
2018-08-31 16:19 ` Jerome Glisse
2018-08-31 16:19 ` Jerome Glisse
2018-09-02 6:58 ` Balbir Singh
2018-09-02 6:58 ` Balbir Singh
2018-09-02 6:58 ` Balbir Singh
2018-08-24 19:25 ` [PATCH 3/7] mm/hmm: fix race between hmm_mirror_unregister() and mmu_notifier callback jglisse
2018-08-24 19:25 ` jglisse
2018-08-30 14:14 ` Balbir Singh [this message]
2018-08-30 14:14 ` Balbir Singh
2018-08-30 14:14 ` Balbir Singh
2018-08-24 19:25 ` [PATCH 4/7] mm/hmm: properly handle migration pmd jglisse
2018-08-24 19:25 ` jglisse
2018-08-25 0:05 ` Zi Yan
2018-08-28 0:35 ` Jerome Glisse
2018-08-28 0:35 ` Jerome Glisse
2018-08-28 15:24 ` Michal Hocko
2018-08-28 15:36 ` Jerome Glisse
2018-08-28 15:36 ` Jerome Glisse
2018-08-28 15:42 ` Michal Hocko
2018-08-28 15:45 ` Michal Hocko
2018-08-28 15:54 ` Zi Yan
2018-08-28 16:06 ` Jerome Glisse
2018-08-28 16:06 ` Jerome Glisse
2018-08-28 16:10 ` Michal Hocko
2018-08-29 17:17 ` [PATCH 4/7] mm/hmm: properly handle migration pmd v2 jglisse
2018-08-29 17:17 ` jglisse
2018-08-24 19:25 ` [PATCH 5/7] mm/hmm: use a structure for update callback parameters jglisse
2018-08-24 19:25 ` jglisse
2018-08-30 23:11 ` Balbir Singh
2018-08-30 23:11 ` Balbir Singh
2018-08-31 16:12 ` Jerome Glisse
2018-08-31 16:12 ` Jerome Glisse
2018-08-24 19:25 ` [PATCH 6/7] mm/hmm: invalidate device page table at start of invalidation jglisse
2018-08-24 19:25 ` jglisse
2018-08-24 19:25 ` [PATCH 7/7] mm/hmm: proper support for blockable mmu_notifier jglisse
2018-08-24 19:25 ` jglisse
2018-10-12 18:15 ` [PATCH 0/7] HMM updates, improvements and fixes Jerome Glisse
2018-10-12 18:15 ` Jerome Glisse
2018-10-12 21:12 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180830141446.GB28695@350D \
--to=bsingharora@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rcampbell@nvidia.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.