All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH mvebu-dt64] arm64: dts: marvell: armada-37xx: Add DTS file for Turris Mox
Date: Thu, 30 Aug 2018 17:57:01 +0200	[thread overview]
Message-ID: <20180830155701.GA31581@lunn.ch> (raw)
In-Reply-To: <20180830152326.15562-1-marek.behun@nic.cz>

> +	switch0 at 10 {
> +		compatible = "marvell,mv88e6190";
> +		reg = <0x10 0>;

MDO reg should have a single value, i think.

> +	switch0 at 2 {
> +		status = "disabled";
...
> +	};
> +
> +	switch1 at 11 {
> +		status = "disabled";
...
> +	};
> +
> +	switch1 at 2 {
> +		status = "disabled";
...
> +	};
> +
> +	switch2 at 12 {
> +		status = "disabled";
...
> +	};
> +
> +	switch2 at 2 {
> +		status = "disabled";
...
> +	};
> +};

I'm assuming the boatloader is probing the hardware, and then enabling
what it finds? This is a poor mans DT fragments. Lets see that Rob has
to say about this.

> +	moxtet at 1 {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		compatible = "cznic,moxtet";
> +		reg = <1>;
> +		devrst-gpio = <&gpiosb 2 GPIO_ACTIVE_LOW>;
> +		spi-max-frequency = <1000000>;
> +		spi-cpol;
> +		spi-cpha;
> +
> +		moxtet_sfp: moxtet-sfp at 0 {
> +			compatible = "cznic,moxtet-gpio";
> +			gpio-controller;
> +			#gpio-cells = <2>;
> +			reg = <0>;
> +			moxtet,id = <1>;
> +			moxtet,input-mask = <0x7>;
> +			moxtet,output-mask = <0x3>;
> +			status = "disabled";
> +		};
> +	};
> +};

Have the drivers for this been merged yet?

     Andrew

  reply	other threads:[~2018-08-30 15:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-30 15:23 [PATCH mvebu-dt64] arm64: dts: marvell: armada-37xx: Add DTS file for Turris Mox Marek Behún
2018-08-30 15:57 ` Andrew Lunn [this message]
2018-08-30 16:16   ` Marek Behun
  -- strict thread matches above, loose matches on Subject: below --
2018-08-30 15:05 Marek Behún
2018-08-30 15:11 ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180830155701.GA31581@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.