All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
	Brian Austin <brian.austin@cirrus.com>,
	Paul Handrigan <Paul.Handrigan@cirrus.com>,
	Matt Flax <flatmax@flatmax.org>
Subject: Re: [PATCH v2 2/3] ASoC: cs4265: Add native 32bit I2S transport [UNSCANNED]
Date: Thu, 30 Aug 2018 17:43:12 +0100	[thread overview]
Message-ID: <20180830164312.GF32322@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <20180830154140.GG7301@sirena.org.uk>

On Thu, Aug 30, 2018 at 04:41:40PM +0100, Mark Brown wrote:
> On Thu, Aug 30, 2018 at 09:38:01AM +1000, Matt Flax wrote:
> > The cs4265 uses 32 bit transport on the I2S bus. This patch enables native
> > 32 bit mode for machine drivers which use this sound card driver.
> > 
> > Signed-off-by: Matt Flax <flatmax@flatmax.org>
> > ---
> > 
> > No changes from v1, however have tested the intended functionality and
> > list discussion had firmed up its purpose.
> > ---
> 
> Charles?

I think this one looks fine to me:

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Only slightly doubt I had was that the CODEC doesn't actually
support 32bit only 24bit. It will however happily accept the
32-bit from the bus you just loose some precision whilst playing
it, so feels like that is basically the same as supporting it to
me. Unless I have missed something again :-)

Thanks,
Charles

  reply	other threads:[~2018-08-30 16:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29 23:38 [PATCH v2 1/3] ASoC: cs4265: SOC_SINGLE register value error fix Matt Flax
2018-08-29 23:38 ` [PATCH v2 2/3] ASoC: cs4265: Add native 32bit I2S transport Matt Flax
2018-08-30 15:41   ` Mark Brown
2018-08-30 16:43     ` Charles Keepax [this message]
2018-08-29 23:38 ` [PATCH v2 3/3] ASoC: cs4265: Add a SPDIF enable switch Matt Flax
2018-08-30  9:11   ` Charles Keepax
2018-08-31 15:38   ` Applied "ASoC: cs4265: Add a S/PDIF enable switch" to the asoc tree Mark Brown
2018-08-30  9:11 ` [PATCH v2 1/3] ASoC: cs4265: SOC_SINGLE register value error fix Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180830164312.GF32322@imbe.wolfsonmicro.main \
    --to=ckeepax@opensource.cirrus.com \
    --cc=Paul.Handrigan@cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=brian.austin@cirrus.com \
    --cc=broonie@kernel.org \
    --cc=flatmax@flatmax.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.