All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Matt Flax <flatmax@flatmax.org>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
	Brian Austin <brian.austin@cirrus.com>,
	Paul Handrigan <Paul.Handrigan@cirrus.com>
Subject: Re: [PATCH v2 1/3] ASoC: cs4265: SOC_SINGLE register value error fix
Date: Thu, 30 Aug 2018 10:11:42 +0100	[thread overview]
Message-ID: <20180830091142.GD32322@imbe.wolfsonmicro.main> (raw)
In-Reply-To: <20180829233802.22032-1-flatmax@flatmax.org>

On Thu, Aug 30, 2018 at 09:38:00AM +1000, Matt Flax wrote:
> The cs4265 driver declares the "MMTLR Data Switch" register setting with
> a 0 register value rather then the 0x12 register (CS4265_SPDIF_CTL2).
> This incorrect value causes alsamixer to fault with the output :
> cannot load mixer controls: Input/output error
> 
> This patch corrects the register value. alsamixer now runs.
> 
> Signed-off-by: Matt Flax <flatmax@flatmax.org>
> ---
> 
> Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
> Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

These wanted to be above the --- so they are added into the
commit message when the maintainer applies the commit. Probably
not worth resending for it, but keep in mind for future.

Thanks,
Charles

      parent reply	other threads:[~2018-08-30  9:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29 23:38 [PATCH v2 1/3] ASoC: cs4265: SOC_SINGLE register value error fix Matt Flax
2018-08-29 23:38 ` [PATCH v2 2/3] ASoC: cs4265: Add native 32bit I2S transport Matt Flax
2018-08-30 15:41   ` Mark Brown
2018-08-30 16:43     ` [PATCH v2 2/3] ASoC: cs4265: Add native 32bit I2S transport [UNSCANNED] Charles Keepax
2018-08-29 23:38 ` [PATCH v2 3/3] ASoC: cs4265: Add a SPDIF enable switch Matt Flax
2018-08-30  9:11   ` Charles Keepax
2018-08-31 15:38   ` Applied "ASoC: cs4265: Add a S/PDIF enable switch" to the asoc tree Mark Brown
2018-08-30  9:11 ` Charles Keepax [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180830091142.GD32322@imbe.wolfsonmicro.main \
    --to=ckeepax@opensource.cirrus.com \
    --cc=Paul.Handrigan@cirrus.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=brian.austin@cirrus.com \
    --cc=broonie@kernel.org \
    --cc=flatmax@flatmax.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.