[PATCH v1] xen: creating debug info is optional

[PATCH v1] xen: creating debug info is optional

[Olaf Hering]

Creating debug info during build is not strictly required at runtime.
Make it optional by reusing the existing 'debug_symbols=n' knob.
This slightly reduces build time and diskusage, if specified.

Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
 xen/Rules.mk | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/xen/Rules.mk b/xen/Rules.mk
index 47c954425d..740b0235e1 100644
--- a/xen/Rules.mk
+++ b/xen/Rules.mk
@@ -55,7 +55,10 @@ endif
 
 CFLAGS += -nostdinc -fno-builtin -fno-common
 CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith
-CFLAGS += -pipe -g -D__XEN__ -include $(BASEDIR)/include/xen/config.h
+ifeq ($(debug_symbols),y)
+CFLAGS += -g
+endif
+CFLAGS += -pipe -D__XEN__ -include $(BASEDIR)/include/xen/config.h
 CFLAGS += '-D__OBJECT_FILE__="$@"'
 
 ifneq ($(clang),y)

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v1] xen: creating debug info is optional

[Jan Beulich]

>>> On 30.08.18 at 17:10, <olaf@aepfle.de> wrote:
> Creating debug info during build is not strictly required at runtime.
> Make it optional by reusing the existing 'debug_symbols=n' knob.

Reusing? It's been gone since 4.9, and ./INSTALL talks about it as
a tool stack only thing. If we wanted to re-introduce anything like
this, it should be done via Kconfig option. But note that without
debug info the quality of certain linker errors decreases, which is
why I would recommend against doing so.

Also please send patches _To_ the list, with maintainers _Cc_-ed.

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v1] xen: creating debug info is optional

[Olaf Hering]

[-- Attachment #1.1: Type: text/plain, Size: 292 bytes --]

Am Thu, 30 Aug 2018 09:23:47 -0600
schrieb "Jan Beulich" <JBeulich@suse.com>:

> Reusing? It's been gone since 4.9, and ./INSTALL talks about it as
> a tool stack only thing.

It does not, it is in the general "make" section.
I do not see any valid reason to diverge further.

Olaf

[-- Attachment #1.2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH v1] xen: creating debug info is optional

[Jan Beulich]

>>> On 30.08.18 at 17:59, <olaf@aepfle.de> wrote:
> Am Thu, 30 Aug 2018 09:23:47 -0600
> schrieb "Jan Beulich" <JBeulich@suse.com>:
> 
>> Reusing? It's been gone since 4.9, and ./INSTALL talks about it as
>> a tool stack only thing.
> 
> It does not, it is in the general "make" section.

Quote from ./INSTALL in my copy of the master tree:

"Per default some parts of the tools code will print additional runtime
 debug. This option can be used to disable such code paths.
 debug=y
 debug_symbols=y"

Note the word "tools" in there.

> I do not see any valid reason to diverge further.

???

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel