All of lore.kernel.org
 help / color / mirror / Atom feed
From: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Maxime Ripard <maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>
Cc: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
	hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	kishon-l0cyMroinI0@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	wens-jdAy2FN1RRM@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v4 12/13] ARM: dts: sun4i: a10: add sata-port/sata-phy nodes
Date: Fri, 31 Aug 2018 09:53:50 +0200	[thread overview]
Message-ID: <20180831075350.GA16301@Red> (raw)
In-Reply-To: <20180831073724.kuw5tb6yypb4pmkp@flea>

On Fri, Aug 31, 2018 at 09:37:24AM +0200, Maxime Ripard wrote:
> On Thu, Aug 30, 2018 at 09:01:19PM +0200, Corentin Labbe wrote:
> > This patch convert sun4i-a10 sata to the new binding which use a sata
> > phy node.
> > 
> > Signed-off-by: Corentin Labbe <clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > ---
> >  arch/arm/boot/dts/sun4i-a10.dtsi | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> > index 3d62a8950720..52d5c2e79499 100644
> > --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> > +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> > @@ -556,7 +556,20 @@
> >  			reg = <0x01c18000 0x1000>;
> >  			interrupts = <56>;
> >  			clocks = <&ccu CLK_AHB_SATA>, <&ccu CLK_SATA>;
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> >  			status = "disabled";
> > +
> > +			sata_port: sata-port@0 {
> > +				reg = <0>;
> > +				phys = <&sata_phy>;
> > +			};
> > +		};
> > +
> > +		sata_phy: sata_phy@1c180c0 {
> > +			compatible = "allwinner,sun4i-a10-sata-phy";
> > +			reg = <0x01c180c0 0x200>;
> > +			#phy-cells = <0>;
> >  		};
> 
> This patch, together with the following one, breaks the DT ABI, this
> isn't something we can do anymore.
> 

So what can I do ?
Keep the DT in place and drop the patch 13 like wens suggested ?

Regards

WARNING: multiple messages have this Message-ID (diff)
From: clabbe.montjoie@gmail.com (Corentin Labbe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 12/13] ARM: dts: sun4i: a10: add sata-port/sata-phy nodes
Date: Fri, 31 Aug 2018 09:53:50 +0200	[thread overview]
Message-ID: <20180831075350.GA16301@Red> (raw)
In-Reply-To: <20180831073724.kuw5tb6yypb4pmkp@flea>

On Fri, Aug 31, 2018 at 09:37:24AM +0200, Maxime Ripard wrote:
> On Thu, Aug 30, 2018 at 09:01:19PM +0200, Corentin Labbe wrote:
> > This patch convert sun4i-a10 sata to the new binding which use a sata
> > phy node.
> > 
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > ---
> >  arch/arm/boot/dts/sun4i-a10.dtsi | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> > index 3d62a8950720..52d5c2e79499 100644
> > --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> > +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> > @@ -556,7 +556,20 @@
> >  			reg = <0x01c18000 0x1000>;
> >  			interrupts = <56>;
> >  			clocks = <&ccu CLK_AHB_SATA>, <&ccu CLK_SATA>;
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> >  			status = "disabled";
> > +
> > +			sata_port: sata-port at 0 {
> > +				reg = <0>;
> > +				phys = <&sata_phy>;
> > +			};
> > +		};
> > +
> > +		sata_phy: sata_phy at 1c180c0 {
> > +			compatible = "allwinner,sun4i-a10-sata-phy";
> > +			reg = <0x01c180c0 0x200>;
> > +			#phy-cells = <0>;
> >  		};
> 
> This patch, together with the following one, breaks the DT ABI, this
> isn't something we can do anymore.
> 

So what can I do ?
Keep the DT in place and drop the patch 13 like wens suggested ?

Regards

WARNING: multiple messages have this Message-ID (diff)
From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: axboe@kernel.dk, hdegoede@redhat.com, kishon@ti.com,
	mark.rutland@arm.com, robh+dt@kernel.org, wens@csie.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-sunxi@googlegroups.com
Subject: Re: [PATCH v4 12/13] ARM: dts: sun4i: a10: add sata-port/sata-phy nodes
Date: Fri, 31 Aug 2018 09:53:50 +0200	[thread overview]
Message-ID: <20180831075350.GA16301@Red> (raw)
In-Reply-To: <20180831073724.kuw5tb6yypb4pmkp@flea>

On Fri, Aug 31, 2018 at 09:37:24AM +0200, Maxime Ripard wrote:
> On Thu, Aug 30, 2018 at 09:01:19PM +0200, Corentin Labbe wrote:
> > This patch convert sun4i-a10 sata to the new binding which use a sata
> > phy node.
> > 
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > ---
> >  arch/arm/boot/dts/sun4i-a10.dtsi | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> > index 3d62a8950720..52d5c2e79499 100644
> > --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> > +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> > @@ -556,7 +556,20 @@
> >  			reg = <0x01c18000 0x1000>;
> >  			interrupts = <56>;
> >  			clocks = <&ccu CLK_AHB_SATA>, <&ccu CLK_SATA>;
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> >  			status = "disabled";
> > +
> > +			sata_port: sata-port@0 {
> > +				reg = <0>;
> > +				phys = <&sata_phy>;
> > +			};
> > +		};
> > +
> > +		sata_phy: sata_phy@1c180c0 {
> > +			compatible = "allwinner,sun4i-a10-sata-phy";
> > +			reg = <0x01c180c0 0x200>;
> > +			#phy-cells = <0>;
> >  		};
> 
> This patch, together with the following one, breaks the DT ABI, this
> isn't something we can do anymore.
> 

So what can I do ?
Keep the DT in place and drop the patch 13 like wens suggested ?

Regards

  reply	other threads:[~2018-08-31  7:53 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-30 19:01 [PATCH v4 00/13] ata: ahci_platform: support allwinner R40 AHCI Corentin Labbe
2018-08-30 19:01 ` Corentin Labbe
2018-08-30 19:01 ` Corentin Labbe
     [not found] ` <20180830190120.722-1-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-30 19:01   ` [PATCH v4 01/13] dt-bindings: ata: ahci-platform: fix indentation of target-supply Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01   ` [PATCH v4 02/13] ata: ahci_platform: add support for AHCI controller regulator Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01   ` [PATCH v4 03/13] dt-bindings: ata: ahci-platform: document ahci-supply Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01   ` [PATCH v4 04/13] phy: Add sun4i-a10-phy-sata driver Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01   ` [PATCH v4 05/13] dt-bindings: phy: document sun4i-a10-sata-phy Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01   ` [PATCH v4 06/13] dt-bindings: ata: update ahci_sunxi bindings Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01   ` [PATCH v4 07/13] ata: ahci_sunxi: Bypass PHY init when using the new binding Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01   ` [PATCH v4 08/13] ata: ahci_sunxi: add support for r40 Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01   ` [PATCH v4 10/13] ARM: dts: sun8i: sun8i-r40-bananapi-m2-ultra: enable AHCI Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01   ` [PATCH v4 11/13] ARM: dts: sun7i: a20: add sata-port/sata-phy nodes Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01   ` [PATCH v4 12/13] ARM: dts: sun4i: a10: " Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
     [not found]     ` <20180830190120.722-13-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-31  7:37       ` Maxime Ripard
2018-08-31  7:37         ` Maxime Ripard
2018-08-31  7:37         ` Maxime Ripard
2018-08-31  7:53         ` Corentin Labbe [this message]
2018-08-31  7:53           ` Corentin Labbe
2018-08-31  7:53           ` Corentin Labbe
2018-08-31 10:21           ` Maxime Ripard
2018-08-31 10:21             ` Maxime Ripard
2018-08-31 10:21             ` Maxime Ripard
2018-08-30 19:01   ` [PATCH v4 13/13 DONOTMERGE] ata: ahci_sunxi: remove PHY code Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
2018-08-30 19:01     ` Corentin Labbe
     [not found]     ` <20180830190120.722-14-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-30 20:27       ` Hans de Goede
2018-08-30 20:27         ` Hans de Goede
2018-08-30 20:27         ` Hans de Goede
2018-08-30 20:24   ` [PATCH v4 00/13] ata: ahci_platform: support allwinner R40 AHCI Hans de Goede
2018-08-30 20:24     ` Hans de Goede
2018-08-30 20:24     ` Hans de Goede
2018-08-30 19:01 ` [PATCH v4 09/13] ARM: dts: sun8i: r40: add sata node Corentin Labbe
2018-08-30 19:01   ` Corentin Labbe
     [not found]   ` <20180830190120.722-10-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-08-31  7:35     ` Maxime Ripard
2018-08-31  7:35       ` Maxime Ripard
2018-08-31  7:35       ` Maxime Ripard
2018-08-31  7:56       ` Corentin Labbe
2018-08-31  7:56         ` Corentin Labbe
2018-08-31  7:56         ` Corentin Labbe
2018-08-31  7:58         ` Chen-Yu Tsai
2018-08-31  7:58           ` Chen-Yu Tsai
     [not found]           ` <CAGb2v65dWmFxacx16taTdDf0WO4vCJfJLrf=7Vh6RtJEjHdH5A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-08-31  9:29             ` Corentin Labbe
2018-08-31  9:29               ` Corentin Labbe
2018-08-31  9:29               ` Corentin Labbe
2018-08-31 11:10               ` Chen-Yu Tsai
2018-08-31 11:10                 ` Chen-Yu Tsai
2018-08-31 11:10                 ` Chen-Yu Tsai
     [not found]                 ` <CAGb2v65H_Aog294NYAmcTGARGiOiyCDy=MT9g8ed=Cxr8Bm3Qg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-08-31 12:57                   ` Icenowy Zheng
2018-08-31 12:57                     ` Icenowy Zheng
2018-08-31 12:57                     ` Icenowy Zheng
2018-08-31 10:20         ` maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ
2018-08-31 10:20           ` maxime.ripard
2018-08-31 10:20           ` maxime.ripard at bootlin.com
2018-08-31 10:54           ` Corentin Labbe
2018-08-31 10:54             ` Corentin Labbe
2018-08-31 10:54             ` Corentin Labbe
2018-08-31 11:31             ` Chen-Yu Tsai
2018-08-31 11:31               ` Chen-Yu Tsai
2018-08-31 11:31               ` Chen-Yu Tsai
     [not found]               ` <CAGb2v65m73mZkQ9qbYne-utZPujEvRftYGz5kYCx=8t-C-=DJQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-08-31 12:08                 ` Corentin Labbe
2018-08-31 12:08                   ` Corentin Labbe
2018-08-31 12:08                   ` Corentin Labbe
2018-08-31 12:58                 ` Icenowy Zheng
2018-08-31 12:58                   ` Icenowy Zheng
2018-08-31 12:58                   ` Icenowy Zheng
2018-08-30 20:31 ` [PATCH v4 00/13] ata: ahci_platform: support allwinner R40 AHCI Jens Axboe
2018-08-30 20:31   ` Jens Axboe
     [not found]   ` <f5838eae-fa6c-8699-14a4-95d0daa8a960-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2018-08-31  2:32     ` Chen-Yu Tsai
2018-08-31  2:32       ` Chen-Yu Tsai
2018-08-31  2:32       ` Chen-Yu Tsai
2018-08-31  2:52       ` Jens Axboe
2018-08-31  2:52         ` Jens Axboe
     [not found]         ` <8fa866c5-6800-505f-53bc-5c1b27582ca6-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2018-08-31  7:40           ` Maxime Ripard
2018-08-31  7:40             ` Maxime Ripard
2018-08-31  7:40             ` Maxime Ripard
2018-08-31 14:35             ` Jens Axboe
2018-08-31 14:35               ` Jens Axboe
2018-09-03  8:31               ` Maxime Ripard
2018-09-03  8:31                 ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180831075350.GA16301@Red \
    --to=clabbe.montjoie-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=kishon-l0cyMroinI0@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-ide-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=wens-jdAy2FN1RRM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.