Re: [igt-dev] [PATCH v6 05/13] fb: Fix ARGB8888 color depth

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	eben@raspberrypi.org, igt-dev@lists.freedesktop.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [igt-dev] [PATCH v6 05/13] fb: Fix ARGB8888 color depth
Date: Fri, 31 Aug 2018 16:42:18 +0300	[thread overview]
Message-ID: <20180831134218.GZ5565@intel.com> (raw)
In-Reply-To: <646c39734b6dde4b74f215b64f094cddc9e00ebe.1535721136.git-series.maxime.ripard@bootlin.com>

On Fri, Aug 31, 2018 at 03:12:14PM +0200, Maxime Ripard wrote:
> The ARGB8888 has been listed as having a 32 bits depth, while it actually
> is a 24 bits format. Fix this.

I think 32 is the more usual definition for this.

> 
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
>  lib/igt_fb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 9aee02c35c16..7d46cfdb45d8 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -80,7 +80,7 @@ static struct format_desc_struct {
>  	  .cairo_id = CAIRO_FORMAT_RGB30,
>  	  .num_planes = 1, .plane_bpp = { 32, },
>  	},
> -	{ .name = "ARGB8888", .depth = 32, .drm_id = DRM_FORMAT_ARGB8888,
> +	{ .name = "ARGB8888", .depth = 24, .drm_id = DRM_FORMAT_ARGB8888,
>  	  .cairo_id = CAIRO_FORMAT_ARGB32,
>  	  .num_planes = 1, .plane_bpp = { 32, },
>  	},
> -- 
> git-series 0.9.1

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev