All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>
Cc: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	eben@raspberrypi.org, igt-dev@lists.freedesktop.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [igt-dev] [PATCH v6 05/13] fb: Fix ARGB8888 color depth
Date: Wed, 5 Sep 2018 16:37:26 +0300	[thread overview]
Message-ID: <20180905133726.GR5565@intel.com> (raw)
In-Reply-To: <20180905131903.ucuftgtcq4hzze2s@flea>

On Wed, Sep 05, 2018 at 03:19:03PM +0200, Maxime Ripard wrote:
> On Wed, Sep 05, 2018 at 01:14:34PM +0300, Ville Syrjälä wrote:
> > > In the same format list:
> > >   - RGB565 has a depth of 16
> > >   - XRGB8888 has a depth of 24
> > >   - XRGB2101010 has a depth of 30
> > >   - ARGB8888 has a depth of 32
> > > 
> > > Which seems to indicate that the list indeed meant that the color
> > > depth is about the color, and that ARGB8888 is wrong.
> > 
> > None of those other things have alpha, so they are still
> > consistent with the depth==32 definition for ARGB888.
> 
> "24 bits almost always uses 8 bits of each of R, G, B. As of 2018
> 24-bit color depth is used by virtually every computer and phone
> display and the vast majority of image storage formats. Almost all
> cases where there are 32 bits per pixel mean that 24 are used for the
> color, and the remaining 8 are the alpha channel or unused."
> 
> There's 32bpp, but the depth is 24 bits.
> 
> But maybe the X11 legacy says otherwise, I don't know. What's your
> suggestion then? adding yet another field?

Just leave it as is?

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2018-09-05 13:37 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-31 13:12 [igt-dev] [PATCH v6 00/13] chamelium: Test the plane formats Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 01/13] fb: Add buffer map/unmap functions Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 02/13] fb: convert: Remove swizzle from the arguments Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 03/13] fb: Create common function to convert frame formats Maxime Ripard
2018-08-31 13:41   ` Ville Syrjälä
2018-09-05 13:16     ` Maxime Ripard
2018-09-06 11:41     ` Maxime Ripard
2018-09-06 12:11       ` Ville Syrjälä
2018-09-06 12:49         ` Maxime Ripard
2018-09-06 13:30           ` Ville Syrjälä
2018-08-31 13:12 ` [igt-dev] [PATCH v6 04/13] fb: Add format conversion routine Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 05/13] fb: Fix ARGB8888 color depth Maxime Ripard
2018-08-31 13:42   ` Ville Syrjälä
2018-09-05  9:35     ` Maxime Ripard
2018-09-05 10:14       ` Ville Syrjälä
2018-09-05 13:19         ` Maxime Ripard
2018-09-05 13:37           ` Ville Syrjälä [this message]
2018-09-06  7:22             ` Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 06/13] fb: Add support for conversions through pixman Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 07/13] fb: Add depth lookup function Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 08/13] fb: Add more formats Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 09/13] chamelium: Split CRC test function in two Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 10/13] chamelium: Change our pattern for a custom one if needed Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 11/13] chamelium: Add format support Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 12/13] chamelium: Add format subtests Maxime Ripard
2018-08-31 13:12 ` [igt-dev] [PATCH v6 13/13] tests: Add chamelium formats subtests to vc4 test lists Maxime Ripard
2018-09-03  8:33 ` [igt-dev] ✓ Fi.CI.BAT: success for chamelium: Test the plane formats (rev5) Patchwork
2018-09-03  9:43 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180905133726.GR5565@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=eben@raspberrypi.org \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=maxime.ripard@bootlin.com \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.