All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next v3 02/10] net: mvpp2: phylink support
Date: Fri, 31 Aug 2018 16:18:51 +0200	[thread overview]
Message-ID: <20180831141851.GA19733@lunn.ch> (raw)
In-Reply-To: <20180831133651.GB32574@kwain>

> @@ -4691,6 +4685,9 @@ static int mvpp2_port_probe(struct platform_device *pdev,
>  	if (fwnode_property_read_bool(port_fwnode, "marvell,loopback"))
>  		port->flags |= MVPP2_F_LOOPBACK;
>  
> +	if (fwnode_property_present(port_fwnode, "fixed-link"))
> +		port->flags |= MVPP2_F_FIXED_LINK;
> +

Hi Antoine

There is no need to go look in device tree. When phylink calls
mac_config() it passes mode == MLO_AN_FIXED, when it is using a fixed
link.

	Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Antoine Tenart <antoine.tenart@bootlin.com>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
	davem@davemloft.net, kishon@ti.com, gregory.clement@bootlin.com,
	jason@lakedaemon.net, sebastian.hesselbarth@gmail.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	thomas.petazzoni@bootlin.com, maxime.chevallier@bootlin.com,
	miquel.raynal@bootlin.com, nadavh@marvell.com,
	stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v3 02/10] net: mvpp2: phylink support
Date: Fri, 31 Aug 2018 16:18:51 +0200	[thread overview]
Message-ID: <20180831141851.GA19733@lunn.ch> (raw)
In-Reply-To: <20180831133651.GB32574@kwain>

> @@ -4691,6 +4685,9 @@ static int mvpp2_port_probe(struct platform_device *pdev,
>  	if (fwnode_property_read_bool(port_fwnode, "marvell,loopback"))
>  		port->flags |= MVPP2_F_LOOPBACK;
>  
> +	if (fwnode_property_present(port_fwnode, "fixed-link"))
> +		port->flags |= MVPP2_F_FIXED_LINK;
> +

Hi Antoine

There is no need to go look in device tree. When phylink calls
mac_config() it passes mode == MLO_AN_FIXED, when it is using a fixed
link.

	Andrew

  parent reply	other threads:[~2018-08-31 14:18 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-17  8:29 [PATCH net-next v3 00/10] net: mvpp2: phylink conversion Antoine Tenart
2018-05-17  8:29 ` Antoine Tenart
2018-05-17  8:29 ` [PATCH net-next v3 01/10] net: mvpp2: align the ethtool ops definition Antoine Tenart
2018-05-17  8:29   ` Antoine Tenart
2018-05-17  8:29 ` [PATCH net-next v3 02/10] net: mvpp2: phylink support Antoine Tenart
2018-05-17  8:29   ` Antoine Tenart
2018-08-27 16:50   ` Russell King - ARM Linux
2018-08-27 16:50     ` Russell King - ARM Linux
2018-08-31 13:36     ` Antoine Tenart
2018-08-31 13:36       ` Antoine Tenart
2018-08-31 13:36       ` Antoine Tenart
2018-08-31 14:11       ` Russell King - ARM Linux
2018-08-31 14:11         ` Russell King - ARM Linux
2018-08-31 14:37         ` Andrew Lunn
2018-08-31 14:37           ` Andrew Lunn
2018-08-31 15:21           ` Russell King - ARM Linux
2018-08-31 15:21             ` Russell King - ARM Linux
2018-09-12 14:34             ` Antoine Tenart
2018-09-12 14:34               ` Antoine Tenart
2018-08-31 15:08         ` Antoine Tenart
2018-08-31 15:08           ` Antoine Tenart
2018-08-31 14:18       ` Andrew Lunn [this message]
2018-08-31 14:18         ` Andrew Lunn
2018-08-31 14:23         ` Antoine Tenart
2018-08-31 14:23           ` Antoine Tenart
2018-05-17  8:29 ` [PATCH net-next v3 03/10] phy: add 2.5G SGMII mode to the phy_mode enum Antoine Tenart
2018-05-17  8:29   ` Antoine Tenart
2018-05-17  8:29   ` Antoine Tenart
2018-05-17  8:29 ` [PATCH net-next v3 04/10] phy: cp110-comphy: 2.5G SGMII mode Antoine Tenart
2018-05-17  8:29   ` Antoine Tenart
2018-05-17  8:29 ` [PATCH net-next v3 05/10] net: mvpp2: 1000baseX support Antoine Tenart
2018-05-17  8:29   ` Antoine Tenart
2018-05-17  8:29   ` Antoine Tenart
2018-05-17  8:29 ` [PATCH net-next v3 06/10] net: mvpp2: 2500baseX support Antoine Tenart
2018-05-17  8:29   ` Antoine Tenart
2018-05-17  8:29 ` [PATCH net-next v3 07/10] arm64: dts: marvell: mcbin: add 10G SFP support Antoine Tenart
2018-05-17  8:29   ` Antoine Tenart
2018-05-17  8:29 ` [PATCH net-next v3 08/10] arm64: dts: marvell: mcbin: enable the fourth network interface Antoine Tenart
2018-05-17  8:29   ` Antoine Tenart
2018-05-17  8:29 ` [PATCH net-next v3 09/10] arm64: dts: marvell: 8040-db: describe the 10G interfaces as fixed-link Antoine Tenart
2018-05-17  8:29   ` Antoine Tenart
2018-05-17  8:29 ` [PATCH net-next v3 10/10] arm64: dts: marvell: 7040-db: describe the 10G interface " Antoine Tenart
2018-05-17  8:29   ` Antoine Tenart
2018-05-17  9:18 ` [PATCH net-next v3 00/10] net: mvpp2: phylink conversion Russell King - ARM Linux
2018-05-17  9:18   ` Russell King - ARM Linux
2018-05-17  9:26   ` Antoine Tenart
2018-05-17  9:26     ` Antoine Tenart
2018-05-17  9:26     ` Antoine Tenart
2018-05-17 12:23 ` Gregory CLEMENT
2018-05-17 12:23   ` Gregory CLEMENT
2018-05-17 20:12 ` David Miller
2018-05-17 20:12   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180831141851.GA19733@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.