From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
Helmut Schaa <helmut.schaa@googlemail.com>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] rt2x00: use simple_read_from_buffer()
Date: Fri, 31 Aug 2018 15:47:46 +0000 [thread overview]
Message-ID: <20180831154746.482A460242@smtp.codeaurora.org> (raw)
In-Reply-To: <20180822104126.2logh4tqxkmiomqy@kili.mountain>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The problem with this copy_to_user() calls is that they don't ensure
> that "size" is less than the "length" which the user provided.
>
> Obviously, this is debugfs and "size" is normally going to be very small
> so it probably doesn't matter, but this is the correct thing to do.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
Patch applied to wireless-drivers-next.git, thanks.
f483039cf51a rt2x00: use simple_read_from_buffer()
--
https://patchwork.kernel.org/patch/10572845/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
Helmut Schaa <helmut.schaa@googlemail.com>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] rt2x00: use simple_read_from_buffer()
Date: Fri, 31 Aug 2018 15:47:46 +0000 (UTC) [thread overview]
Message-ID: <20180831154746.482A460242@smtp.codeaurora.org> (raw)
In-Reply-To: <20180822104126.2logh4tqxkmiomqy@kili.mountain>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> The problem with this copy_to_user() calls is that they don't ensure
> that "size" is less than the "length" which the user provided.
>
> Obviously, this is debugfs and "size" is normally going to be very small
> so it probably doesn't matter, but this is the correct thing to do.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Stanislaw Gruszka <sgruszka@redhat.com>
Patch applied to wireless-drivers-next.git, thanks.
f483039cf51a rt2x00: use simple_read_from_buffer()
--
https://patchwork.kernel.org/patch/10572845/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2018-08-31 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 10:41 [PATCH] rt2x00: use simple_read_from_buffer() Dan Carpenter
2018-08-22 10:41 ` Dan Carpenter
2018-08-22 13:32 ` Stanislaw Gruszka
2018-08-22 13:32 ` Stanislaw Gruszka
2018-08-31 15:47 ` Kalle Valo [this message]
2018-08-31 15:47 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180831154746.482A460242@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=helmut.schaa@googlemail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.