From: Kalle Valo <kvalo@codeaurora.org>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mt76: Fix comparisons with invalid hardware key index
Date: Fri, 31 Aug 2018 15:52:48 +0000 (UTC) [thread overview]
Message-ID: <20180831155248.D7F8D607F7@smtp.codeaurora.org> (raw)
In-Reply-To: <20180823212738.18431-1-geert@linux-m68k.org>
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> With gcc 4.1.2:
>
> drivers/net/wireless/mediatek/mt76/mt76x0/tx.c: In function ‘mt76x0_tx’:
> drivers/net/wireless/mediatek/mt76/mt76x0/tx.c:169: warning: comparison is always true due to limited range of data type
> drivers/net/wireless/mediatek/mt76/mt76x2_tx_common.c: In function ‘mt76x2_tx’:
> drivers/net/wireless/mediatek/mt76/mt76x2_tx_common.c:35: warning: comparison is always true due to limited range of data type
>
> While assigning -1 to a u8 works fine, comparing with -1 does not work
> as expected.
>
> Fix this by comparing with 0xff, like is already done in some other
> places.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Patch applied to wireless-drivers-next.git, thanks.
81c8eccc2404 mt76: Fix comparisons with invalid hardware key index
--
https://patchwork.kernel.org/patch/10574583/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: kvalo@codeaurora.org (Kalle Valo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mt76: Fix comparisons with invalid hardware key index
Date: Fri, 31 Aug 2018 15:52:48 +0000 (UTC) [thread overview]
Message-ID: <20180831155248.D7F8D607F7@smtp.codeaurora.org> (raw)
In-Reply-To: <20180823212738.18431-1-geert@linux-m68k.org>
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> With gcc 4.1.2:
>
> drivers/net/wireless/mediatek/mt76/mt76x0/tx.c: In function ?mt76x0_tx?:
> drivers/net/wireless/mediatek/mt76/mt76x0/tx.c:169: warning: comparison is always true due to limited range of data type
> drivers/net/wireless/mediatek/mt76/mt76x2_tx_common.c: In function ?mt76x2_tx?:
> drivers/net/wireless/mediatek/mt76/mt76x2_tx_common.c:35: warning: comparison is always true due to limited range of data type
>
> While assigning -1 to a u8 works fine, comparing with -1 does not work
> as expected.
>
> Fix this by comparing with 0xff, like is already done in some other
> places.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Patch applied to wireless-drivers-next.git, thanks.
81c8eccc2404 mt76: Fix comparisons with invalid hardware key index
--
https://patchwork.kernel.org/patch/10574583/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Stanislaw Gruszka <sgruszka@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mt76: Fix comparisons with invalid hardware key index
Date: Fri, 31 Aug 2018 15:52:48 +0000 (UTC) [thread overview]
Message-ID: <20180831155248.D7F8D607F7@smtp.codeaurora.org> (raw)
In-Reply-To: <20180823212738.18431-1-geert@linux-m68k.org>
Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> With gcc 4.1.2:
>
> drivers/net/wireless/mediatek/mt76/mt76x0/tx.c: In function ‘mt76x0_tx’:
> drivers/net/wireless/mediatek/mt76/mt76x0/tx.c:169: warning: comparison is always true due to limited range of data type
> drivers/net/wireless/mediatek/mt76/mt76x2_tx_common.c: In function ‘mt76x2_tx’:
> drivers/net/wireless/mediatek/mt76/mt76x2_tx_common.c:35: warning: comparison is always true due to limited range of data type
>
> While assigning -1 to a u8 works fine, comparing with -1 does not work
> as expected.
>
> Fix this by comparing with 0xff, like is already done in some other
> places.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Patch applied to wireless-drivers-next.git, thanks.
81c8eccc2404 mt76: Fix comparisons with invalid hardware key index
--
https://patchwork.kernel.org/patch/10574583/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-08-31 15:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 21:27 [PATCH] mt76: Fix comparisons with invalid hardware key index Geert Uytterhoeven
2018-08-23 21:27 ` Geert Uytterhoeven
2018-08-24 8:08 ` Stanislaw Gruszka
2018-08-24 8:08 ` Stanislaw Gruszka
2018-08-24 8:20 ` Kalle Valo
2018-08-24 8:20 ` Kalle Valo
2018-08-24 8:20 ` Kalle Valo
2018-08-31 15:52 ` Kalle Valo
2018-08-31 15:52 ` Kalle Valo
2018-08-31 15:52 ` Kalle Valo [this message]
2018-08-31 15:52 ` Kalle Valo
2018-08-31 15:52 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180831155248.D7F8D607F7@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.