From: Wolfram Sang <wsa@the-dreams.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: uniphier-f: issue STOP only for last message or I2C_M_STOP
Date: Sat, 1 Sep 2018 14:52:05 +0200 [thread overview]
Message-ID: <20180901125205.GE1196@kunai> (raw)
In-Reply-To: <1535725848-4076-2-git-send-email-yamada.masahiro@socionext.com>
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
On Fri, Aug 31, 2018 at 11:30:48PM +0900, Masahiro Yamada wrote:
> This driver currently emits a STOP if the next message is not
> I2C_MD_RD. It should not do it because it disturbs the I2C_RDWR
> ioctl, where read/write transactions are combined without STOP
> between.
>
> Issue STOP only when the message is the last one _or_ flagged with
> I2C_M_STOP.
>
> Fixes: 6a62974b667f ("i2c: uniphier_f: add UniPhier FIFO-builtin I2C driver")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] i2c: uniphier-f: issue STOP only for last message or I2C_M_STOP
Date: Sat, 1 Sep 2018 14:52:05 +0200 [thread overview]
Message-ID: <20180901125205.GE1196@kunai> (raw)
In-Reply-To: <1535725848-4076-2-git-send-email-yamada.masahiro@socionext.com>
On Fri, Aug 31, 2018 at 11:30:48PM +0900, Masahiro Yamada wrote:
> This driver currently emits a STOP if the next message is not
> I2C_MD_RD. It should not do it because it disturbs the I2C_RDWR
> ioctl, where read/write transactions are combined without STOP
> between.
>
> Issue STOP only when the message is the last one _or_ flagged with
> I2C_M_STOP.
>
> Fixes: 6a62974b667f ("i2c: uniphier_f: add UniPhier FIFO-builtin I2C driver")
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied to for-current, thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180901/e303d2b8/attachment.sig>
next prev parent reply other threads:[~2018-09-01 12:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 14:30 [PATCH 1/2] i2c: uniphier: issue STOP only for last message or I2C_M_STOP Masahiro Yamada
2018-08-31 14:30 ` Masahiro Yamada
2018-08-31 14:30 ` [PATCH 2/2] i2c: uniphier-f: " Masahiro Yamada
2018-08-31 14:30 ` Masahiro Yamada
2018-09-01 12:52 ` Wolfram Sang [this message]
2018-09-01 12:52 ` Wolfram Sang
2018-09-01 12:52 ` [PATCH 1/2] i2c: uniphier: " Wolfram Sang
2018-09-01 12:52 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180901125205.GE1196@kunai \
--to=wsa@the-dreams.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.