From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin
Date: Mon, 3 Sep 2018 12:54:28 +0800 [thread overview]
Message-ID: <20180903045426.GM3850@dragon> (raw)
In-Reply-To: <20180831191732.25504-1-afd@ti.com>
On Fri, Aug 31, 2018 at 02:17:31PM -0500, Andrew F. Davis wrote:
> The correct DT property for specifying a GPIO used for reset
> is "reset-gpios", fix this here.
>
> Fixes: d763762e3b58 ("ARM: dts: imx6: add ZII RDU2 boards")
This Fixes tag and word 'Fix' in subject is inappropriate to me, as you
are not fixing something wrong from the beginning, but actually
replacing a deprecated property with new one.
Shawn
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index 7fff3717cf7c..a0f5cfda0055 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -384,7 +384,7 @@
> AVDD-supply = <®_3p3v>;
> IOVDD-supply = <®_3p3v>;
> DVDD-supply = <&vgen4_reg>;
> - gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;
> };
>
> accel at 1c {
> @@ -572,7 +572,7 @@
> AVDD-supply = <®_3p3v>;
> IOVDD-supply = <®_3p3v>;
> DVDD-supply = <&vgen4_reg>;
> - gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
> };
>
> touchscreen at 20 {
> --
> 2.18.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin
Date: Mon, 3 Sep 2018 12:54:28 +0800 [thread overview]
Message-ID: <20180903045426.GM3850@dragon> (raw)
In-Reply-To: <20180831191732.25504-1-afd@ti.com>
On Fri, Aug 31, 2018 at 02:17:31PM -0500, Andrew F. Davis wrote:
> The correct DT property for specifying a GPIO used for reset
> is "reset-gpios", fix this here.
>
> Fixes: d763762e3b58 ("ARM: dts: imx6: add ZII RDU2 boards")
This Fixes tag and word 'Fix' in subject is inappropriate to me, as you
are not fixing something wrong from the beginning, but actually
replacing a deprecated property with new one.
Shawn
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index 7fff3717cf7c..a0f5cfda0055 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -384,7 +384,7 @@
> AVDD-supply = <®_3p3v>;
> IOVDD-supply = <®_3p3v>;
> DVDD-supply = <&vgen4_reg>;
> - gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;
> };
>
> accel@1c {
> @@ -572,7 +572,7 @@
> AVDD-supply = <®_3p3v>;
> IOVDD-supply = <®_3p3v>;
> DVDD-supply = <&vgen4_reg>;
> - gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>;
> + reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
> };
>
> touchscreen@20 {
> --
> 2.18.0
>
next prev parent reply other threads:[~2018-09-03 4:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 19:17 [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin Andrew F. Davis
2018-08-31 19:17 ` [PATCH 2/2] ARM: dts: imx: " Andrew F. Davis
2018-09-03 4:54 ` Shawn Guo [this message]
2018-09-03 4:54 ` [PATCH 1/2] ARM: dts: imx6: RDU2: " Shawn Guo
2018-09-04 13:35 ` Andrew F. Davis
2018-09-04 13:35 ` Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903045426.GM3850@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.