From: Mark Brown <broonie@kernel.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH] ASoC: tlv320aic31xx: Add MICBIAS off setting
Date: Mon, 3 Sep 2018 12:26:56 +0100 [thread overview]
Message-ID: <20180903112656.GF10302@sirena.org.uk> (raw)
In-Reply-To: <20180831180507.28867-1-afd@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 698 bytes --]
On Fri, Aug 31, 2018 at 01:05:07PM -0500, Andrew F. Davis wrote:
> Leaving microphone bias off is a valid setting and even used in the DT
> binding document example. Add this setting here and document the same.
> Although it may not make much sense to enable a microphone here without
> any bias, it is a valid setting that can be chosen by DT and may be
> needed for some boards.
If we really want to pay attention to something setting this up we'd
need to completely remove the widget - what the code is doing at the
minute is setting the voltage that the bias will go to when enabled,
there's still a widget for turning it on and off. There's some chance
that this will break existing boards.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: "Andrew F. Davis" <afd@ti.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: tlv320aic31xx: Add MICBIAS off setting
Date: Mon, 3 Sep 2018 12:26:56 +0100 [thread overview]
Message-ID: <20180903112656.GF10302@sirena.org.uk> (raw)
In-Reply-To: <20180831180507.28867-1-afd@ti.com>
[-- Attachment #1: Type: text/plain, Size: 698 bytes --]
On Fri, Aug 31, 2018 at 01:05:07PM -0500, Andrew F. Davis wrote:
> Leaving microphone bias off is a valid setting and even used in the DT
> binding document example. Add this setting here and document the same.
> Although it may not make much sense to enable a microphone here without
> any bias, it is a valid setting that can be chosen by DT and may be
> needed for some boards.
If we really want to pay attention to something setting this up we'd
need to completely remove the widget - what the code is doing at the
minute is setting the voltage that the bias will go to when enabled,
there's still a widget for turning it on and off. There's some chance
that this will break existing boards.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-09-03 11:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 18:05 [PATCH] ASoC: tlv320aic31xx: Add MICBIAS off setting Andrew F. Davis
2018-08-31 18:05 ` Andrew F. Davis
2018-09-03 11:26 ` Mark Brown [this message]
2018-09-03 11:26 ` Mark Brown
2018-09-04 13:55 ` Andrew F. Davis
2018-09-04 13:55 ` Andrew F. Davis
2018-09-04 14:41 ` Mark Brown
2018-09-04 14:41 ` Mark Brown
2018-09-04 14:43 ` Andrew F. Davis
2018-09-04 14:43 ` Andrew F. Davis
2018-09-04 14:55 ` Mark Brown
2018-09-04 14:55 ` Mark Brown
2018-09-04 15:10 ` Andrew F. Davis
2018-09-04 15:10 ` Andrew F. Davis
2018-09-04 15:56 ` Mark Brown
2018-09-04 16:02 ` Andrew F. Davis
2018-09-04 16:02 ` Andrew F. Davis
2018-09-04 16:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903112656.GF10302@sirena.org.uk \
--to=broonie@kernel.org \
--cc=afd@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.