Re: [Qemu-devel] [RFC 6/6] virtio-net: rss: Add bpf filter

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Aug 30, 2018 at 05:27:08PM +0300, Sameeh Jubran wrote:
> From: Sameeh Jubran <sjubran@redhat.com>
> 
> Signed-off-by: Sameeh Jubran <sjubran@redhat.com>
> ---
>  hw/net/rss_bpf_insns.h       | 3992 ++++++++++++++++++++++++++++++++++++++++++
>  hw/net/rss_tap_bpf.h         |   40 +
>  hw/net/rss_tap_bpf_program.c |  175 ++
>  hw/net/virtio-net.c          |   99 +-
>  4 files changed, 4305 insertions(+), 1 deletion(-)
>  create mode 100644 hw/net/rss_bpf_insns.h
>  create mode 100644 hw/net/rss_tap_bpf.h
>  create mode 100644 hw/net/rss_tap_bpf_program.c
> 

> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index 4a52a6a1d0..66b2140cc7 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -27,6 +27,10 @@
>  #include "hw/virtio/virtio-access.h"
>  #include "migration/misc.h"
>  #include "standard-headers/linux/ethtool.h"
> +#include <sys/syscall.h>
> +#include <linux/bpf.h>

This breaks the build on platforms without bpf.h - you checked for
this in configure, but then never made use of the CONFIG_BPF conditional
in the code.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|