From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Sameeh Jubran <sameeh@daynix.com>,
Yan Vugenfirer <yan@daynix.com>, Jason Wang <jasowang@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [RFC 1/6] Add bpf support to qemu
Date: Mon, 3 Sep 2018 13:29:15 +0100 [thread overview]
Message-ID: <20180903122915.GE14377@redhat.com> (raw)
In-Reply-To: <CAFEAcA8HATZQqawAX3=OPmas6uzp0UAciK7QXo=uuRbCfvUjaQ@mail.gmail.com>
On Mon, Sep 03, 2018 at 01:24:16PM +0100, Peter Maydell wrote:
> On 3 September 2018 at 12:59, Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> >> ##########################################
> >> +# check for usable bpf system call
> >> +if test "$bpf" = "yes"; then
> >
> > if test "x$bpf" != "xno"; then
>
> We don't use the leading-x thingy elsewhere in configure,
> why is this condition special?
> (We can assume we don't have a broken shell, and we
> know that $bpf won't be a string starting with a hyphen.)
It is just my habit. Drop the 'x' prefix if that's not used in QEMU's
configure script normally.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2018-09-03 12:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 14:27 [Qemu-devel] [RFC 0/6] Virtio-net: Support RSS Sameeh Jubran
2018-08-30 14:27 ` [Qemu-devel] [RFC 1/6] Add bpf support to qemu Sameeh Jubran
2018-09-03 11:59 ` Daniel P. Berrangé
2018-09-03 12:18 ` Sameeh Jubran
2018-09-03 12:24 ` Peter Maydell
2018-09-03 12:28 ` Sameeh Jubran
2018-09-03 12:29 ` Daniel P. Berrangé [this message]
2018-08-30 14:27 ` [Qemu-devel] [RFC 2/6] tap: Add support for bpf ioctls Sameeh Jubran
2018-08-30 15:21 ` Eric Blake
2018-09-03 11:34 ` Sameeh Jubran
2018-09-03 3:24 ` Jason Wang
2018-09-03 11:33 ` Sameeh Jubran
2018-08-30 14:27 ` [Qemu-devel] [RFC 3/6] vhost-net: Expose vhost_net_get_fd Sameeh Jubran
2018-09-03 3:24 ` Jason Wang
2018-09-03 11:56 ` Sameeh Jubran
2018-08-30 14:27 ` [Qemu-devel] [RFC 4/6] virtio-net: implement steering mode feature Sameeh Jubran
2018-09-03 3:34 ` Jason Wang
2018-09-03 12:51 ` Sameeh Jubran
2018-08-30 14:27 ` [Qemu-devel] [RFC 5/6] virtio-net: steering mode: Implement rss support Sameeh Jubran
2018-09-03 3:48 ` Jason Wang
2018-09-03 11:45 ` Sameeh Jubran
2018-08-30 14:27 ` [Qemu-devel] [RFC 6/6] virtio-net: rss: Add bpf filter Sameeh Jubran
2018-09-03 4:12 ` Jason Wang
2018-09-03 13:16 ` Sameeh Jubran
2018-09-04 3:03 ` Jason Wang
2018-09-03 11:54 ` Daniel P. Berrangé
2018-09-03 12:35 ` Sameeh Jubran
2018-09-03 12:49 ` Daniel P. Berrangé
2018-09-04 3:07 ` Jason Wang
2018-09-04 8:14 ` Daniel P. Berrangé
2018-09-06 5:26 ` Jason Wang
2018-10-04 13:30 ` Daniel P. Berrangé
2018-09-03 12:11 ` Daniel P. Berrangé
2018-09-04 20:11 ` Eric Blake
2018-09-03 4:15 ` [Qemu-devel] [RFC 0/6] Virtio-net: Support RSS Jason Wang
2018-09-03 9:52 ` Sameeh Jubran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903122915.GE14377@redhat.com \
--to=berrange@redhat.com \
--cc=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sameeh@daynix.com \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.