From: hch@infradead.org (Christoph Hellwig)
To: linux-riscv@lists.infradead.org
Subject: [PATCH v2 3/3] RISC-V: Support cpu hotplug.
Date: Tue, 4 Sep 2018 14:36:23 -0700 [thread overview]
Message-ID: <20180904213623.GA2078@infradead.org> (raw)
In-Reply-To: <0d439b9d-b3d0-7d2c-117b-abb37adf769c@wdc.com>
On Tue, Sep 04, 2018 at 11:08:35AM -0700, Atish Patra wrote:
>
> I have kept it here to match all other arch. Same goes for all hotplug
> functions in smpboot.c
>
> I can move them to a separate file if you think that provides better code
> readability and structure.
I don't really have a strong opinion, but keeping this code together
and reducing the ifdef maze seems worthwile to me.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Atish Patra <atish.patra@wdc.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"palmer@sifive.com" <palmer@sifive.com>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"anup@brainfault.org" <anup@brainfault.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"damein@vger.kernel.org" <damein@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] RISC-V: Support cpu hotplug.
Date: Tue, 4 Sep 2018 14:36:23 -0700 [thread overview]
Message-ID: <20180904213623.GA2078@infradead.org> (raw)
In-Reply-To: <0d439b9d-b3d0-7d2c-117b-abb37adf769c@wdc.com>
On Tue, Sep 04, 2018 at 11:08:35AM -0700, Atish Patra wrote:
>
> I have kept it here to match all other arch. Same goes for all hotplug
> functions in smpboot.c
>
> I can move them to a separate file if you think that provides better code
> readability and structure.
I don't really have a strong opinion, but keeping this code together
and reducing the ifdef maze seems worthwile to me.
next prev parent reply other threads:[~2018-09-04 21:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 8:36 [PATCH v2 0/3] RISC-V: Add new smp features Atish Patra
2018-08-28 8:36 ` [PATCH v2 1/3] RISC-V: Add logical CPU indexing for RISC-V Atish Patra
2018-08-31 6:03 ` Christoph Hellwig
2018-08-31 6:03 ` Christoph Hellwig
2018-09-04 17:59 ` Atish Patra
2018-09-04 17:59 ` Atish Patra
2018-08-28 8:36 ` [PATCH v2 2/3] RISC-V: Use Linux logical cpu number instead of hartid Atish Patra
2018-08-31 6:11 ` Christoph Hellwig
2018-08-31 6:11 ` Christoph Hellwig
2018-09-04 20:35 ` Atish Patra
2018-09-04 20:35 ` Atish Patra
2018-09-04 21:36 ` Christoph Hellwig
2018-09-04 21:36 ` Christoph Hellwig
2018-09-04 21:43 ` Atish Patra
2018-09-04 21:43 ` Atish Patra
2018-09-05 19:03 ` Christoph Hellwig
2018-09-05 19:03 ` Christoph Hellwig
2018-08-28 8:36 ` [PATCH v2 3/3] RISC-V: Support cpu hotplug Atish Patra
2018-08-31 6:18 ` Christoph Hellwig
2018-08-31 6:18 ` Christoph Hellwig
2018-09-04 18:08 ` Atish Patra
2018-09-04 18:08 ` Atish Patra
2018-09-04 21:36 ` Christoph Hellwig [this message]
2018-09-04 21:36 ` Christoph Hellwig
2018-09-04 21:40 ` Atish Patra
2018-09-04 21:40 ` Atish Patra
2018-08-30 13:53 ` [PATCH v2 0/3] RISC-V: Add new smp features Anup Patel
2018-08-30 13:53 ` Anup Patel
2018-08-30 14:11 ` Christoph Hellwig
2018-08-30 14:11 ` Christoph Hellwig
2018-08-30 14:15 ` Anup Patel
2018-08-30 14:15 ` Anup Patel
2018-08-30 14:18 ` Anup Patel
2018-08-30 14:18 ` Anup Patel
2018-08-30 16:04 ` Atish Patra
2018-08-30 16:04 ` Atish Patra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180904213623.GA2078@infradead.org \
--to=hch@infradead.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.