From: Johan Hovold <johan@kernel.org>
To: Karoly Pados <pados@pados.hu>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Loic Poulain <loic.poulain@linaro.org>,
andy.shevchenko@gmail.com, ajaykuee@gmail.com,
daniel.thompson@linaro.org
Subject: USB: serial: ftdi_sio: implement GPIO support for FT230X
Date: Wed, 5 Sep 2018 10:21:31 +0200 [thread overview]
Message-ID: <20180905082131.GV28861@localhost> (raw)
On Tue, Sep 04, 2018 at 06:07:49PM +0000, Karoly Pados wrote:
> >>> + priv->gc.ngpio = 4;
> >>
> >> Shouldn't this be handled the other way round? IIRC there are two FTX
> >> device types with four pins, and one type where only one pin is
> >> accessible.
> >
> > There are 4 devices with 1 GPIO, 1 device with 2 GPIOs, 2 devices with 4 GPIOs,
> > and 1 device with 6 GPIOs. Source: http://www.ftdichip.com/FT-X.htm (2nd table)
> > Do you still want me turn this over?
> >
>
> Aaah, but those other devices are not UART bridges. I see what you mean now.
> The point for me when developing th original patch
The last sentence looks incomplete; did you hit send too soon or too
late? ;)
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Karoly Pados <pados@pados.hu>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Loic Poulain <loic.poulain@linaro.org>,
andy.shevchenko@gmail.com, ajaykuee@gmail.com,
daniel.thompson@linaro.org
Subject: Re: [PATCH] USB: serial: ftdi_sio: implement GPIO support for FT230X
Date: Wed, 5 Sep 2018 10:21:31 +0200 [thread overview]
Message-ID: <20180905082131.GV28861@localhost> (raw)
In-Reply-To: <680c039b5fb2beafa48ea12e492341db@pados.hu>
On Tue, Sep 04, 2018 at 06:07:49PM +0000, Karoly Pados wrote:
> >>> + priv->gc.ngpio = 4;
> >>
> >> Shouldn't this be handled the other way round? IIRC there are two FTX
> >> device types with four pins, and one type where only one pin is
> >> accessible.
> >
> > There are 4 devices with 1 GPIO, 1 device with 2 GPIOs, 2 devices with 4 GPIOs,
> > and 1 device with 6 GPIOs. Source: http://www.ftdichip.com/FT-X.htm (2nd table)
> > Do you still want me turn this over?
> >
>
> Aaah, but those other devices are not UART bridges. I see what you mean now.
> The point for me when developing th original patch
The last sentence looks incomplete; did you hit send too soon or too
late? ;)
Johan
next reply other threads:[~2018-09-05 8:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 8:21 Johan Hovold [this message]
2018-09-05 8:21 ` [PATCH] USB: serial: ftdi_sio: implement GPIO support for FT230X Johan Hovold
-- strict thread matches above, loose matches on Subject: below --
2018-09-05 10:36 Johan Hovold
2018-09-05 10:36 ` [PATCH] " Johan Hovold
2018-09-05 8:19 Johan Hovold
2018-09-05 8:19 ` [PATCH] " Johan Hovold
2018-09-04 18:07 Karoly Pados
2018-09-04 18:07 ` [PATCH] " Karoly Pados
2018-09-04 17:53 Karoly Pados
2018-09-04 17:53 ` [PATCH] " Karoly Pados
2018-09-04 12:49 Johan Hovold
2018-09-04 12:49 ` [PATCH] " Johan Hovold
2018-08-28 0:44 kbuild test robot
2018-08-28 0:44 ` [PATCH] " kbuild test robot
2018-08-25 20:47 Karoly Pados
2018-08-25 20:47 ` [PATCH] " Karoly Pados
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905082131.GV28861@localhost \
--to=johan@kernel.org \
--cc=ajaykuee@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=pados@pados.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.