From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Peter Huewe <peterhuewe@gmx.de>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCH] tpm: Make SECURITYFS a weak dependency
Date: Wed, 5 Sep 2018 14:28:47 +0300 [thread overview]
Message-ID: <20180905112847.GC9696@linux.intel.com> (raw)
In-Reply-To: <20180903195151.7576-1-peterhuewe@gmx.de>
On Mon, Sep 03, 2018 at 09:51:51PM +0200, Peter Huewe wrote:
> While having SECURITYFS enabled for the tpm subsystem is beneficial in
> most cases, it is not strictly necessary to have it enabled at all.
> Especially on platforms without any boot firmware integration of the TPM
> (e.g. raspberry pi) it does not add any value for the tpm subsystem,
> as there is no eventlog present.
>
> By turning it from 'select' to 'imply' it still gets selected per
> default, but enables users who want to save some kb of ram by turning
> SECURITYFS off.
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> ---
> drivers/char/tpm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index 18c81cbe4704..536e55d3919f 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -5,7 +5,7 @@
> menuconfig TCG_TPM
> tristate "TPM Hardware Support"
> depends on HAS_IOMEM
> - select SECURITYFS
> + imply SECURITYFS
> select CRYPTO
> select CRYPTO_HASH_INFO
> ---help---
> --
> 2.16.4
>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH] tpm: Make SECURITYFS a weak dependency
Date: Wed, 5 Sep 2018 14:28:47 +0300 [thread overview]
Message-ID: <20180905112847.GC9696@linux.intel.com> (raw)
In-Reply-To: <20180903195151.7576-1-peterhuewe@gmx.de>
On Mon, Sep 03, 2018 at 09:51:51PM +0200, Peter Huewe wrote:
> While having SECURITYFS enabled for the tpm subsystem is beneficial in
> most cases, it is not strictly necessary to have it enabled at all.
> Especially on platforms without any boot firmware integration of the TPM
> (e.g. raspberry pi) it does not add any value for the tpm subsystem,
> as there is no eventlog present.
>
> By turning it from 'select' to 'imply' it still gets selected per
> default, but enables users who want to save some kb of ram by turning
> SECURITYFS off.
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> ---
> drivers/char/tpm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index 18c81cbe4704..536e55d3919f 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -5,7 +5,7 @@
> menuconfig TCG_TPM
> tristate "TPM Hardware Support"
> depends on HAS_IOMEM
> - select SECURITYFS
> + imply SECURITYFS
> select CRYPTO
> select CRYPTO_HASH_INFO
> ---help---
> --
> 2.16.4
>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
next prev parent reply other threads:[~2018-09-05 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 19:51 [PATCH] tpm: Make SECURITYFS a weak dependency Peter Huewe
2018-09-03 19:51 ` Peter Huewe
2018-09-05 11:28 ` Jarkko Sakkinen [this message]
2018-09-05 11:28 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180905112847.GC9696@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.