All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly
Date: Thu, 6 Sep 2018 20:40:49 +0200	[thread overview]
Message-ID: <20180906184049.GF8607@kunai> (raw)
In-Reply-To: <20180823225731.19063-1-jae.hyun.yoo@linux.intel.com>

On Thu, Aug 23, 2018 at 03:57:31PM -0700, Jae Hyun Yoo wrote:
> In most of cases, interrupt bits are set one by one but there are
> also a lot of other cases that Aspeed I2C IP sends multiple
> interrupt bits with combining master and slave events using a
> single interrupt call. It happens much more in multi-master
> environment than single-master. For an example, when master is
> waiting for a NORMAL_STOP interrupt in its MASTER_STOP state,
> SLAVE_MATCH and RX_DONE interrupts could come along with the
> NORMAL_STOP in case of an another master immediately sends data
> just after acquiring the bus. In this case, the NORMAL_STOP
> interrupt should be handled by master_irq and the SLAVE_MATCH and
> RX_DONE interrupts should be handled by slave_irq. This commit
> modifies irq hadling logic to handle the master/slave combined
> events properly.
> 
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

Applied to for-next, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/linux-aspeed/attachments/20180906/e639f9f3/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>
Cc: Brendan Higgins <brendanhiggins@google.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
	linux-i2c@vger.kernel.org, openbmc@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	James Feist <james.feist@linux.intel.com>,
	Vernon Mauery <vernon.mauery@linux.intel.com>
Subject: Re: [PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly
Date: Thu, 6 Sep 2018 20:40:49 +0200	[thread overview]
Message-ID: <20180906184049.GF8607@kunai> (raw)
In-Reply-To: <20180823225731.19063-1-jae.hyun.yoo@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

On Thu, Aug 23, 2018 at 03:57:31PM -0700, Jae Hyun Yoo wrote:
> In most of cases, interrupt bits are set one by one but there are
> also a lot of other cases that Aspeed I2C IP sends multiple
> interrupt bits with combining master and slave events using a
> single interrupt call. It happens much more in multi-master
> environment than single-master. For an example, when master is
> waiting for a NORMAL_STOP interrupt in its MASTER_STOP state,
> SLAVE_MATCH and RX_DONE interrupts could come along with the
> NORMAL_STOP in case of an another master immediately sends data
> just after acquiring the bus. In this case, the NORMAL_STOP
> interrupt should be handled by master_irq and the SLAVE_MATCH and
> RX_DONE interrupts should be handled by slave_irq. This commit
> modifies irq hadling logic to handle the master/slave combined
> events properly.
> 
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly
Date: Thu, 6 Sep 2018 20:40:49 +0200	[thread overview]
Message-ID: <20180906184049.GF8607@kunai> (raw)
In-Reply-To: <20180823225731.19063-1-jae.hyun.yoo@linux.intel.com>

On Thu, Aug 23, 2018 at 03:57:31PM -0700, Jae Hyun Yoo wrote:
> In most of cases, interrupt bits are set one by one but there are
> also a lot of other cases that Aspeed I2C IP sends multiple
> interrupt bits with combining master and slave events using a
> single interrupt call. It happens much more in multi-master
> environment than single-master. For an example, when master is
> waiting for a NORMAL_STOP interrupt in its MASTER_STOP state,
> SLAVE_MATCH and RX_DONE interrupts could come along with the
> NORMAL_STOP in case of an another master immediately sends data
> just after acquiring the bus. In this case, the NORMAL_STOP
> interrupt should be handled by master_irq and the SLAVE_MATCH and
> RX_DONE interrupts should be handled by slave_irq. This commit
> modifies irq hadling logic to handle the master/slave combined
> events properly.
> 
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>

Applied to for-next, thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180906/e639f9f3/attachment.sig>

  parent reply	other threads:[~2018-09-06 18:40 UTC|newest]

Thread overview: 119+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-23 22:57 [PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly Jae Hyun Yoo
2018-08-23 22:57 ` Jae Hyun Yoo
2018-08-23 22:57 ` Jae Hyun Yoo
2018-08-23 22:57 ` Jae Hyun Yoo
2018-09-06 17:26 ` Brendan Higgins
2018-09-06 17:26   ` Brendan Higgins
2018-09-06 17:26   ` Brendan Higgins
2018-09-06 17:32   ` Jae Hyun Yoo
2018-09-06 17:32     ` Jae Hyun Yoo
2018-09-06 17:32     ` Jae Hyun Yoo
2018-09-06 18:08     ` Wolfram Sang
2018-09-06 18:08       ` Wolfram Sang
2018-09-06 18:08       ` Wolfram Sang
2018-09-06 18:33       ` Jae Hyun Yoo
2018-09-06 18:33         ` Jae Hyun Yoo
2018-09-06 18:33         ` Jae Hyun Yoo
2018-09-06 18:40 ` Wolfram Sang [this message]
2018-09-06 18:40   ` Wolfram Sang
2018-09-06 18:40   ` Wolfram Sang
2018-09-11 18:37 ` Guenter Roeck
2018-09-11 18:37   ` Guenter Roeck
2018-09-11 18:37   ` Guenter Roeck
2018-09-11 18:45   ` Cédric Le Goater
2018-09-11 18:45     ` Cédric Le Goater
2018-09-11 18:45     ` Cédric Le Goater
2018-09-11 18:45     ` Cédric Le Goater
2018-09-11 20:30   ` Jae Hyun Yoo
2018-09-11 20:30     ` Jae Hyun Yoo
2018-09-11 20:30     ` Jae Hyun Yoo
2018-09-11 20:41     ` Guenter Roeck
2018-09-11 20:41       ` Guenter Roeck
2018-09-11 20:41       ` Guenter Roeck
2018-09-11 22:18       ` Jae Hyun Yoo
2018-09-11 22:18         ` Jae Hyun Yoo
2018-09-11 22:18         ` Jae Hyun Yoo
2018-09-11 22:24         ` [PATCH] Revert "i2c: aspeed: Handle master/slave combined irq events properly" Jae Hyun Yoo
2018-09-11 22:24           ` Jae Hyun Yoo
2018-09-11 22:24           ` Jae Hyun Yoo
2018-09-11 22:24           ` Jae Hyun Yoo
2018-09-11 22:53         ` [PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly Joel Stanley
2018-09-11 22:53           ` Joel Stanley
2018-09-11 22:53           ` Joel Stanley
2018-09-11 23:33           ` Guenter Roeck
2018-09-11 23:33             ` Guenter Roeck
2018-09-11 23:33             ` Guenter Roeck
2018-09-11 23:58             ` Jae Hyun Yoo
2018-09-11 23:58               ` Jae Hyun Yoo
2018-09-11 23:58               ` Jae Hyun Yoo
2018-09-12  1:34               ` Guenter Roeck
2018-09-12  1:34                 ` Guenter Roeck
2018-09-12  1:34                 ` Guenter Roeck
2018-09-12 16:54                 ` Jae Hyun Yoo
2018-09-12 16:54                   ` Jae Hyun Yoo
2018-09-12 16:54                   ` Jae Hyun Yoo
2018-09-12 19:58                   ` Guenter Roeck
2018-09-12 19:58                     ` Guenter Roeck
2018-09-12 19:58                     ` Guenter Roeck
2018-09-12 20:10                     ` Jae Hyun Yoo
2018-09-12 20:10                       ` Jae Hyun Yoo
2018-09-12 20:10                       ` Jae Hyun Yoo
2018-09-12 20:30                       ` Guenter Roeck
2018-09-12 20:30                         ` Guenter Roeck
2018-09-12 20:30                         ` Guenter Roeck
2018-09-12 22:31                         ` Jae Hyun Yoo
2018-09-12 22:31                           ` Jae Hyun Yoo
2018-09-12 22:31                           ` Jae Hyun Yoo
2018-09-12 23:30                           ` Guenter Roeck
2018-09-12 23:30                             ` Guenter Roeck
2018-09-12 23:30                             ` Guenter Roeck
2018-09-13  5:45                         ` Cédric Le Goater
2018-09-13  5:45                           ` Cédric Le Goater
2018-09-13  5:45                           ` Cédric Le Goater
2018-09-13  5:45                           ` Cédric Le Goater
2018-09-13 13:33                           ` Guenter Roeck
2018-09-13 13:33                             ` Guenter Roeck
2018-09-13 13:33                             ` Guenter Roeck
2018-09-13 15:48                             ` Cédric Le Goater
2018-09-13 15:48                               ` Cédric Le Goater
2018-09-13 15:48                               ` Cédric Le Goater
2018-09-13 15:48                               ` Cédric Le Goater
2018-09-13 15:57                               ` Guenter Roeck
2018-09-13 15:57                                 ` Guenter Roeck
2018-09-13 15:57                                 ` Guenter Roeck
2018-09-13 16:35                                 ` Cédric Le Goater
2018-09-13 16:35                                   ` Cédric Le Goater
2018-09-13 16:35                                   ` Cédric Le Goater
2018-09-13 16:35                                   ` Cédric Le Goater
2018-09-14  3:48                                   ` Guenter Roeck
2018-09-14  3:48                                     ` Guenter Roeck
2018-09-14  3:48                                     ` Guenter Roeck
2018-09-14  3:48                                     ` Guenter Roeck
2018-09-14  5:38                                     ` Cédric Le Goater
2018-09-14  5:38                                       ` Cédric Le Goater
2018-09-14  5:38                                       ` Cédric Le Goater
2018-09-14  5:38                                       ` Cédric Le Goater
2018-09-14 13:23                                       ` Guenter Roeck
2018-09-14 13:23                                         ` Guenter Roeck
2018-09-14 13:23                                         ` Guenter Roeck
2018-09-14 16:52                                         ` Jae Hyun Yoo
2018-09-14 16:52                                           ` Jae Hyun Yoo
2018-09-14 16:52                                           ` Jae Hyun Yoo
2018-09-13  5:47                   ` Cédric Le Goater
2018-09-13  5:47                     ` Cédric Le Goater
2018-09-13  5:47                     ` Cédric Le Goater
2018-09-13  5:47                     ` Cédric Le Goater
2018-09-13 16:31                     ` Jae Hyun Yoo
2018-09-13 16:31                       ` Jae Hyun Yoo
2018-09-13 16:31                       ` Jae Hyun Yoo
2018-09-13 16:51                       ` Cédric Le Goater
2018-09-13 16:51                         ` Cédric Le Goater
2018-09-13 16:51                         ` Cédric Le Goater
2018-09-13 16:51                         ` Cédric Le Goater
2018-09-13 17:01                         ` Jae Hyun Yoo
2018-09-13 17:01                           ` Jae Hyun Yoo
2018-09-13 17:01                           ` Jae Hyun Yoo
2018-09-12  5:57             ` Cédric Le Goater
2018-09-12  5:57               ` Cédric Le Goater
2018-09-12  5:57               ` Cédric Le Goater
2018-09-12  5:57               ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180906184049.GF8607@kunai \
    --to=wsa@the-dreams.de \
    --cc=linux-aspeed@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.