From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sean Wang <sean.wang@mediatek.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] usb: xhci: fix interrupt transfer error happened on MTK platforms
Date: Fri, 7 Sep 2018 10:56:45 +0200 [thread overview]
Message-ID: <20180907085645.GA17270@kroah.com> (raw)
In-Reply-To: <1536309826.32173.45.camel@mhfsdcap03>
On Fri, Sep 07, 2018 at 04:43:46PM +0800, Chunfeng Yun wrote:
> Hi,
>
> On Fri, 2018-09-07 at 09:42 +0200, Greg Kroah-Hartman wrote:
> > On Fri, Sep 07, 2018 at 03:29:12PM +0800, Chunfeng Yun wrote:
> > > The MTK xHCI controller use some reserved bytes in endpoint context for
> > > bandwidth scheduling, so need keep them in xhci_endpoint_copy();
> >
> > If they are "reserved" shouldn't they be properly named? And by using
> > reserved bytes, isn't that a spec violation?
> It indeed violates the spec, "they shall be treated by system software
> as Reserved and Opaque", and it's a quirk of the MTK xHCI controller.
So as the "system software" here, we should just ignore them otherwise
we violate the spec? :)
Anyway, that's fine, no objection from me for the patch, thanks.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sean Wang <sean.wang@mediatek.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, stable@vger.kernel.org
Subject: [v2] usb: xhci: fix interrupt transfer error happened on MTK platforms
Date: Fri, 7 Sep 2018 10:56:45 +0200 [thread overview]
Message-ID: <20180907085645.GA17270@kroah.com> (raw)
On Fri, Sep 07, 2018 at 04:43:46PM +0800, Chunfeng Yun wrote:
> Hi,
>
> On Fri, 2018-09-07 at 09:42 +0200, Greg Kroah-Hartman wrote:
> > On Fri, Sep 07, 2018 at 03:29:12PM +0800, Chunfeng Yun wrote:
> > > The MTK xHCI controller use some reserved bytes in endpoint context for
> > > bandwidth scheduling, so need keep them in xhci_endpoint_copy();
> >
> > If they are "reserved" shouldn't they be properly named? And by using
> > reserved bytes, isn't that a spec violation?
> It indeed violates the spec, "they shall be treated by system software
> as Reserved and Opaque", and it's a quirk of the MTK xHCI controller.
So as the "system software" here, we should just ignore them otherwise
we violate the spec? :)
Anyway, that's fine, no objection from me for the patch, thanks.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] usb: xhci: fix interrupt transfer error happened on MTK platforms
Date: Fri, 7 Sep 2018 10:56:45 +0200 [thread overview]
Message-ID: <20180907085645.GA17270@kroah.com> (raw)
In-Reply-To: <1536309826.32173.45.camel@mhfsdcap03>
On Fri, Sep 07, 2018 at 04:43:46PM +0800, Chunfeng Yun wrote:
> Hi,
>
> On Fri, 2018-09-07 at 09:42 +0200, Greg Kroah-Hartman wrote:
> > On Fri, Sep 07, 2018 at 03:29:12PM +0800, Chunfeng Yun wrote:
> > > The MTK xHCI controller use some reserved bytes in endpoint context for
> > > bandwidth scheduling, so need keep them in xhci_endpoint_copy();
> >
> > If they are "reserved" shouldn't they be properly named? And by using
> > reserved bytes, isn't that a spec violation?
> It indeed violates the spec, "they shall be treated by system software
> as Reserved and Opaque", and it's a quirk of the MTK xHCI controller.
So as the "system software" here, we should just ignore them otherwise
we violate the spec? :)
Anyway, that's fine, no objection from me for the patch, thanks.
greg k-h
next prev parent reply other threads:[~2018-09-07 8:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 7:29 [PATCH v2] usb: xhci: fix interrupt transfer error happened on MTK platforms Chunfeng Yun
2018-09-07 7:29 ` Chunfeng Yun
2018-09-07 7:29 ` Chunfeng Yun
2018-09-07 7:29 ` [v2] " Chunfeng Yun
2018-09-07 7:42 ` [PATCH v2] " Greg Kroah-Hartman
2018-09-07 7:42 ` Greg Kroah-Hartman
2018-09-07 7:42 ` [v2] " Greg Kroah-Hartman
2018-09-07 8:43 ` [PATCH v2] " Chunfeng Yun
2018-09-07 8:43 ` Chunfeng Yun
2018-09-07 8:43 ` Chunfeng Yun
2018-09-07 8:43 ` [v2] " Chunfeng Yun
2018-09-07 8:56 ` Greg Kroah-Hartman [this message]
2018-09-07 8:56 ` [PATCH v2] " Greg Kroah-Hartman
2018-09-07 8:56 ` [v2] " Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907085645.GA17270@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@mediatek.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.